Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a347544a-ff06-5f62-0ac1-27ff7a70b6bd@denx.de>
Date:   Tue, 1 Nov 2022 21:27:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [BlueZ] tools: Make hciattach_* firmware path build-time
 configurable
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org
References: <20221101115333.18223-1-marex@denx.de>
 <63612127.4a0a0220.ee3ae.be5c@mx.google.com>
 <1f4bcb64-9402-3975-960a-fc1c1f7cebe4@denx.de>
 <CABBYNZLQKEJZc_bDNOEqVHqZNv8pOnCxEAQBT68i693t87Ur_A@mail.gmail.com>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <CABBYNZLQKEJZc_bDNOEqVHqZNv8pOnCxEAQBT68i693t87Ur_A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/1/22 20:24, Luiz Augusto von Dentz wrote:
> Hi Marek,
> 
> On Tue, Nov 1, 2022 at 8:45 AM Marek Vasut <marex@denx.de> wrote:
>>
>> On 11/1/22 14:37, bluez.test.bot@gmail.com wrote:
>>> This is automated email and please do not reply to this email!
>>>
>>> Dear submitter,
>>>
>>> Thank you for submitting the patches to the linux bluetooth mailing list.
>>> This is a CI test results with your patch series:
>>> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690839
>>>
>>> ---Test result---
>>>
>>> Test Summary:
>>> CheckPatch                    PASS      1.01 seconds
>>> GitLint                       PASS      0.86 seconds
>>> Prep - Setup ELL              PASS      26.44 seconds
>>> Build - Prep                  PASS      0.68 seconds
>>> Build - Configure             PASS      8.16 seconds
>>> Build - Make                  PASS      723.76 seconds
>>> Make Check                    PASS      10.90 seconds
>>> Make Check w/Valgrind         PASS      287.82 seconds
>>> Make Distcheck                PASS      233.70 seconds
>>> Build w/ext ELL - Configure   PASS      8.17 seconds
>>> Build w/ext ELL - Make        PASS      83.94 seconds
>>> Incremental Build w/ patches  PASS      0.00 seconds
>>> Scan Build                    WARNING   476.19 seconds
>>>
>>> Details
>>> ##############################
>>> Test: Scan Build - WARNING
>>> Desc: Run Scan Build with patches
>>> Output:
>>> *****************************************************************************
>>> The bugs reported by the scan-build may or may not be caused by your patches.
>>> Please check the list and fix the bugs if they are caused by your patch.
>>> *****************************************************************************
>>> tools/hciattach_qualcomm.c:218:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
>>>                   if ((n = read_hci_event(fd, resp, 100)) < 0) {
>>>                        ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> tools/hciattach_qualcomm.c:253:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
>>>                   if ((n = read_hci_event(fd, resp, 100)) < 0) {
>>>                        ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> 2 warnings generated.
>>
>> That's unlikely caused by this patch.
> 
> Yep, the scan-build rebuilds the file you have changed so any problem
> it finds in that file will be reported, anyway I can ignore the
> warnings but patches to fix these warnings are welcome as well.

Done