Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52c65cd1-9631-50a7-aded-7e4a877bbad9@denx.de>
Date:   Tue, 1 Nov 2022 23:52:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [1/2] dt-bindings: net: broadcom-bluetooth: Add CYW4373A0 DT
 binding
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org
References: <20221031204804.195267-1-marex@denx.de>
 <6360471e.4a0a0220.4aceb.91b7@mx.google.com>
 <a7485b76-b4aa-a6d6-b509-c6f370380926@denx.de>
 <CABBYNZLpaT7FCwXrGq8RU4owP74VA7Eo99jceFzVsqqVnYFaHw@mail.gmail.com>
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <CABBYNZLpaT7FCwXrGq8RU4owP74VA7Eo99jceFzVsqqVnYFaHw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/1/22 23:44, Luiz Augusto von Dentz wrote:
> Hi Marek,

Hi,

> On Tue, Nov 1, 2022 at 3:38 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 10/31/22 23:07, bluez.test.bot@gmail.com wrote:
>>> This is automated email and please do not reply to this email!
>>>
>>> Dear submitter,
>>>
>>> Thank you for submitting the patches to the linux bluetooth mailing list.
>>> This is a CI test results with your patch series:
>>> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=690631
>>>
>>> ---Test result---
>>>
>>> Test Summary:
>>> CheckPatch                    PASS      2.99 seconds
>>> GitLint                       PASS      1.48 seconds
>>> SubjectPrefix                 FAIL      0.58 seconds
>>
>> Should the DT bindings really have Bluetooth: prefix/tag too ?
>> git log on prior art indicates they shouldn't .
> 
> If it is meant for bluetooth-next then yes it shall contain it since
> the CI does attempt to check its presence, in the other hand we could
> perhaps use the prefix [bluetooth] to avoid having the CI run on
> patches that are not meant for bluetooth-next but I don't think other
> subsystem do require this so it sort of hard to enforce proper
> prefixing.

Linux Documentation/devicetree/bindings seems to start with dt-bindings: 
prefix always, so maybe we should keep it that way ?

This binding document seems to follow the scheme now too:

next$ git log --oneline --follow 
Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
c8ce64900db47 dt-bindings: net: broadcom-bluetooth: Add conditional 
constraints
cba6164f7c5e3 dt-bindings: net: broadcom-bluetooth: Add CYW55572 DT binding
88b65887aa1b7 dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
0b4de2523f281 dt-bindings: net: broadcom-bluetooth: Add property for 
autobaud mode
88ffadce9d4cc dt-bindings: bluetooth: broadcom: Fix clocks check
71793730ebfdb Bluetooth: btbcm: Add BCM4334 DT binding
7820ee1c4757d Bluetooth: btbcm: Rewrite bindings in YAML and add reset