Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1277686rwb; Sun, 6 Nov 2022 22:51:03 -0800 (PST) X-Google-Smtp-Source: AMsMyM4PS7WaPGyCb9mpkHO6DTvmw3TFMf2BhxKe1s3XuyLeH037mYTMRtdqxtmnTfYN21Rksh+X X-Received: by 2002:a50:fb15:0:b0:464:4947:133 with SMTP id d21-20020a50fb15000000b0046449470133mr20135939edq.231.1667803863088; Sun, 06 Nov 2022 22:51:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667803863; cv=none; d=google.com; s=arc-20160816; b=Mm2vi2os2sgONmq0eTWh+5rBtmhB+58EJB5zQR5AhxT8577Z99smt6Pv+Lll+Aw00V RswwZN5MLV0Xu0QO0MTAz9+21X2cyzte1jrPxzeD3sLgFM3zTz5HZDqyFqABocaVQZrY heA+Ebh8UIu+pM7XTkzLZRRM9I8/YRjAGuI5upfXu2FzTSWzaPhZp/781mzKpMtplhXY WQY+jv+ww93DaPsOlztue8Kru0K6dndmpfZ6KNvpfjJ+s91NzmGlwDfUquNFoHf2vH7J U0I+Hq2arMHivGVX5JaaSBPJcsk3bytWfn2nVLad03GAPfU0j8Yyg8hluc13MJjpcZZ9 DE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=YhxHSbVpdxUsgd8PqvbbYUKKhoaOXSotkm3CoyNxy14=; b=Nx4yhk3hXuVNG3CcBZKT/XMqn83hWB9YBVOAzFfSh5MfoOt+lxnP3OSbKlWkxDfgLZ jDFPzuyOkHxT0hQ6oPJZfHdbLsMBdkBfGP7GoYPJ5JGQLerfNXhXxJwLnSfQTcN5MmPP eKh6bVfgNu72ClRJ8EnivBXuBXa6Cfafp8Jh1J2JXeddbuoNYoWIpuqALLuPdXo7p421 5uVmDm8Ss9Kge/W65dA1hYZNY9iBJsm3JHNpjIC3opqKUHj+XVYPSG8mjgJ3U9Q2+wDN DT0W1Nfe07RLBNlYN49c02pglpD9Te7NRwYUsaELljGnjJKvly61KS3Ar9WXcmCch1us Opng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EYjNnJVC; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l14-20020aa7d94e000000b004597b778b3bsi8089161eds.75.2022.11.06.22.50.22; Sun, 06 Nov 2022 22:51:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EYjNnJVC; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbiKGGjR (ORCPT + 99 others); Mon, 7 Nov 2022 01:39:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231373AbiKGGjP (ORCPT ); Mon, 7 Nov 2022 01:39:15 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F876576; Sun, 6 Nov 2022 22:39:14 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id d20so14691044ljc.12; Sun, 06 Nov 2022 22:39:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YhxHSbVpdxUsgd8PqvbbYUKKhoaOXSotkm3CoyNxy14=; b=EYjNnJVCjk8/LdUHzXwZFV0g2SWgE278DLW9zsNC6TTCIBlzwupO9ieIMfGhu7rZ+u mWmJd3ruVLfoZRLQy8FwUkNT+BkB6aR1AGU14+6/9E3FSTMAmjDlr4xFHRJSukWwlLit bd4FwLRBJ4oRAsEDDWqxFVaKGSjsArqjCu0oA3bCvCrszJsJc9zuk0uKpqhSpHclSWgK cbgg6ftj3jrFnrtSRJE8oBEaLbNZeXkScG56D6bLKb1+xHHNRZIXOmaFQoirwSUVxjr8 Pdk5w0av0n9fD41u5ACOn8A09kTtiQIsycNYp3hCBYNGeSBOt4vDtb4Mo3LKNM0k9tdk 7sTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YhxHSbVpdxUsgd8PqvbbYUKKhoaOXSotkm3CoyNxy14=; b=vVk1ZnC+nYpfU2bVatiP7NL551EfD2UZAvY8Xv/WJPZUyn4Cwl9VogCq/52n2EJvkn AhT/yGKtNHUzATlBH64ea9qS9zRyNRvOUeWNdjtq08lHL1IhH4/grh119IbFRU7s8e6Q 3ItC6L8lyjDN69l97ZEuXxev0yVylhR8+2mGf+coJ91lDlUWBB5laA2zGtMg8vEEUmXh o7elYaVPd4ieyshdvshqpvfp95biv6ERYeBxJOouJY1wA/ABEAi/ejMXibgEGcZ1s02z vuygHlK3NIgaKpWmtMBjxH8dW0c1hicdB6pcj08nozdSW5o9ink1/SG+l7adiyDTzZeI yh8w== X-Gm-Message-State: ANoB5pn6sJblHUuJ+wMq9LldOJcbyVO9GD1HkBomqMsuVEcpRAXLJ8Iz Dq6PWxGW+5oFFRqLrW5w54JHpr/q0IYB4tHqyKw= X-Received: by 2002:a2e:2e12:0:b0:278:acaa:acda with SMTP id u18-20020a2e2e12000000b00278acaaacdamr365840lju.305.1667803152130; Sun, 06 Nov 2022 22:39:12 -0800 (PST) MIME-Version: 1.0 References: <0000000000000bab2c05e95a81a3@google.com> <000000000000946f3005eca8cafe@google.com> In-Reply-To: From: Luiz Augusto von Dentz Date: Sun, 6 Nov 2022 22:39:00 -0800 Message-ID: Subject: Re: [syzbot] BUG: corrupted list in hci_conn_add_sysfs To: Dmitry Vyukov Cc: syzbot , davem@davemloft.net, edumazet@google.com, gregkh@linuxfoundation.org, johan.hedberg@gmail.com, kuba@kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, luiz.von.dentz@intel.com, marcel@holtmann.org, netdev@vger.kernel.org, pabeni@redhat.com, rafael@kernel.org, syzkaller-bugs@googlegroups.com, yin31149@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi, On Sun, Nov 6, 2022 at 3:25 PM Dmitry Vyukov wrote: > > On Fri, 4 Nov 2022 at 10:56, syzbot > wrote: > > > > syzbot suspects this issue was fixed by commit: > > > > commit 448a496f760664d3e2e79466aa1787e6abc922b5 > > Author: Luiz Augusto von Dentz > > Date: Mon Sep 19 17:56:59 2022 +0000 > > > > Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1052f8fe880000 > > start commit: dc164f4fb00a Merge tag 'for-linus-6.0-rc7' of git://git.ke.. > > git tree: upstream > > kernel config: https://syzkaller.appspot.com/x/.config?x=122d7bd4fc8e0ecb > > dashboard link: https://syzkaller.appspot.com/bug?extid=b30ccad4684cce846cef > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1110db8c880000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13e58aef080000 > > > > If the result looks correct, please mark the issue as fixed by replying with: > > > > #syz fix: Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > > Looks reasonable based on subsystem and the patch: > > #syz fix: Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times Looks like I did add a different link when fixing it: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=448a496f760664d3e2e79466aa1787e6abc922b5 Or perhaps they are duplicated? https://syzkaller.appspot.com/bug?id=da3246e2d33afdb92d66bc166a0934c5b146404a https://syzkaller.appspot.com/bug?extid=b30ccad4684cce846cef -- Luiz Augusto von Dentz