Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <0000000000000bab2c05e95a81a3@google.com> <000000000000946f3005eca8cafe@google.com>
 <CACT4Y+bX40TE_rx0SFnixoQVd_vHuGih9mtJA4TB7-dDOeguew@mail.gmail.com> <CABBYNZKyjFE_oVFDMj-U9uSax79bMimUCi1JyGBmyR_ufCNAUw@mail.gmail.com>
In-Reply-To: <CABBYNZKyjFE_oVFDMj-U9uSax79bMimUCi1JyGBmyR_ufCNAUw@mail.gmail.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Mon, 7 Nov 2022 13:37:40 -0800
Message-ID: <CACT4Y+a0ma3NRFFLTEHMOH_6Y6DqNet5sz6m6HQwVe8sTv2EQA@mail.gmail.com>
Subject: Re: [syzbot] BUG: corrupted list in hci_conn_add_sysfs
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     syzbot <syzbot+b30ccad4684cce846cef@syzkaller.appspotmail.com>,
        davem@davemloft.net, edumazet@google.com,
        gregkh@linuxfoundation.org, johan.hedberg@gmail.com,
        kuba@kernel.org, linux-bluetooth@vger.kernel.org,
        linux-kernel@vger.kernel.org, luiz.von.dentz@intel.com,
        marcel@holtmann.org, netdev@vger.kernel.org, pabeni@redhat.com,
        rafael@kernel.org, syzkaller-bugs@googlegroups.com,
        yin31149@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 6 Nov 2022 at 22:39, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi,
>
> On Sun, Nov 6, 2022 at 3:25 PM Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> > On Fri, 4 Nov 2022 at 10:56, syzbot
> > <syzbot+b30ccad4684cce846cef@syzkaller.appspotmail.com> wrote:
> > >
> > > syzbot suspects this issue was fixed by commit:
> > >
> > > commit 448a496f760664d3e2e79466aa1787e6abc922b5
> > > Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > > Date:   Mon Sep 19 17:56:59 2022 +0000
> > >
> > >     Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times
> > >
> > > bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=1052f8fe880000
> > > start commit:   dc164f4fb00a Merge tag 'for-linus-6.0-rc7' of git://git.ke..
> > > git tree:       upstream
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=122d7bd4fc8e0ecb
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=b30ccad4684cce846cef
> > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1110db8c880000
> > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13e58aef080000
> > >
> > > If the result looks correct, please mark the issue as fixed by replying with:
> > >
> > > #syz fix: Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times
> > >
> > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> >
> >
> > Looks reasonable based on subsystem and the patch:
> >
> > #syz fix: Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times
>
> Looks like I did add a different link when fixing it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/commit/?id=448a496f760664d3e2e79466aa1787e6abc922b5
>
> Or perhaps they are duplicated?
>
> https://syzkaller.appspot.com/bug?id=da3246e2d33afdb92d66bc166a0934c5b146404a
> https://syzkaller.appspot.com/bug?extid=b30ccad4684cce846cef


Yes, most likely differently looking crashes, but the same root cause.
It happens.