Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76cd4547-a68d-9d52-1d87-8299e29406ff@gmail.com>
Date:   Wed, 9 Nov 2022 20:12:52 +0100
MIME-Version: 1.0
User-Agent: nano 6.4
From:   Swyter <swyterzone@gmail.com>
Subject: Re: [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle
To:     luiz.dentz@gmail.com
References: <CABBYNZKWc13qGDOyhPZ9wZcTaK+Wg0LUycsKX58w7wEjTaGS=A@mail.gmail.com>
Content-Language: en-US
Cc:     Jack <ostroffjh@users.sourceforge.net>,
        linux-bluetooth@vger.kernel.org,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Marcel Holtmann <marcel@holtmann.org>,
        Hans de Goede <hdegoede@redhat.com>, swyterzone@gmail.com
In-Reply-To: <CABBYNZKWc13qGDOyhPZ9wZcTaK+Wg0LUycsKX58w7wEjTaGS=A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

>> Correct hci_set_event_mask_page_2_sync() event mask
>> git bisect good 0feb8af0275d196a29e321bedc15319673923cb6
>> # bad: [1172c59f451f524a14bac5e7b047781883dfe441] Bluetooth: btusb:
>> Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA
>> git bisect bad 1172c59f451f524a14bac5e7b047781883dfe441
>> # bad: [766ae2422b4312a73510ebee9266bc23b466fbbb] Bluetooth: hci_sync:
>> Check LMP feature bit instead of quirk
>> git bisect bad 766ae2422b4312a73510ebee9266bc23b466fbbb
>> # first bad commit: [766ae2422b4312a73510ebee9266bc23b466fbbb]
>> Bluetooth: hci_sync: Check LMP feature bit instead of quirk
>>
>> And 766ae2422b4312a73510ebee9266bc23b466fbbb does make sense as a
>> likely culprit.
> 
> Looks like we will need to reintroduce the quirk then since it appears
> the LMP feature bit is probably set in those controllers but the
> command doesn't work.

It is. I already mentioned it in the Bugzilla thread and that's
what the patch series I submitted the other day fixes:

> Bluetooth: btusb: Fix Chinese CSR dongles again by re-adding ERR_DATA_REPORTING quirk
> https://patchwork.kernel.org/project/bluetooth/patch/20221029202454.25651-1-swyterzone@gmail.com/

Hans de Goede gave it a Reviewed-by, but it has been ignored even since.

Keep in mind that I'm an occasional contributor and I can barely use a mailing list,
but this goes back to the patch that Zijun Hu sent back in July and I was pinged.


I took a look back then, it looked suspect, but I imagined you guys knew what you were
doing. Fast-forward three months and the code arrives at most mainstream distros.

Every single cheap Bluetooth dongle on Earth broke again. Just like that.

https://bugzilla.kernel.org/show_bug.cgi?id=60824#c242

I just came across this thread archive by pure chance, this isn't very user friendly.
Please CC me if you talk about this, I'm not subscribed to any list.