Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 09 Nov 2022 14:40:51 -0500
From:   Jack <ostroffjh@users.sourceforge.net>
Subject: Re: [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle
To:     linux-bluetooth@vger.kernel.org
Cc:     Swyter <swyterzone@gmail.com>, luiz.dentz@gmail.com,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Marcel Holtmann <marcel@holtmann.org>,
        Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
In-Reply-To: <76cd4547-a68d-9d52-1d87-8299e29406ff@gmail.com>
Message-Id: <LWPL3AC7.RRTERTU2.B5FO44IX@4YQH7VT3.DY2DZPQX.S6LIZ6VV>
Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On 2022.11.09 14:12, Swyter wrote:
> >> Correct hci_set_event_mask_page_2_sync() event mask
> >> git bisect good 0feb8af0275d196a29e321bedc15319673923cb6
> >> # bad: [1172c59f451f524a14bac5e7b047781883dfe441] Bluetooth: btusb:
> >> Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA
> >> git bisect bad 1172c59f451f524a14bac5e7b047781883dfe441
> >> # bad: [766ae2422b4312a73510ebee9266bc23b466fbbb] Bluetooth:  
> hci_sync:
> >> Check LMP feature bit instead of quirk
> >> git bisect bad 766ae2422b4312a73510ebee9266bc23b466fbbb
> >> # first bad commit: [766ae2422b4312a73510ebee9266bc23b466fbbb]
> >> Bluetooth: hci_sync: Check LMP feature bit instead of quirk
> >>
> >> And 766ae2422b4312a73510ebee9266bc23b466fbbb does make sense as a
> >> likely culprit.
> >
> > Looks like we will need to reintroduce the quirk then since it  
> appears
> > the LMP feature bit is probably set in those controllers but the
> > command doesn't work.
> 
> It is. I already mentioned it in the Bugzilla thread and that's
> what the patch series I submitted the other day fixes:
> 
> > Bluetooth: btusb: Fix Chinese CSR dongles again by re-adding  
> ERR_DATA_REPORTING quirk
> >  
> https://patchwork.kernel.org/project/bluetooth/patch/20221029202454.25651-1-swyterzone@gmail.com/
> 
> Hans de Goede gave it a Reviewed-by, but it has been ignored even  
> since.
> 
> Keep in mind that I'm an occasional contributor and I can barely use  
> a mailing list,
> but this goes back to the patch that Zijun Hu sent back in July and I  
> was pinged.
> 
> 
> I took a look back then, it looked suspect, but I imagined you guys  
> knew what you were
> doing. Fast-forward three months and the code arrives at most  
> mainstream distros.
> 
> Every single cheap Bluetooth dongle on Earth broke again. Just like  
> that.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=60824#c242
> 
> I just came across this thread archive by pure chance, this isn't  
> very user friendly.
> Please CC me if you talk about this, I'm not subscribed to any list.
> 
In case it helps any, I have applied Swyter's patch referenced at  
comment #243 of the bug referenced above, and it does restore function  
to my particular dongle (Gentoo linux, with gentoo-sources kernel  
6.0.6.)  (I believe I provided the git bisect quoted at the top of this  
message.)

Jack