Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3274642rwb; Sat, 12 Nov 2022 02:35:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Ofd0cUqdK+noxTpLPjduNdN2/29eHTKnplB6mtLp+k+zVjV/94jTa0hNVsmyw5nbWbGMk X-Received: by 2002:a17:90a:1b4b:b0:213:bbb1:32d6 with SMTP id q69-20020a17090a1b4b00b00213bbb132d6mr5960691pjq.41.1668249320537; Sat, 12 Nov 2022 02:35:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668249320; cv=none; d=google.com; s=arc-20160816; b=bNynaNZ3X9OfoK6ro4jefGoihpR6B0ZVFMQ+AsYLY6VPiBD5AaV1xDKLCbMXqKmCWe SSUWqt1aOLywGU7ICSFSBevNdNQYVirw+miK1mMTLI8SAVSVCYPNWMdnIWvYb9ppji2v 47eTAJlvZ/RnlJyaG6mTHzpxrzuv4vNbbHcZVbylvVbgFXxQKli9uplv46vzkwR2LCl4 cnouwPCBA2++PdcH3IVwiDndNLjSkagUKg9yH33pBA2z6sfAFa/UlB7nNCfk0bXepDwv V08KfxoYZncSMWfyikgeEwcA3AI3AQnXJCe4Gs5hTYsCYzcBqhfHLacJyomfE5Ifs51m jFTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=Fte2rxiySVM+JOc1hNbK+MPRv06a8DHftjYoXjxIs70=; b=F9mr4hU9HfWCmH1ZohMBd1npMVqeKoeylaMHtfWFf/E/274KoxddAbWbd6FO7g7IqL fa4fiNUquyaX7Va+4Qtr0IAUHppEseMSG8/7Vxgd4kvJDna+0JpHmXb0c2HkPbVERGQe ZoOgPX+HcbVR7pqjn6CPi/lIvmO7+eOgN+tQyF1p8NLNr0TPS+Y4SyWyYeJx4phQfUoY CJ4mQwoIRMDqMZi3GqRpHBXu49FFa2+dB+SWzDw/Su5z73pMiE0rLSAJGbE82GxLNuSL tzUEPzLWoNFqS4vSjf1pdtEwAVukWwD+mxGOfetRwTs4uMQr+pyPHvFYbarE6ZE41wBg wr8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=jDuFzzWx; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=uFCZOany; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j70-20020a638b49000000b0046154b597cfsi5104349pge.565.2022.11.12.02.34.55; Sat, 12 Nov 2022 02:35:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@svenpeter.dev header.s=fm1 header.b=jDuFzzWx; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=uFCZOany; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=svenpeter.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbiKLK2f (ORCPT + 99 others); Sat, 12 Nov 2022 05:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbiKLK2e (ORCPT ); Sat, 12 Nov 2022 05:28:34 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 207582618 for ; Sat, 12 Nov 2022 02:28:33 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8AD735C00DF; Sat, 12 Nov 2022 05:28:32 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute2.internal (MEProxy); Sat, 12 Nov 2022 05:28:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1668248912; x=1668335312; bh=Ft e2rxiySVM+JOc1hNbK+MPRv06a8DHftjYoXjxIs70=; b=jDuFzzWx3qf1GKRNoW ML/6QjLodvYJYI74a+B0oTUobXL+YNdAhRApC3L2eHigTkxg3gKgXfZJuBCvQ7P9 6C0hzh21IPf6+lCKGuyFVVHdmT/2Npv1hXyTkUMUXcCSnx/Jbv1HhwShr5FMLTNU qUIr6jt50hz4XCBZqbB3oM9A51HQ/ZOYHnqFHYNcJu9c5YTde9OAWVZ5MM8cImcB 7/jjg0/66dDCp2ijmVc/XQehblcglh/Oa25U1t2Vysqf7KRBbJff5HBpP0iQjatL zbsdo41Bq6vYrPs109usHPnSvYjrMe7qZ/b75kYdOLIqPpGKqFgjsIF97glaqQII jvLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668248912; x=1668335312; bh=Fte2rxiySVM+JOc1hNbK+MPRv06a 8DHftjYoXjxIs70=; b=uFCZOany+NfPA5B9WykctUZCqLezFA6ocS5Lg/BEcpRu AEorQ0L0djWn6L3awhlKccsyB0I2IHsRimAWnMMtXvYP70coAHE6T6Vv19yd1DwO 6qvSnTcUP97v86/kljUpx3doYWHTyHYPscwAeEfrqckc+0IcLqYeeCEFJhCIQdeH jdfo4os6Mvj2rSNMVk5vfPWjN0OUPlnE6cuJPtJqSCSDUWu9IKhBRc5zjp/xS5ED EyWrLYSqrFbAvGaxyqSgMzVKF0YEqsSbt7qILIx4DWkNH9fozGNWZa60uhlpt+Zg TKT8VKLNoi0zkOMjrPb5JJ5F9QHLvGVOo9n5eLRFPg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeekgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpeelvefggeffheevtdeivefhkeehfeettdejteduveeiheevveeilefghfei veeiueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 760E9A6007C; Sat, 12 Nov 2022 05:28:32 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: <2d282d22-20be-4e27-b3ef-3048779f939b@app.fastmail.com> In-Reply-To: <20221112090437.3591380-1-yangyingliang@huawei.com> References: <20221112090437.3591380-1-yangyingliang@huawei.com> Date: Sat, 12 Nov 2022 11:28:10 +0100 From: "Sven Peter" To: "Yang Yingliang" , linux-bluetooth@vger.kernel.org Cc: luiz.von.dentz@intel.com Subject: Re: [PATCH -next] Bluetooth: hci_bcm4377: Fix missing pci_disable_device() on error in bcm4377_probe() Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi, On Sat, Nov 12, 2022, at 10:04, Yang Yingliang wrote: > pci_disable_device() need be called while module exiting, switch to use > pcim_enable(), pci_disable_device() will be called in pcim_release() > after probe() failure. > > Fixes: ab80b2cec05f ("Bluetooth: hci_bcm4377: Add new driver for > BCM4377 PCIe boards") > Signed-off-by: Yang Yingliang > --- Good catch, thanks! Reviewed-by: Sven Peter Best, Sven