Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220901110719.176944-1-hadess@hadess.net> <20220901110719.176944-6-hadess@hadess.net>
 <02bf340b-c908-6ee8-ca78-4203b965f3b5@dressler.it>
In-Reply-To: <02bf340b-c908-6ee8-ca78-4203b965f3b5@dressler.it>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 14 Nov 2022 15:35:42 -0800
Message-ID: <CABBYNZJgao0tRQwEw9a+LFRzaTX8AwRmAsj+C=XLhoxVTCDg6w@mail.gmail.com>
Subject: Re: [PATCH BlueZ v7 6/6] adapter: Remove experimental flag for PowerState
To:     =?UTF-8?Q?Jonas_Dre=C3=9Fler?= <jonas@dressler.it>
Cc:     Bastien Nocera <hadess@hadess.net>,
        linux-bluetooth@vger.kernel.org, luiz.von.dentz@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jonas,

On Sun, Nov 13, 2022 at 8:03 AM Jonas Dre=C3=9Fler <jonas@dressler.it> wrot=
e:
>
> Hi everyone,
>
> Can we please apply this one, too? The property being experimental means =
distros
> need to downstream patch BlueZ for the feature to work, I'm not sure all =
packagers
> are aware of that.

Well experimental can be enabled by passing -E to bluetoothd, so it
can be enabled at runtime, that said we might switch it to stable on
the next release.

> FWIW, I can confirm the feature in gnome-shell works after removing the f=
lag!
>
> Cheers,
> Jonas
>
> On 9/1/22 13:07, Bastien Nocera wrote:
> > Now that the feature has been tested, that the API is deemed adequate
> > and the reliability sufficient.
> > ---
> >   src/adapter.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/src/adapter.c b/src/adapter.c
> > index 8fb2acdc8..841096d7f 100644
> > --- a/src/adapter.c
> > +++ b/src/adapter.c
> > @@ -3864,8 +3864,7 @@ static const GDBusPropertyTable adapter_propertie=
s[] =3D {
> >       { "Alias", "s", property_get_alias, property_set_alias },
> >       { "Class", "u", property_get_class },
> >       { "Powered", "b", property_get_powered, property_set_powered },
> > -     { "PowerState", "s", property_get_power_state, NULL, NULL,
> > -                          G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > +     { "PowerState", "s", property_get_power_state },
> >       { "Discoverable", "b", property_get_discoverable,
> >                                       property_set_discoverable },
> >       { "DiscoverableTimeout", "u", property_get_discoverable_timeout,
>


--=20
Luiz Augusto von Dentz