Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8987bdd-8a8d-1491-c4c7-66e95f990148@gmail.com>
Date:   Tue, 15 Nov 2022 07:41:41 +0100
MIME-Version: 1.0
User-Agent: nano 6.4
Subject: Re: [Regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle
Content-Language: en-US
To:     Mika Laitio <lamikr@pilppa.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Jack <ostroffjh@users.sourceforge.net>,
        linux-bluetooth@vger.kernel.org,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Marcel Holtmann <marcel@holtmann.org>,
        Hans de Goede <hdegoede@redhat.com>
References: <76cd4547-a68d-9d52-1d87-8299e29406ff@gmail.com>
 <LWPL3AC7.RRTERTU2.B5FO44IX@4YQH7VT3.DY2DZPQX.S6LIZ6VV>
 <CABBYNZKDEjYOW+b1snUsvBgidW37+tPbsidq0pXaOqWKvRC8uQ@mail.gmail.com>
 <7ea187e5-7c70-db36-1fa8-148507b2e7c5@gmail.com>
 <e382d911-90bc-de3f-9f3-6143ed8a9b75@pilppa.org>
From:   Swyter <swyterzone@gmail.com>
In-Reply-To: <e382d911-90bc-de3f-9f3-6143ed8a9b75@pilppa.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

>> Thanks to this last-effort parameter we can cover that last mile
>> without people having to recompile custom versions of btusb.
>>
>> My dongle doesn't work? Easy, add this here. Most people won't
>> have to bother with this, but that final ~3% would be screwed.
> 
> So what is the parameter needed for now? Might help users coming to this 
> bug and finding this thread.

Hans explained it better than me.

The Linux people haven't merged this patch yet, but the idea is that in
case our generic workaround is a bit too much for a small bunch of dissident
devices and we are actually making it not work (we're making it worse!) when
it would work otherwise, adding «btusb.disable_fake_csr_forcesuspend_hack=1»
should neutralize any side effects, as that workaround wasn't needed
for your dongle in the first place. But we can't be sure of that.

I think we have received two or three reports of this actually helping.

It should be a thing you'd try and see what happens, this isn't an exact
science. Most people won't need it, we're just being thorough and nice.

Letting you skip our little shakeup. Easily.