Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221104071810.22720-1-kiran.k@intel.com>
In-Reply-To: <20221104071810.22720-1-kiran.k@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 16 Nov 2022 12:57:40 -0800
Message-ID: <CABBYNZJsL-pqbK95EOEQOvj=9sTr=aTZL527262eC64SDicGrg@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] bluetooth: Remove codec id field in vendor codec definition
To:     Kiran K <kiran.k@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com,
        Chethan T N <chethan.tumkur.narayan@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kiran, Chethan,

On Fri, Nov 4, 2022 at 12:18 AM Kiran K <kiran.k@intel.com> wrote:
>
> From: Chethan T N <chethan.tumkur.narayan@intel.com>
>
> As per the specfication vendor codec id is defined.
> BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 4, Part E page 2127

We need the fixes tag, the monitor also seems to be wrong in this
respect so I will push a fix for it once that is done please add its
output.

> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> ---
>  include/net/bluetooth/hci.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index e004ba04a9ae..581539cbb856 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1424,7 +1424,6 @@ struct hci_std_codecs_v2 {
>  } __packed;
>
>  struct hci_vnd_codec_v2 {
> -       __u8    id;
>         __le16  cid;
>         __le16  vid;
>         __u8    transport;
> --
> 2.17.1
>


-- 
Luiz Augusto von Dentz