Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122034246.24408-1-yuehaibing@huawei.com> <29fb52c0-155b-470e-10d5-5e3b2451272d@molgen.mpg.de>
In-Reply-To: <29fb52c0-155b-470e-10d5-5e3b2451272d@molgen.mpg.de>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Tue, 22 Nov 2022 10:06:01 +0100
Message-ID: <CAO-hwJKraiox13k=ukXOhSNt9sTc6Q0KpGR5=AHDknZeR6omwA@mail.gmail.com>
Subject: Re: [PATCH -next] Bluetooth: Fix Kconfig warning for BT_HIDP
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     YueHaibing <yuehaibing@huawei.com>, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        jkosina@suse.cz, gregkh@linuxfoundation.org,
        linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Tue, Nov 22, 2022 at 9:37 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear YueHaibing,
>
>
> Thank you for your patch.
>
>
> Am 22.11.22 um 04:42 schrieb YueHaibing:
>
> Maybe use the more specific summary below:
>
> Bluetooth: Add HID_SUPPORT dependency for BT_HIDP
>
> > commit 25621bcc8976 add HID_SUPPORT, and HID depends on it now.
>
> add*s*
>
> or
>
> Commit 25621bcc8976 ("HID: Kconfig: split HID support and hid-core
> compilation") introduces the new Kconfig symbol HID_SUPPORT =E2=80=A6
>
>
> Kind regards,
>
> Paul
>
>
> > Add HID_SUPPORT dependency for BT_HIDP to fix the warning:
> >
> > WARNING: unmet direct dependencies detected for HID
> >    Depends on [n]: HID_SUPPORT [=3Dn]
> >    Selected by [m]:
> >    - BT_HIDP [=3Dm] && NET [=3Dy] && BT_BREDR [=3Dy] && INPUT [=3Dm]
> >
> > Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core comp=
ilation")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---


FWIW, a fix is already in -next:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=3Dfor=
-6.2/hid-bpf&id=3D6cc90ccd4f6cfed98e2a3a378debc69f28d57473

 But thanks for the patch nonetheless!

Cheers,
Benjamin

>
> >   net/bluetooth/hidp/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
> > index 14100f341f33..6746be07e222 100644
> > --- a/net/bluetooth/hidp/Kconfig
> > +++ b/net/bluetooth/hidp/Kconfig
> > @@ -1,7 +1,7 @@
> >   # SPDX-License-Identifier: GPL-2.0-only
> >   config BT_HIDP
> >       tristate "HIDP protocol support"
> > -     depends on BT_BREDR && INPUT
> > +     depends on BT_BREDR && INPUT && HID_SUPPORT
> >       select HID
> >       help
> >         HIDP (Human Interface Device Protocol) is a transport layer
>