Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6105302rwb; Tue, 22 Nov 2022 08:50:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf7u4TxEZQTo+fpDnpX0YoLA1MbbzdHKJvrgMrje4Gm9k8e8/x6MVMkZWeL/dVkIBKFzmZxb X-Received: by 2002:a17:906:30c1:b0:7b7:eaa9:c1cb with SMTP id b1-20020a17090630c100b007b7eaa9c1cbmr5305117ejb.745.1669135848836; Tue, 22 Nov 2022 08:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669135848; cv=none; d=google.com; s=arc-20160816; b=QsmHCf1/hP3eJ4TRxkruylqA1SAlBuw9dSjofFrBVfXtNsZA7VK4o4K5bGr/6UaCDq rdSaUKWb1HlLRmRqUL7qOXpP1MCRHgscsD2F6mTp4REanY0YoK1pQDcC33bpJEhSqw3U NEZjfmyqC68jx0s2Z9Wxt2v25MVDHyYHP9aNJtZyVNmaF16zvoXNzEJzZl1g4BjEFpPV KgNJTRsIodx7feWqZ87WGgLGRGCVxxrQ4WKFVn2s+0nKb0yZ5jYBf/VfM+pz3ZIe1jnJ SsAHwVWDB/54c7yyYCUAcnEKLzqBwjyOcqaZFjWFVh7ZF4sHVoAG1Mdr9B2L9rqrA8/P tPFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=R1WhU15sqpsop/ukaaUc7gI5zuOdhbblJAEG6t8OCMQ=; b=gaDrSB2zrvNWqSTqsjP1o0ggS/s1w7BJTvQhr9H7O1t+g6iGOvBmHdeZGsK5CJAxgS 5L23KutcRVCLoOvaSQI0Aoum7ZsGp/pdhEhyefJl/y15HOsTZ2kKSHXGhtk8FKRlQsyi ZcUqeJx5PnnE1wrC2CAwzn1pXpKBPEeriqinicRoSA82/dH7xJ+g5XtgaEHhvGIiW/vK KkmmOFGWeqDcijGuwXE7xqpAFj3DtrYtT6DXcVD+Du7egdOx11x2Mnbkvb4kg4lZMIMc vsgDuC9FxxMvXWTPoaFXoNLTXjeepx92h2i6KvOc0Ex/9/9aptnbrMjzDFn7R7PfSahM hVrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=y6naOLGF; dkim=neutral (no key) header.i=@linutronix.de header.b=VNftf6BM; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js7-20020a17090797c700b007ae75e99fffsi12963142ejc.487.2022.11.22.08.49.45; Tue, 22 Nov 2022 08:50:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=y6naOLGF; dkim=neutral (no key) header.i=@linutronix.de header.b=VNftf6BM; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233754AbiKVQm6 (ORCPT + 99 others); Tue, 22 Nov 2022 11:42:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233976AbiKVQm4 (ORCPT ); Tue, 22 Nov 2022 11:42:56 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 682821C90E; Tue, 22 Nov 2022 08:42:52 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669135370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R1WhU15sqpsop/ukaaUc7gI5zuOdhbblJAEG6t8OCMQ=; b=y6naOLGFvz9Sl3hNhfg5l9yNrEiEy+p4FonO2MrfG9k7XMR08lGTOsywj43cUtfU0LnE3C 1z/dlfqsTuwhJDUYV5Q+J/KdvjrK6UPj7tDDVmMFWFSn9y6ZhtMbMaAT3fD3UYtxbGEzcN HVk2ZFRG41+JrBHQEVWn1bPZgn85dwcK/Q/rEdmreRuaBFdUZZmHOZltTc7E3WscOdNfp8 AECFNaB0pRofNbCIP5kg6Uyjkr9KjBN5oJRwW83/kpQt+3Y3SbMz5R+6Nrlhh/q/8TiZnQ kC6BG2KxPeHrNPWoSN6Rq4pRpA6R/DKRUDhRwuGjBVzzQ6E3LBs/n5Xmh9NH7w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669135370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R1WhU15sqpsop/ukaaUc7gI5zuOdhbblJAEG6t8OCMQ=; b=VNftf6BMJ9EYZyF531LLRIvUW59W4X9URD41xna7lxGvN+xS73oK0xrfl8mQUKKEY5TluR IkFKYFgJhDIv84CQ== To: Steven Rostedt Cc: LKML , Linus Torvalds , Anna-Maria Behnsen , Peter Zijlstra , Stephen Boyd , Guenter Roeck , Andrew Morton , Julia Lawall , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Jonathan Corbet Subject: Re: [patch 06/15] timers: Update kernel-doc for various functions In-Reply-To: <20221122104124.2f04c7be@gandalf.local.home> References: <20221115195802.415956561@linutronix.de> <20221115202117.323694948@linutronix.de> <20221121154358.36856ca6@gandalf.local.home> <878rk3ggqa.ffs@tglx> <20221122104124.2f04c7be@gandalf.local.home> Date: Tue, 22 Nov 2022 17:42:49 +0100 Message-ID: <8735abgcty.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Tue, Nov 22 2022 at 10:41, Steven Rostedt wrote: > On Tue, 22 Nov 2022 16:18:37 +0100 > Thomas Gleixner wrote: > >> >> + * This function cannot guarantee that the timer cannot be rearmed right >> >> + * after dropping the base lock. That needs to be prevented by the calling >> >> + * code if necessary. >> > > > Also, re-reading it again, I wounder if we can avoid the double use of > "cannot", in "cannot guarantee that the timer cannot". > > What about: > > This function does not prevent the timer from being rearmed right after > dropping the base lock. Funny enough I noticed myself when I copied this sentence into the code and did exactly the same change :)