Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122101232.45320-1-sathish.narasimman@intel.com> <20221122101232.45320-2-sathish.narasimman@intel.com>
In-Reply-To: <20221122101232.45320-2-sathish.narasimman@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 22 Nov 2022 12:03:37 -0800
Message-ID: <CABBYNZJ3jKn6aqP1Lq5izk21fB4mwaphEgsAXcnPAFybfBexbw@mail.gmail.com>
Subject: Re: [PATCH BlueZ v3 1/7] shared/util: Update UUID database for Csip services
To:     Sathish Narasimman <sathish.narasimman@intel.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sathish,

On Tue, Nov 22, 2022 at 2:16 AM Sathish Narasimman
<sathish.narasimman@intel.com> wrote:
>
> This updates UUID database with the values from assigned numbers for
> co-ordinated set identification services.
> ---
>  src/shared/util.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/shared/util.c b/src/shared/util.c
> index 333023e0dcac..d7fbd2322f7b 100644
> --- a/src/shared/util.c
> +++ b/src/shared/util.c
> @@ -695,6 +695,9 @@ static const struct {
>         { 0x2b82, "Volume Offset Control Point"                 },
>         { 0x2b83, "Audio Output Description"                    },
>         { 0x2b84, "Set Identity Resolving Key"                  },
> +       { 0x2b85, "Csis Size"                                   },
> +       { 0x2b86, "Csis Lock"                                   },
> +       { 0x2b87, "Csis Rank"                                   },

Use the actual attribute name rather than its services e.g:
Coordinated Set Size, etc.

>         { 0x2b93, "Media Player Name"                           },
>         { 0x2b94, "Media Player Icon Object ID"                 },
>         { 0x2b95, "Media Player Icon URL"                       },
> --
> 2.25.1
>


-- 
Luiz Augusto von Dentz