Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fc6c11e4-d038-1277-289a-ee51a839fc88@intel.com>
Date:   Wed, 23 Nov 2022 10:45:41 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [patch V2 13/17] timers: Split [try_to_]del_timer[_sync]() to
 prepare for shutdown mode
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     Linus Torvalds <torvalds@linuxfoundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Anna-Maria Behnsen <anna-maria@linutronix.de>,
        "Peter Zijlstra" <peterz@infradead.org>,
        Stephen Boyd <sboyd@kernel.org>,
        "Guenter Roeck" <linux@roeck-us.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Julia Lawall" <Julia.Lawall@inria.fr>,
        Arnd Bergmann <arnd@arndb.de>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
        <linux-bluetooth@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>
References: <20221122171312.191765396@linutronix.de>
 <20221122173648.849454220@linutronix.de>
 <74922e6d-73d5-62cc-3679-96ea447a1cb4@intel.com> <87k03leh47.ffs@tglx>
Content-Language: en-US
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <87k03leh47.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TE1IWEQwWGViU2dvaktFRlBsT2NJSTdQVEVFTldsNnhHaVlubk9ZZU5QTEdx?=
 =?utf-8?B?a0p2UFkxMjl2NktoNkMwaVExR09JejExRDBmNFdudktsOFIvTlI1TnlaMnJs?=
 =?utf-8?B?WmRKWDVtN2RzSEhwQ3BJcHZNZHMxMnpKR1V2azFQN05SekVzUCtiM0grNjlZ?=
 =?utf-8?B?eWtwZHViTnFoQU52RmY4M003RUo5bmF3eGcyU3FNeFlHUGozUDhYKzdyT3My?=
 =?utf-8?B?eE80ZHpGRlUvSnByOG05anIxL2Z0Yk5LVTR4RGYzcVZKTVNtUk5aRWdoRGFv?=
 =?utf-8?B?VUN6UEhESWVaTm9uQ0IyeTFzcHN4Q1lRaCs2dEZobTVEZmlnTUhmWnBkaXhk?=
 =?utf-8?B?VzlLeWlndDBUV2w1QWkvcXNNK3p5NEVackxHZE1Wd3piZW5uNzZEWWh2aloy?=
 =?utf-8?B?OHpVWlNwNGRySzg5a2F3M2dTS3pOQkcwbWV1MUUyZGFTY3N2ZENRbjhUREYx?=
 =?utf-8?B?WVg3SjJreDNGa05SRndOOGR0dmVZekp0VHFqU25ZdFVDczJFejArUjZyYWFn?=
 =?utf-8?B?YWgrU3FJN1ZpY1haZDNlWXFGSlBzN0RPcnpjb1BvRHg3RFUyK0srbXpYenRh?=
 =?utf-8?B?TGpoMHpKeHprRmRITXVpS0ZEYVhQeEJRcUdTVXdrQlhwSStTQUtQNkFNcGRp?=
 =?utf-8?B?Z3AvM3Y1WXNUKzdOVUVia0s0YUxiK095RWNvUVJtaGlmdUp0MWVSUlZTN21r?=
 =?utf-8?B?RUREMnY2cEdibC80Um9OZDZsNXAwUE1HNVhXK0dvTEVOM01VVVpCeG1BNk9h?=
 =?utf-8?B?Ym1Da1NCd05jN0RFYmxvS2pZVEFwTWhUaERjUWtLeWhtQnBrUXZMOWFzMXNY?=
 =?utf-8?B?RlBvVVN6R1hIZFBNS0FzVDdKWFFQUlFBUllrSS9nTEN4SlFQQ0V6N2R2UnhL?=
 =?utf-8?B?aTlQNFJNM1VHYjJ3Y2tMOTlHNFhNaFNhVXEwQ3JsV0puaFVWbG1DTFJzZ1VT?=
 =?utf-8?B?QjNDYVBpRlg1bUQrVHFENmNMbDJJMW5zcXQwWXVqYVVpd1I3L2tSb1Y4bzNq?=
 =?utf-8?B?akI5VWdoWkdRNzR3TFBrTHczOW1uSWE1WVNkczdYUkFZOEtjcTJmR0llK1U4?=
 =?utf-8?B?dXdaMEwrakpTN25zNkxsMkRKbkdjcTFIa25VeVhaVEJCQW5rc1lTVERWU0pK?=
 =?utf-8?B?ODBUMnIyanh3NWNTM3d5UTN4VWlCUGpXRjdqTTBrYmJXVzZ5TUcycmdJZGtD?=
 =?utf-8?B?b21CaWpaQlZSTmpsSVVZUzZNZmZQYlRJaElDMkxPMDZLTUtnS3U2SFpCUEl1?=
 =?utf-8?B?SVg3NUJHRWJkdzZXTXI5bHVMaE9Zekw3TmdYYUhuQWVOMDZhNmxoZG4vZmFp?=
 =?utf-8?B?UTJGWkN5cXFoaDRjaEhaeC9ORkhMbzl3Qm54dHlHWnhkRkhDdkI0Ky8yck9B?=
 =?utf-8?B?eE9odnc5YlFaeTl3ZTd3ZFJ5ZEoxZmV1TTV6ZlBvZ0R3Rlk5a0Q0NnJ6Mlgw?=
 =?utf-8?B?clFUK2tLekFGYW5yQXFvRGljQ1F5VHlZNmFvTkNPUlJpdEgrbzhtbTA0UXpM?=
 =?utf-8?B?Zm1kQWM0SVpXSUE5a1ZtMXNGMUNwOUlzTFllNDhrWWhQWmJ4ZzF6Y3BWcXpp?=
 =?utf-8?B?bkFYVHNlb0c5WWxvc0VCMXlIZk5Id0lsbHl3OHljYTZGUUVoQmxKRW00TWtM?=
 =?utf-8?B?RWg2SnVOanM2bjBPVkpmbC9qamRKaVFaVWZnaXBiRE05V0JSUFpNMEltakMx?=
 =?utf-8?B?QTlNcG13QXg3ZG8zNEE0YTJVTGFMWW56bkJMWmUwU2NXZFJ1SzV5cDA2RXJC?=
 =?utf-8?B?N2RyWXJjQzR6OXZYa1ZPdTU3TkZlZ3VNZUNyNkZsclo3K1ZUT1hXbzRPZFUv?=
 =?utf-8?B?bHVFd3p3MnJFaGZPMjdEQ2FHQmVkaFhtakcrSHFwY2toZUVjL21GY0drcHNh?=
 =?utf-8?B?Ym1GOExCYmYyMWtoZVllUjYyUHFSYXhLRk1mOVlQQ0YyU2R6eUZWTlRnQWJJ?=
 =?utf-8?B?SC9RdUNQdzh2RFNOWW5mYWxGdzNSMUZlUWlDV21LK2ZmYkNYdEg1OWUySlpN?=
 =?utf-8?B?T2dHQithUllTOEpUOHF6ZXFLNVNndTE3dUlMd0taaUlIZmxFMitYLzFLWWdQ?=
 =?utf-8?B?MGlNUGRSNG12MXpmeFhxUVRKTWl5S213ZlVqdmY0Qk5iMnVrei96RkJqY3hi?=
 =?utf-8?B?alFGNDcxdnBXUFhxdDJDNXBoWmtSTzZQVVpoUmNDbUZ3ZkR4UFpvQUNUd3Zi?=
 =?utf-8?B?c1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9fb955e-2f63-4abb-40d8-08dacd82ed30
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 18:45:43.6557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4diqhoWfCAq44whnkTcbMD5SoKWPy55KXS4JYfzpgNURhMtupbYis65dadgnpiBJGSuXmYTCnh9hy/WHnZIVSiE3nQLIEd+brGe2cNAzu+M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4726
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org


On 11/23/2022 9:05 AM, Thomas Gleixner wrote:
> On Tue, Nov 22 2022 at 15:04, Jacob Keller wrote:
>> On 11/22/2022 9:45 AM, Thomas Gleixner wrote:
>>> +int try_to_del_timer_sync(struct timer_list *timer)
>>> +{
>>> +	return __try_to_del_timer_sync(timer);
>>> +}
>>>    EXPORT_SYMBOL(try_to_del_timer_sync);
>>>    
>>
>>
>> Its a bit odd to me that some patches refactor and replace functions
>> with new variants all under timer_* namespace, but then we've left some
>> of them available without that.
>>
>> Any reasoning behind this? I guess "try_*" is pretty clear and unlikely
>> to get stolen by other code..?
> 
> Kinda. I renamed del_timer*() because that's the ones which we want to
> substitute with timer_shutdown*() where possible and reasonable.
> 
> A larger timer namespace cleanup is subject to a follow up series.
> 
> Thanks,
> 
>          tglx

Yep thats what I figured once I got to the end of the series. Thanks!

Regards,
Jake