Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] Bluetooth: Fix not cleanup led when bt_init fails
From:   patchwork-bot+bluetooth@kernel.org
Message-Id: <167001634035.19139.3332943937893587311.git-patchwork-notify@kernel.org>
Date:   Fri, 02 Dec 2022 21:25:40 +0000
References: <20221129092556.116222-1-chenzhongjin@huawei.com>
In-Reply-To: <20221129092556.116222-1-chenzhongjin@huawei.com>
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Precedence: bulk

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 29 Nov 2022 17:25:56 +0800 you wrote:
> bt_init() calls bt_leds_init() to register led, but if it fails later,
> bt_leds_cleanup() is not called to unregister it.
> 
> This can cause panic if the argument "bluetooth-power" in text is freed
> and then another led_trigger_register() tries to access it:
> 
> BUG: unable to handle page fault for address: ffffffffc06d3bc0
> RIP: 0010:strcmp+0xc/0x30
>   Call Trace:
>     <TASK>
>     led_trigger_register+0x10d/0x4f0
>     led_trigger_register_simple+0x7d/0x100
>     bt_init+0x39/0xf7 [bluetooth]
>     do_one_initcall+0xd0/0x4e0
> 
> [...]

Here is the summary with links:
  - Bluetooth: Fix not cleanup led when bt_init fails
    https://git.kernel.org/bluetooth/bluetooth-next/c/63d70ae785a9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html