Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7804076rwb; Tue, 6 Dec 2022 10:03:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf5mdBDYlHIfitzO+BfEMgLh+cNVrAqnOP37aWBlk5nPFMmb1JRTjgqmbS8YrrwO3M1yQRoe X-Received: by 2002:aa7:820a:0:b0:574:a642:ad40 with SMTP id k10-20020aa7820a000000b00574a642ad40mr56859839pfi.42.1670349817104; Tue, 06 Dec 2022 10:03:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670349817; cv=none; d=google.com; s=arc-20160816; b=V4jCU9QQIBWbaw++KximdCwrijatXiQyN89wiu607u3ZEJ8ZYr56NAzbk2kajQmMoq JEe4T6n/6lmN1FZQ7zOYaYxkt4CwSpifiacg/9nVkc05jdfObs4bF5sCp4iT+hNSMcGe RmSni/TfZtuEI/2CZ2RTJy0HICYngchWcc8sj+YZC5c0NP7eU7Zgp9diAHF8PUZQ+59Z z+Wgr6kkkDm2QSLY/0DbvjHlmqj3axEMpNyzHxz+MGhQ49phcOOBqG9QJGoPiCApOUED bHbiay+s9WKXzlPrj6J8ZiA8mdXlnazpHfooW/ASj8JE3fRx9+Terf3wH2sP5f4RSCFR JjGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=9e7rLWgrKFM5ay1j56f9/T4SCilwyXBGMzWJwRb9TWI=; b=Oc7WZpVEerXuPqK5Jhr6NZQWBoOUFNc6I2hRr/fNIudhPLrF1nr6u6U3J5X50dfoaA 0R3RHuRoWGkvm0zsp0bSRKCdL3hSWAf7+eL2Htw3lzSNtFky33v18oFo8mAeDxszds6z ZU9WMCg+s6qhqaj7PNhQy4CY54JDiKWAi+mJC635k2W6JgB1ZBRV2YiTw9d5w2vTySvY 8DsxEKkmUS1w1DZ2rLaiGH9V8BVTuHRgJSNUI+MonGxeo0gPWUDxUocSr9iWjFcEA5Ws ++WfP1E6uEVdYBQhFDe7f7y3XxSC8TECsu4sT9mwZmv0yhxROuHkj7jH12CrL7hgrJGl kmnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b="nL/uGD9f"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 143-20020a630195000000b004786b75fb89si16993874pgb.846.2022.12.06.10.03.18; Tue, 06 Dec 2022 10:03:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b="nL/uGD9f"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229560AbiLFRuW (ORCPT + 99 others); Tue, 6 Dec 2022 12:50:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbiLFRuU (ORCPT ); Tue, 6 Dec 2022 12:50:20 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BFC2228D; Tue, 6 Dec 2022 09:50:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA715B81B00; Tue, 6 Dec 2022 17:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 56067C433B5; Tue, 6 Dec 2022 17:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670349017; bh=vnrsEcjZq5+7qt/t33vzTsH4giZIyJwRDMHO+qQlWgI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=nL/uGD9fqjH7/Lu+/zTKv5k9RoepNYWFXbT84eke+koxQADZz/6lS2eic7fUDSZJL sjtvqsNT/PEduUvdZYdhpsXuTw+G57B/Pb7FttXhv+h8yXcb2J5TaFkkgp0eVk9Vqj I9+bjrTzxXo/Vljxz3Qz744pv+zqtB+WFExX3RQwANRh/0vPOUoKvyZdeyizMToc7E 5eztA9eNbu5e6tzfTNFiVwPcqwUEJ2DXmg/gMZsqLQTsUhFaSbY/7mkbBvjbkiQdcS Y0lIf7M07uVf4kWAt4BTaX5vYpFYej62PgZJijsu1Bgrqcuqvzp14oEjp8qEbnwbjQ UlQfevhmW7SHA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3CCC0E56AA2; Tue, 6 Dec 2022 17:50:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Bluetooth: btintel: Fix missing free skb in btintel_setup_combined() From: patchwork-bot+bluetooth@kernel.org Message-Id: <167034901724.25798.17751229965672179058.git-patchwork-notify@kernel.org> Date: Tue, 06 Dec 2022 17:50:17 +0000 References: <20221205135357.3961836-1-bobo.shaobowang@huawei.com> In-Reply-To: <20221205135357.3961836-1-bobo.shaobowang@huawei.com> To: Wang ShaoBo Cc: liwei391@huawei.com, marcel@holtmann.org, luiz.dentz@gmail.com, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Mon, 5 Dec 2022 21:53:57 +0800 you wrote: > skb allocated by __hci_cmd_sync would not be used whether in checking > for supported iBT hardware variants or after, we should free it in all > error branches, this patch makes the case read version failed or default > error case free skb before return. > > Fixes: c86c7285bb08 ("Bluetooth: btintel: Fix the legacy bootloader returns tlv based version") > Fixes: 019a1caa7fd2 ("Bluetooth: btintel: Refactoring setup routine for bootloader devices") > Signed-off-by: Wang ShaoBo > > [...] Here is the summary with links: - Bluetooth: btintel: Fix missing free skb in btintel_setup_combined() https://git.kernel.org/bluetooth/bluetooth-next/c/6ae5399836fa You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html