Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3148962rwj; Mon, 19 Dec 2022 13:55:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf7FRYdVhONwMJcct2BkgYZR0McSrXIZ94DkziH4LbPbtKzhpw/mVWUO7cT7FRi3YjQigOqw X-Received: by 2002:a05:6402:299b:b0:468:fd17:aeb9 with SMTP id eq27-20020a056402299b00b00468fd17aeb9mr34803598edb.0.1671486920826; Mon, 19 Dec 2022 13:55:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671486920; cv=none; d=google.com; s=arc-20160816; b=Ky/IY/xumoKLAgbBI9ZrWVWbKcwTcZtNx9zEkugLmRxSVkQENUlBS3SxyFVtDQ9Zoa 2rUlpqhb4/nM+0+khQOFA+ZKvJP/oY2xPTDaOWdRXAKvFtr9K6apMtRw/rNKlepsJFKJ ne8fibxuVWk7kBv+wCtq1B/j6RPvXPljbXsAbCkOwjHZsX2TFesPvG05XO8IoqmxWGyQ V7GFGWb2Ipr9Axn6mK3twqgZe0WCyU5Wzy33tY7xavbvIflT6mhPkKFm5yH2QUmlyteN 6fNMOc2AZ516nhLyGdx4pfdS126pXwMEGsPHywQPnz9KrNK8Yr4lYQGI7qebsfmHaXsA Qjrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=ZEltcE3viY/1MzRx9xhY4XBdSv7mmCkv7JqRLAPFemE=; b=tljxRGcT62EywedOXTVVLFY5HhP2+mtTPuh150GAP1COoWZ1x8e2LJA23iLPJ6nSyR bK5p5rMkFXrBcyDHH5cwjxPdpxRtI7JxycEljjCQmSqNHA4BzT8YJpvLhgFcV3+v1qAG NFZiqvoKVy/F/N96q2HMJnq4OpQcAbJiYt1psft2fLfF1c4X6PUyO+AnryGHGlU8bzGS as6p4Xkfmdf9jmjYXYCtWYeh4CcYBPQB55tsz7Ub/QXJzEvfVzwMw/KqQrqPx0w0SwQj zgWie+Bcwg4JcjSdYDtXgFSIP9GFdDBwp6ABLz5cm7AXeJh7jKOj2wIUy7iBQ3LgPP3c lfWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="la+kXW/2"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he43-20020a1709073dab00b007ae832c0b69si14754ejc.512.2022.12.19.13.54.55; Mon, 19 Dec 2022 13:55:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="la+kXW/2"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbiLSVhv (ORCPT + 99 others); Mon, 19 Dec 2022 16:37:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232328AbiLSVhu (ORCPT ); Mon, 19 Dec 2022 16:37:50 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD5F1F580 for ; Mon, 19 Dec 2022 13:37:49 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so10147918pjd.5 for ; Mon, 19 Dec 2022 13:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZEltcE3viY/1MzRx9xhY4XBdSv7mmCkv7JqRLAPFemE=; b=la+kXW/2wrStRmyU0WEdP3Xe8MsxuOws5yEGSJp7llA9oqU8WPAhNKvqwlqMVJ16cv V5u0F189lv4I7qCM/hviDekaZio8/VbYTsnccAfDMvTZPgYMgUC4Q4f1ozJYcnlAH0h4 hC+NiSHGMhd8XKJFhuxnN4LbhbQhYwO30/44yG/cvAkmm5uOrBvS22SLZagIghNvUa0x c6/pIKg0oTJQVObIBbR3+OqXzuc+NS9+K21FQount0021ICAuvQh0Z8qDRTk7wA8b2db S8ELw/2zDK/JPJ3toLY6QmlI8VOLkSvnWExOol/WIL81NPfOtY5T001e/2gXTTNlSM12 33Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZEltcE3viY/1MzRx9xhY4XBdSv7mmCkv7JqRLAPFemE=; b=ORE9S7AHVztsZQZ5ySuIfrXlam5/pElIUIQY9LCLuTChBYX+UW7Z0EomCOLfF3R4aO nG0jqgaQglS8LYyaw+3iV1stNi84MzQeoEEWDhcPADxXu9lVdeqBl/nySr25inhDFyGJ cDdL5Hi7OsncAtbJP/r+HOb3MQtqQFXBdpZ+dPR6jRAmWxp6G/boBfz9QVxz51WStUiz 1KiPwiwhFLVyT0CwzFn8ytKs5GKMiXQ/+1PjqLXdYP6GLzykwD0Wdk30klF6R1l8K1KN YiZuFV7nmrYuBBfc8dyPeevoQeOcuBM2qNsOhoXvX05yrlbiAkXMkraVMZt4bhSinkZM eK6g== X-Gm-Message-State: AFqh2kpqJPJXjaFxubA4CeJgOCsLr3jZbJpUpGzO5DfVqdyjUuL2btg7 +we/4NUyBu3oNKn0ARTLKtGneolnxEp3RA== X-Received: by 2002:a17:902:c153:b0:189:f390:a227 with SMTP id 19-20020a170902c15300b00189f390a227mr10601429plj.56.1671485868903; Mon, 19 Dec 2022 13:37:48 -0800 (PST) Received: from lvondent-mobl4.. (c-71-56-157-77.hsd1.or.comcast.net. [71.56.157.77]) by smtp.gmail.com with ESMTPSA id b18-20020a170902d51200b0017c37a5a2fdsm7642762plg.216.2022.12.19.13.37.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 13:37:48 -0800 (PST) From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH] Bluetooth: hci_sync: Fix use HCI_OP_LE_READ_BUFFER_SIZE_V2 Date: Mon, 19 Dec 2022 13:37:47 -0800 Message-Id: <20221219213747.3659867-1-luiz.dentz@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Luiz Augusto von Dentz Don't try to use HCI_OP_LE_READ_BUFFER_SIZE_V2 if controller don't support ISO channels. Link: https://bugzilla.kernel.org/show_bug.cgi?id=216817 Fixes: c1631dbc00c1 ("Bluetooth: hci_sync: Fix hci_read_buffer_size_sync") Signed-off-by: Luiz Augusto von Dentz --- net/bluetooth/hci_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 5220bfd75b00..b3676b899647 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -3572,7 +3572,7 @@ static const struct hci_init_stage hci_init2[] = { static int hci_le_read_buffer_size_sync(struct hci_dev *hdev) { /* Use Read LE Buffer Size V2 if supported */ - if (hdev->commands[41] & 0x20) + if (iso_capable(hdev) && hdev->commands[41] & 0x20) return __hci_cmd_sync_status(hdev, HCI_OP_LE_READ_BUFFER_SIZE_V2, 0, NULL, HCI_CMD_TIMEOUT); -- 2.37.3