Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp6745348rwj; Wed, 21 Dec 2022 21:11:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvX870zHghxa+OxGG26+ZChYov6sKF0/S98eXQ+g6VgsaRLbXfcKvU/JJyyLOFvOLll9JvE X-Received: by 2002:a17:906:1c4e:b0:7c1:49e:6e3b with SMTP id l14-20020a1709061c4e00b007c1049e6e3bmr3453716ejg.68.1671685907307; Wed, 21 Dec 2022 21:11:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671685907; cv=none; d=google.com; s=arc-20160816; b=Hut/lTXAfE37evqM48jCBdnMPs8CRkDLTkyP06I3F4ElCFwESN+y/JuhEP55I2jZ4k pV1JYxUzRCVjbk8ZpwGyBNesdAUBvOLxwMPcszRfnlA5jkpJpthH8rPfunKt0hpjB0p7 /XuOvzeVxSV2Pj0I+JFjTz9Jd9ftCIISbwbaXZEDhIeH22zQbZz/dGUL6I0OkT3h8/vi iqV3rTNha6uasAsS68TWcWF72EHO3qim1QvhDNaVzkT+1kHuZIiEI5GjOyGErh2pgaNg Kmpf5tJ7pyvJcmtejbfm1I2yIjlweejRA8h7NFIqHPdq9MMWQTxVf6Rxmk2Go6fS8D+7 gcTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:dkim-signature :from; bh=eH8M6w85+NLMp8m3weXqG66NWkeE3K2qLdjTpJMXR40=; b=qcvcZGhuCQA32ZSBGqWREey/6X6KMnDJyZlJj3Vxm+x1aDLd+dHQmNO/JRSb6IE36f XsH7RJzTySohaqUPg4QjPXfFaE82BjPblBT2Qajn48KsM6DY+XF7KZIZKplXxdfY0xpi Pq6VRY2NSBOZIYEDZ/4qcDjtRRZl3i7Ber/Egar6C8/849WtOYZlZL+FQQmmbOrB3o0v +uExz443WdjORLOrkK2RxIDC7Pg6K/U9pNKyNUpUNqvBOA0CDYm7JvGJAf5jO52GoFcc NTltIOVNadQi3/8S8DW7xgMPmelqpVZqkyyazCgrUTQLdDIs90OHyogXkvPsUJbqolWm u95A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=dkHGyX+F; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv15-20020a17090760cf00b007c1727f7c57si16395361ejc.243.2022.12.21.21.11.13; Wed, 21 Dec 2022 21:11:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=dkHGyX+F; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234894AbiLVFK4 (ORCPT + 99 others); Thu, 22 Dec 2022 00:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbiLVFKw (ORCPT ); Thu, 22 Dec 2022 00:10:52 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12ACD1705E; Wed, 21 Dec 2022 21:10:50 -0800 (PST) From: Thomas =?utf-8?q?Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1671685847; bh=+TwYUhNEMciEbKy4LBuWCzsBr/FmeYPjRzvFbPwU3T0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dkHGyX+F319hDFe8JREAbJkgVdPhAr4CDz63BQACf6YbFBNMSaW7heWcM4okGjKAG OBKf9L99sesfe+Ip0v+vT3Q8tzrBjLPSxIYbFSG8JJVBMuF53J+cPWhdZ5zp82kOSl LZ3pBptvCET0wdj8JRs4FopuKnYTOapc1polxjus= Date: Thu, 22 Dec 2022 05:10:44 +0000 Subject: [PATCH 1/8] HID: letsketch: Use hid_is_usb() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-Id: <20221222-hid-v1-1-f4a6c35487a5@weissschuh.net> References: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> In-Reply-To: <20221222-hid-v1-0-f4a6c35487a5@weissschuh.net> To: Hans de Goede , Jiri Kosina , Benjamin Tissoires , David Rheinsberg , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Thomas =?utf-8?q?Wei=C3=9Fschuh?= X-Mailer: b4 0.11.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1671685844; l=678; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=+TwYUhNEMciEbKy4LBuWCzsBr/FmeYPjRzvFbPwU3T0=; b=ez9SDwFeWSSaEcM4FNhQ2nLrcWuyDgqqhikUkJqh92wXbyM7rYsccOS2kygfF76KfaUeMS6jE1Iz ZglXQ5nOBeq8iiv0o2fqnHwdmsPPpSmbESbRSY99mMGlo0AQyMBT X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Don't open code existing functionality. Signed-off-by: Thomas Weißschuh --- drivers/hid/hid-letsketch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-letsketch.c b/drivers/hid/hid-letsketch.c index 74d17cf518ba..97f047f18136 100644 --- a/drivers/hid/hid-letsketch.c +++ b/drivers/hid/hid-letsketch.c @@ -238,7 +238,7 @@ static int letsketch_probe(struct hid_device *hdev, const struct hid_device_id * char buf[256]; int i, ret; - if (!hid_is_using_ll_driver(hdev, &usb_hid_driver)) + if (!hid_is_usb(hdev)) return -ENODEV; intf = to_usb_interface(hdev->dev.parent); -- 2.39.0