Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221229155257.341327-1-abhay.maheshbhai.maheta@intel.com> <20221229155257.341327-5-abhay.maheshbhai.maheta@intel.com>
In-Reply-To: <20221229155257.341327-5-abhay.maheshbhai.maheta@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 3 Jan 2023 16:26:11 -0800
Message-ID: <CABBYNZ+Ny-0a2xkRp=-ND_kLHGNu6bKrpsSYBb4Ba5SGbgvvYA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v3 4/6] media-api: Add CompanyID, VendorCodecID, Metadata
To:     Abhay Maheta <abhay.maheshbhai.maheta@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, Abhay Maheta <mabhay125@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Abhay,

On Thu, Dec 29, 2022 at 7:58 AM Abhay Maheta
<abhay.maheshbhai.maheta@intel.com> wrote:
>
> This adds CompanyID, VendorCodecID, Metadata for RegisterEndpoint method
> ---
>  doc/media-api.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index 847f8bee7..7bfa8a52b 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -34,11 +34,29 @@ Methods             void RegisterEndpoint(object endpoint, dict properties)
>                                         match the profile specification which
>                                         is indicated by the UUID.
>
> +                               uint16_t CompanyID [BAP only]:
> +
> +                                       Assigned number of Company ID that the
> +                                       endpoint implements. It should be set to
> +                                       appropriate value when Vendor Specific
> +                                       Codec is used.
> +
> +                               uint16_t VendorCodecID [BAP only]:
> +
> +                                       Vendor-specific codec ID that the endpoint
> +                                       implements. It should be set to appropriate
> +                                       value when Vendor Specific Codec is used.
> +

Check the version Ive pushed, I end up merging these 2 into a single
property called Vendor which is a tuple of Company ID, Vendor Codec
ID, so you will need to adjust the changes to bluetoothctl.

>                                 array{byte} Capabilities:
>
>                                         Capabilities blob, it is used as it is
>                                         so the size and byte order must match.
>
> +                               array{byte} Metadata [BAP only]:
> +
> +                                       Metadata blob, it is used as it is
> +                                       so the size and byte order must match.
> +
>                         Possible Errors: org.bluez.Error.InvalidArguments
>                                          org.bluez.Error.NotSupported - emitted
>                                          when interface for the end-point is
> --
> 2.25.1
>


-- 
Luiz Augusto von Dentz