Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230105220944.2373424-1-luiz.dentz@gmail.com> <63b76559.050a0220.cbe75.dd46@mx.google.com>
In-Reply-To: <63b76559.050a0220.cbe75.dd46@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 5 Jan 2023 16:11:29 -0800
Message-ID: <CABBYNZ+_PgENto6BgULY_O9kgpAAmSmigAwq2U=9tmo-2J2GJg@mail.gmail.com>
Subject: Re: [BlueZ,1/4] shared/gatt-client: Use parent debug_callback if not
 set on clone
To:     linux-bluetooth@vger.kernel.org
Cc:     Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tedd,

On Thu, Jan 5, 2023 at 4:03 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=3D709=
312
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      2.39 seconds
> GitLint                       PASS      1.39 seconds
> BuildEll                      PASS      33.02 seconds
> BluezMake                     PASS      998.52 seconds
> MakeCheck                     PASS      12.62 seconds
> MakeDistcheck                 PASS      178.17 seconds
> CheckValgrind                 PASS      289.84 seconds
> CheckSmatch                   WARNING   383.95 seconds
> bluezmakeextell               PASS      116.46 seconds
> IncrementalBuild              PASS      3284.64 seconds
> ScanBuild                     WARNING   1193.87 seconds
>
> Details
> ##############################
> Test: CheckSmatch - WARNING
> Desc: Run smatch tool with source
> Output:
> src/shared/gatt-client.c:2764:33: warning: Variable length array is used.=
src/shared/gatt-client.c:2994:23: warning: Variable length array is used.sr=
c/shared/gatt-client.c:3075:23: warning: Variable length array is used.src/=
shared/gatt-client.c:3514:23: warning: Variable length array is used.src/sh=
ared/gatt-client.c:2764:33: warning: Variable length array is used.src/shar=
ed/gatt-client.c:2994:23: warning: Variable length array is used.src/shared=
/gatt-client.c:3075:23: warning: Variable length array is used.src/shared/g=
att-client.c:3514:23: warning: Variable length array is used.src/shared/gat=
t-client.c:2764:33: warning: Variable length array is used.src/shared/gatt-=
client.c:2994:23: warning: Variable length array is used.src/shared/gatt-cl=
ient.c:3075:23: warning: Variable length array is used.src/shared/gatt-clie=
nt.c:3514:23: warning: Variable length array is used.src/shared/gatt-client=
.c:2764:33: warning: Variable length array is used.src/shared/gatt-client.c=
:2994:23: warning: Variable length array is used.src/shared/gatt-client.c:3=
075:23: warning: Variable length array is used.src/shared/gatt-client.c:351=
4:23: warning: Variable length array is used.src/shared/gatt-client.c:2764:=
33: warning: Variable length array is used.src/shared/gatt-client.c:2994:23=
: warning: Variable length array is used.src/shared/gatt-client.c:3075:23: =
warning: Variable length array is used.src/shared/gatt-client.c:3514:23: wa=
rning: Variable length array is used.src/shared/gatt-client.c:2764:33: warn=
ing: Variable length array is used.src/shared/gatt-client.c:2994:23: warnin=
g: Variable length array is used.src/shared/gatt-client.c:3075:23: warning:=
 Variable length array is used.src/shared/gatt-client.c:3514:23: warning: V=
ariable length array is used.

Looks like the output of smatch is not quite right, it is probably
missing new line or something.

> ##############################
> Test: ScanBuild - WARNING
> Desc: Run Scan Build
> Output:
> src/shared/gatt-client.c:401:21: warning: Use of memory after it is freed
>         gatt_db_unregister(op->client->db, op->db_id);
>                            ^~~~~~~~~~
> src/shared/gatt-client.c:646:2: warning: Use of memory after it is freed
>         discovery_op_complete(op, false, att_ecode);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:943:2: warning: Use of memory after it is freed
>         discovery_op_complete(op, success, att_ecode);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:1049:2: warning: Use of memory after it is freed
>         discovery_op_complete(op, success, att_ecode);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:1241:2: warning: Use of memory after it is freed
>         discovery_op_complete(op, success, att_ecode);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:1306:2: warning: Use of memory after it is freed
>         discovery_op_complete(op, success, att_ecode);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:1577:6: warning: Use of memory after it is freed
>         if (read_db_hash(op)) {
>             ^~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:1582:2: warning: Use of memory after it is freed
>         discover_all(op);
>         ^~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:2088:6: warning: Use of memory after it is freed
>         if (read_db_hash(op)) {
>             ^~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:2096:8: warning: Use of memory after it is freed
>                                                         discovery_op_ref(=
op),
>                                                         ^~~~~~~~~~~~~~~~~=
~~~
> src/shared/gatt-client.c:3182:2: warning: Use of memory after it is freed
>         complete_write_long_op(req, success, 0, false);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/shared/gatt-client.c:3204:2: warning: Use of memory after it is freed
>         request_unref(req);
>         ^~~~~~~~~~~~~~~~~~
> 12 warnings generated.
>
>
>
> ---
> Regards,
> Linux Bluetooth
>


--=20
Luiz Augusto von Dentz