Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jing Qian <jingq77@gmail.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Jing Qian <jqian@calamp.com>
Subject: [PATCH BlueZ 1/1] hcidump:fix array boundary issue le_meta_ev_dump()
Date:   Thu,  5 Jan 2023 19:31:01 -0600
Message-Id: <20230106013101.35016-2-jqian@calamp.com>
In-Reply-To: <20230106013101.35016-1-jqian@calamp.com>
References: <20230106013101.35016-1-jqian@calamp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

le_meta_ev_dump() print array content without checking index boundary.
hcidump would crash if the event index is out-of-boundary
---
 tools/parser/hci.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/parser/hci.c b/tools/parser/hci.c
index db7d32c011b9..b434b879a292 100644
--- a/tools/parser/hci.c
+++ b/tools/parser/hci.c
@@ -3657,7 +3657,12 @@ static inline void le_meta_ev_dump(int level, struct frame *frm)
 	frm->len -= EVT_LE_META_EVENT_SIZE;
 
 	p_indent(level, frm);
-	printf("%s\n", ev_le_meta_str[subevent]);
+
+	if (subevent >= 0 && subevent <= LE_EV_NUM) {
+		printf("%s\n", ev_le_meta_str[subevent]);
+	} else {
+		printf("Undefined--> %d\n", subevent);
+	}
 
 	switch (mevt->subevent) {
 	case EVT_LE_CONN_COMPLETE:
-- 
2.25.1