From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
CC:     Johan Hedberg <johan.hedberg@gmail.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v5] Bluetooth: Add hci_nxp to hci_uart module to support
 NXP BT chipsets
Thread-Topic: [PATCH v5] Bluetooth: Add hci_nxp to hci_uart module to support
 NXP BT chipsets
Thread-Index: AQHZMB0o1bffURCKV0GDmBHEhWeqqA==
Date:   Tue, 24 Jan 2023 17:56:17 +0000
Message-ID: <AM9PR04MB8603BBC26BD17BAE735EC36AE7C99@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20221216094350.1121354-1-neeraj.sanjaykale@nxp.com>
 <85D2AE3F-97A5-4C88-8FC4-1684F3FD4438@holtmann.org>
 <CABBYNZLWFNWp=StPQ0=8hQe8bUoJzwSvCBk7Ybd=2oe=NROCgQ@mail.gmail.com>
 <5742801D-881A-45BC-A8A7-28D694179D8E@holtmann.org>
In-Reply-To: <5742801D-881A-45BC-A8A7-28D694179D8E@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T9WdUmcfh2SaRUffeX5j0MLn332PhIeRfyVLEC2favXupOewdqOzyGQr388m?=
 =?us-ascii?Q?/PGi3U4VU5vrtLMqtxzN0xVHbxdS9oJrNWpufq/UD6jrP5H4d3MStm+zCHbk?=
 =?us-ascii?Q?jGeTYJoIao6WDszYXGBEpb643aPGbxcq1yFImn3li0IlLUT+lk0KjByTbero?=
 =?us-ascii?Q?w+ZAMqd1uMl2DME9fTtRxu5vgOS6UUvtH6nP4fO7/zYvyLggVy/gtTxlpFbt?=
 =?us-ascii?Q?E1d+IuGy5evDD+aYxTuNLF7HpRTMswNmYKlYY1nmFfUhJjY52qjH9vcvMyZc?=
 =?us-ascii?Q?gqFPr1X0WJI+72nN2Sjx52oRosvQ8a5LY0AGIIA0FsRCT3aLWd7u28ztYEk8?=
 =?us-ascii?Q?1ja22OlYPKQ5NMEzXAb9t8npdMMzaF2zhAvVOkaxTtFL7Mm8jmSZ6YSOVAcM?=
 =?us-ascii?Q?X8pkaWN4rtBQoqN3gZYGu67iud3M5+QOVGLf2/5oeQSukCOg4zLrVFJ6SPRk?=
 =?us-ascii?Q?LctL4NQ0eu5EFnLlNPa0u55fEfoBLSJNvHp93A+ipHVcdVKf5FhRMvLnl4K2?=
 =?us-ascii?Q?VRRpDv5vQyCM731JCA5rVDFr8pdGCicUDTwemsgdliXH6tcCYMgxfCxckPWD?=
 =?us-ascii?Q?9S56r37zZXodlG1Ov2/9QycHv476Dt/BJZWTbh+GfPXyho1neqUKYRTh8uuO?=
 =?us-ascii?Q?yNeUks2PHQNBjWm648PLs1AuyVoSvWPhZo1s8OKKj/zX6+mTwJyQrSQG50S/?=
 =?us-ascii?Q?pgBdMrB88A9p2TtG2lGTtcY7y6F+JTdsej0F8pbIjBYyx550dn051lfggN6e?=
 =?us-ascii?Q?XOxtR20YNG5/cVH5o9BS4mpOgn55qqnDP8J6VpmlZYaVkUwVqDfrdGyluFQy?=
 =?us-ascii?Q?cEJQXfpWPlOnN/c0iBst74HcrLsiRFUaQI1K0XC4n51pdYrSj0xCY3KqkNZ+?=
 =?us-ascii?Q?QyaAKpN7mx6p09VVdygR9bPmfjLlWla84yPyvagLAcN4dUZUyAyrKCqjCzOP?=
 =?us-ascii?Q?CpgA2+vMBv3TT1tR1S2UHl+GlLqMt8LMbo5TJ/Vp8GC4qNITt8D1p60nX/Kp?=
 =?us-ascii?Q?5kpDmK+AyS7zuIfrceO8ZtPT51/kud9ZvES9hWvoZ+YqyP1dB/hz4LAsnOad?=
 =?us-ascii?Q?hif4SzIhsoe3q0vVN2qZxm4Io+XkE027akOTzFfKVR5HzIe7/OIf3ToG6Wsw?=
 =?us-ascii?Q?QjW4iCrN24MRMAdCa4mPXqUXYxgAPlC4840zVRveUh5UpNqvz7FnsXfdSiYK?=
 =?us-ascii?Q?QSWOBJ1K/ndibY6+kjXg9AJo+NhHqXeYFrkOe0SY7mS5XqYVxdwg5oSXqfNd?=
 =?us-ascii?Q?Ey0g4KNGCE7lMWnAF16rI2bcWDuPsRQitSn/K1lDzLE9iLW68W6P7bJNsksZ?=
 =?us-ascii?Q?C070iV5zf4wd90OY+fcor2wNCu623rjN8EwbLy3lD+DUTjnk1H9720lNHL2A?=
 =?us-ascii?Q?yx7zCbYL6PAyO3lptSPljc9GHtbATI6ZuS8tPSTwb2nt0q7AOzXN2L2wMl3V?=
 =?us-ascii?Q?Db9hBSYtpjmP0oSJF8pplGWqduUcXS8+YZkGX+seU4Ha1etiPOqirfL7Q9wh?=
 =?us-ascii?Q?N3KLfKsep5unVIbN5ESe3azPJNC0Vc2ifhJw5U1bvB7gbW5jCf318OSk/eCN?=
 =?us-ascii?Q?RWHhesWryzGIYi6SBwZ2lFWk8xpY7+FFctCX6a35fYJNspLBIH9R2PKY/tc1?=
 =?us-ascii?Q?lg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de80e041-422b-410f-10bd-08dafe344b02
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2023 17:56:17.5902
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bFK8vpX6K3VWQSXOXHFwS5czy7+MVWBvwuoR33bYdCyUDtqATfKy115J4pcx6M1gcp+71ITgR/AeEPa/Ui7QjuvXXqjXfsm5rjqMFWPJeqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7719
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Monday, December 19, 2022 5:12 PM
> To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>; Johan Hedberg
> <johan.hedberg@gmail.com>; Paul Menzel <pmenzel@molgen.mpg.de>;
> Amitkumar Karwar <amitkumar.karwar@nxp.com>; Rohit Fule
> <rohit.fule@nxp.com>; Sherry Sun <sherry.sun@nxp.com>; LKML <linux-
> kernel@vger.kernel.org>; linux-bluetooth@vger.kernel.org
> Subject: Re: [PATCH v5] Bluetooth: Add hci_nxp to hci_uart module to
> support NXP BT chipsets
>=20
> Hi Luiz,
>=20
> >>> Add hci_nxp to the hci_uart module which adds support for the NXP BT
> >>> chips. This driver has Power Save feature that will put the NXP
> >>> bluetooth chip into sleep state, whenever there is no activity for
> >>> certain duration of time (2000ms), and will be woken up when any
> >>> activity is to be initiated.
> >>>
> >>> The Power Save feature can be configured with the following set of
> >>> commands (optional):
> >>> hcitool -i hci0 cmd 3F 23 02 00 00    (enable Power Save)
> >>> hcitool -i hci0 cmd 3F 23 03 00 00    (disable Power Save)
> >>> where,
> >>> OGF =3D 0x3F (vendor specific command) OCF =3D 0x23 (command to set
> >>> Power Save state) arg[0] =3D 0x02 (disable Power Save) arg[0] =3D 0x0=
3
> >>> (enable Power Save) arg[1,2,...] =3D XX (don't care)
> >>>
> >>> The sleep/wake-up source can be configured with the following set of
> >>> commands (optional):
> >>> hcitool -i hci0 cmd 3F 53 03 14 01 FF    (set UART break method)
> >>> hcitool -i hci0 cmd 3F 53 03 14 00 FF    (set UART DSR method)
> >>> where,
> >>> OGF =3D 0x3F (vendor specific command) OCF =3D 0x53 (command to set
> >>> sleep and wake-up source) arg[0] =3D 0x00 (Chip to host method NONE)
> >>> arg[0] =3D 0x01 (Chip to host method UART DTR) arg[0] =3D 0x02 (Chip =
to
> >>> host method UART BREAK) arg[0] =3D 0x03 (Chip to host method GPIO)
> >>> arg[1] =3D 0x14 (Chip to host GPIO[20] if arg[0] is 0x03, else 0xFF)
> >>> arg[2] =3D 0x00 (Host to chip method UART DSR) arg[2] =3D 0x01 (Host =
to
> >>> chip method UART BREAK) arg[3] =3D 0xXX (Reserved for future use)
> >>>
> >>> By default, the hci_nxp sets power save enable, chip to host wake-up
> >>> source as GPIO and host to chip sleep and wake-up source as UART
> >>> break during driver initialization, by sending the respective
> >>> commands to the chip.
> >>>
> >>> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> >>> ---
> >>> v2: Changed the subject/summary lines and added more details in the
> >>> description. (Paul Menzel)
> >>> v3: Made internal functions static, optimized the code, added few
> >>> comments. (Sherry Sun)
> >>> v4: Reworked entire code to send vendor commands cmd23 and cmd53
> by
> >>> using __hci_cmd_sync. (Luiz Augusto von Dentz)
> >>> v5: Used hci_command_hdr and combined OGF+OCF into a single
> opcode.
> >>> (Luiz Augusto von Dentz)
> >>> ---
> >>> MAINTAINERS                   |   6 +
> >>> drivers/bluetooth/Kconfig     |  10 +
> >>> drivers/bluetooth/Makefile    |   1 +
> >>> drivers/bluetooth/hci_ldisc.c |   6 +
> >>> drivers/bluetooth/hci_nxp.c   | 592
> ++++++++++++++++++++++++++++++++++
> >>> drivers/bluetooth/hci_nxp.h   |  94 ++++++
> >>> drivers/bluetooth/hci_uart.h  |   8 +-
> >>> 7 files changed, 716 insertions(+), 1 deletion(-) create mode 100644
> >>> drivers/bluetooth/hci_nxp.c create mode 100644
> >>> drivers/bluetooth/hci_nxp.h
> >>
> >> so this is a clear NAK. Add this as serdev driver and not hook
> >> further into the mess that is the HCI line discipline.
> >
> > I wonder if we should make it more clear somehow, perhaps include a
> > text on the likes of BT_HCIUART that is deprecated and new drivers
> > shall use BT_HCIUART_SERDEV instead.
>=20
> not even that. They need to be separate drivers. A long time ago I posted=
 the
> skeleton for btuart.ko and bt3wire.ko and that is where this has to go.
>=20
> Regards
>=20
> Marcel

I have just sent out a new patch for btnxp.ko which is based on serdev with=
 subject "Add support for NXP bluetooth chipsets".
Please have a look at it and let me know if this is how you want the driver=
 to be implemented.
Let me know if you have any comments or suggestions and please discard this=
 patch series.

Thanks,
Neeraj