Message-ID: <ff2a546c-e650-75b8-de2e-d682b9c79624@linaro.org>
Date:   Fri, 27 Jan 2023 09:47:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2] dt-bindings: leds: Document Bluetooth and WLAN
 triggers
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Lee Jones <lee@kernel.org>
Cc:     patchwork-bot+bluetooth@kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>, pavel@ucw.cz,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-bluetooth@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        robh@kernel.org
References: <0d0de1bc949d24e08174205c13c0b59bd73c1ea8.1674384302.git.geert+renesas@glider.be>
 <167460363944.4058.4676712965831302643.git-patchwork-notify@kernel.org>
 <Y9FG5Wg0PmP4zfV6@google.com>
 <CABBYNZJEU-GD5J6K8_Ur4PWLvP10VNJGP7e_43H0=W3DOS=PNw@mail.gmail.com>
 <Y9IzMWnOq+r2/4V2@google.com>
 <CABBYNZ+Na7os7D_C_iV22UhyhobxiETjKkngPWVr14QAph6DfQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CABBYNZ+Na7os7D_C_iV22UhyhobxiETjKkngPWVr14QAph6DfQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/01/2023 21:46, Luiz Augusto von Dentz wrote:
> Hi Lee,
> 
> On Thu, Jan 26, 2023 at 12:00 AM Lee Jones <lee@kernel.org> wrote:
>>
>> On Wed, 25 Jan 2023, Luiz Augusto von Dentz wrote:
>>
>>> Hi Lee,
>>>
>>> On Wed, Jan 25, 2023 at 7:16 AM Lee Jones <lee@kernel.org> wrote:
>>>>
>>>> On Tue, 24 Jan 2023, patchwork-bot+bluetooth@kernel.org wrote:
>>>>
>>>>> Hello:
>>>>>
>>>>> This patch was applied to bluetooth/bluetooth-next.git (master)
>>>>> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>>>>>
>>>>> On Sun, 22 Jan 2023 11:47:27 +0100 you wrote:
>>>>>> Add the missing trigger patterns for Bluetooth and WLAN activity, which
>>>>>> are already in active use.
>>>>>>
>>>>>> While at it, move the mmc pattern comment where it belongs, and restore
>>>>>> alphabetical sort order.
>>>>>>
>>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Here is the summary with links:
>>>>>   - [v2] dt-bindings: leds: Document Bluetooth and WLAN triggers
>>>>>     https://git.kernel.org/bluetooth/bluetooth-next/c/ef017002b93b
>>>>
>>>> Why are you taking LED patches through the Bluetooth tree?
>>>
>>> I assume there isn't a tree dedicated to dt-bindings/leds
>>
>> % ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/leds/common.yaml
>>  Pavel Machek <pavel@ucw.cz> (maintainer:LED SUBSYSTEM,in file)
>>  Lee Jones <lee@kernel.org> (maintainer:LED SUBSYSTEM)
>>  Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  Jacek Anaszewski <jacek.anaszewski@gmail.com> (in file)
>>  linux-leds@vger.kernel.org (open list:LED SUBSYSTEM)
>>  devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>  linux-kernel@vger.kernel.org (open list)
> 
> Well this doesn't tell us what parts of the dt_bindings have a
> dedicated tree and which doesn't, 

There is no such "parts" anywhere. I don't understand that remark and
how is related here. This is a list of maintainers for this file. Why
information are you missing in MAINTAINERS? And why bindings would be
special (e.g. you don't miss this information for other parts of kernel)?

>>
>>> anyway I'd be happy if the dt-bindings patches
>>> would be handled elsewhere.
>>
>> Yep, we got this. :)
> 
> So if it starts with dt-binding: prefix shall we ignore? Or is just
> for dt-bindings: leds? Or perhaps we can just ignore patches received
> as CC: rather than directly To: field.

What was exactly unclear in my response? The bindings for your subsystem
are for you. Bindings for other subsystems are not for you. dt-bindings:
leds: are for leds suubsystem. dt-bindings: mfd: are for mfd subsystem.
If the prefix is incorrect because people make mistakes, the paths point
to it - Documentation/devicetree/bindings/SUBSYSTEM_OR_HARDWARE_CLASS/....


Best regards,
Krzysztof