MIME-Version: 1.0
References: <20230127113504.134109-1-marcin.kraglak@telink-semi.com>
In-Reply-To: <20230127113504.134109-1-marcin.kraglak@telink-semi.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 27 Jan 2023 12:11:33 -0800
Message-ID: <CABBYNZ+AeLnokfsrTp3=vsC7j6E4Uei_U=1Ex6LhYzU_-PDzMw@mail.gmail.com>
Subject: Re: [PATCH 1/2] shared/util: Add CAS, HAS, TMAS and PBAS UUIDs
To:     Marcin Kraglak <marcin.kraglak@telink-semi.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Marcin,

On Fri, Jan 27, 2023 at 3:42 AM Marcin Kraglak
<marcin.kraglak@telink-semi.com> wrote:
>
> Add UUIDs for: Common Audio service, Hearing Aid service,
> TMAS service and Public Broadcast Announcement service.
> ---
>  src/shared/util.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/shared/util.c b/src/shared/util.c
> index 69abfba31..1ff9c56fc 100644
> --- a/src/shared/util.c
> +++ b/src/shared/util.c
> @@ -447,7 +447,11 @@ static const struct {
>         { 0x1850, "Published Audio Capabilities"                },
>         { 0x1851, "Basic Audio Announcement"                    },
>         { 0x1852, "Broadcast Audio Announcement"                },
> -       /* 0x1853 to 0x27ff undefined */
> +       { 0x1853, "Common Audio"                                },
> +       { 0x1854, "Hearing Aid"                                 },
> +       { 0x1855, "TMAS"                                        },

We don't use the abbreviation here, so it should be Telephony and Media Audio

> +       { 0x1856, "Public Broadcast Announcement"               },
> +       /* 0x1857 to 0x27ff undefined */
>         { 0x2800, "Primary Service"                             },
>         { 0x2801, "Secondary Service"                           },
>         { 0x2802, "Include"                                     },
> @@ -681,6 +685,7 @@ static const struct {
>         { 0x2b29, "Client Supported Features"                   },
>         { 0x2b2A, "Database Hash"                               },
>         { 0x2b3a, "Server Supported Features"                   },
> +       { 0x2b51, "TMAP Role"                                   },

Ditto.

>         { 0x2b77, "Audio Input State"                           },
>         { 0x2b78, "Gain Settings Attribute"                     },
>         { 0x2b79, "Audio Input Type"                            },
> @@ -751,6 +756,9 @@ static const struct {
>         { 0x2bcc, "Source Audio Locations"                      },
>         { 0x2bcd, "Available Audio Contexts"                    },
>         { 0x2bce, "Supported Audio Contexts"                    },
> +       { 0x2bda, "Hearing Aid Features"                        },
> +       { 0x2bdb, "Hearing Aid Preset Control Point"            },
> +       { 0x2bdc, "Active Preset Index"                         },
>         /* vendor defined */
>         { 0xfeff, "GN Netcom"                                   },
>         { 0xfefe, "GN ReSound A/S"                              },
> --
> 2.39.0
>


-- 
Luiz Augusto von Dentz