Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDD5C636D3 for ; Wed, 1 Feb 2023 03:13:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231600AbjBADNy (ORCPT ); Tue, 31 Jan 2023 22:13:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbjBADNx (ORCPT ); Tue, 31 Jan 2023 22:13:53 -0500 Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A92F345BC2 for ; Tue, 31 Jan 2023 19:13:51 -0800 (PST) Received: by mail-oo1-xc33.google.com with SMTP id k15-20020a4adfaf000000b00517450f9bd7so1070928ook.8 for ; Tue, 31 Jan 2023 19:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D3YwzPamfjwuuQEM2RnT++paWIr3qoCEOZrgbHTxW64=; b=MOgnvtiSozTzruoGwOmugYaSILZTBMfknxbWXgCDJACJwzf+1UZiN6+wiVvYcGk7hS 3Ykc1fwKnTojw9Wm5OgQ8BpUoCLku3rvaI6tXVMYcDPxb8EO0TGKuEg2lJdlHlffzY5a iAboOfuZ4vOqXbRUNRdi0zokHiNFc/+JgGWKVrYe96+3Kr5blF0F6cweRCcXlGX4x1db IGJ7W4sTAxOhfIK1M43AFkfPidRW9hlU8lEti2zi/bOGTaWXtJWHZOId244O+adzZvKb OHDLWj+X3dgw5XqRV8SZ9NJ1hPRrN6QWZ4qCWmkmFHyhZTcb1x9WI92nbJdES5N0a+9m QO6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D3YwzPamfjwuuQEM2RnT++paWIr3qoCEOZrgbHTxW64=; b=Hb/gA4mN1fRsAeYwMIRXeKCyXe75r84XDT5CJnXPZ2wMbXWP8p/rtEEbff/BLjQXGn V+gIDWnZg50dKsCYUHSHKkJeSfoV1zdIqGnQaGSGIBNxroH/qMY3J3FXZ9r0kh+XoYzG K56y5HeYJGOaIcWoVvCf2aaSWxAA08TyML3j0voek2cOw0m+2oSusBSy4zsq8Q1gPtpB HrCvU/os7Bs3MK6iC3ixpPnyPgpTsfq+nPoflZgH9ofOaPIFwEjhqbe7G/5az+MYjhFa 4jf0sbEgHi4bevvCKoiKxv+TD8uNGHqHcT9LGuySWrJg6iacTiRzvAQ7wNGR/jOxDuEz jejw== X-Gm-Message-State: AO0yUKUh5rTvJHgrPQPglob2GjRyqe3dlum9niAi8+TyFh6QdWWCGiH2 8Gjz/8df0FN7YchYlws6uiGcIw== X-Google-Smtp-Source: AK7set9KsGzjn5wBbpVtqFW2yRyYfDcWH3ZWqT6jjr/GW26QHQ0Hxu1/dF14CQcqYitui3cWEdRFBw== X-Received: by 2002:a4a:a2c9:0:b0:517:640f:5905 with SMTP id r9-20020a4aa2c9000000b00517640f5905mr464907ool.3.1675221230905; Tue, 31 Jan 2023 19:13:50 -0800 (PST) Received: from localhost (23-118-233-243.lightspeed.snantx.sbcglobal.net. [23.118.233.243]) by smtp.gmail.com with ESMTPSA id k68-20020a4a4a47000000b005176974faf3sm3557618oob.35.2023.01.31.19.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 19:13:50 -0800 (PST) From: Steev Klimaszewski To: Krzysztof Kozlowski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Sven Peter , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, Mark Pearson Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: thinkpad-x13s: Add bluetooth Date: Tue, 31 Jan 2023 21:13:49 -0600 Message-Id: <20230201031349.56405-1-steev@kali.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org >On 31/01/2023 05:38, Steev Klimaszewski wrote: >> Signed-off-by: Steev Klimaszewski >> --- >> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 68 +++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> index f936b020a71d..951438ac5946 100644 >> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts >> @@ -24,6 +24,8 @@ / { >> aliases { >> i2c4 = &i2c4; >> i2c21 = &i2c21; >> + serial0 = &uart17; >> + serial1 = &uart2; >> }; >> >> wcd938x: audio-codec { >> @@ -712,6 +714,32 @@ &qup0 { >> status = "okay"; >> }; >> >> +&uart2 { >> + status = "okay"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart2_state>; >> + >> + bluetooth { >> + compatible = "qcom,wcn6855-bt"; >> + >> +/* > Why dead code should be in the kernel? As mentioned in the cover letter, this is a bit closer to an RFC than ready to go in, and I do apologize that it wasn't clear enough. I do not have access to the schematics, and based on my reading of the schema for bluetooth, these entries are supposed to be required, however, like the wcn6750, I have dummy data entered into the qca_soc_data_wcn6855 struct. I know that these should be there, I just do not have access to the correct information to put, if that makes sense? >Does not look like you tested the DTS against bindings. Please run `make >dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst >for instructions). Correct I had not, but I have now, and will make the corrections test and they will be included in v3. >Best regards, >Krzysztof I appreciate the guidance for what I was doing incorrectly. -- steev