From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Rob Herring <robh@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
        "hdanton@sina.com" <hdanton@sina.com>,
        "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>
Subject: Re: [PATCH v2 3/3] Bluetooth: NXP: Add protocol support for NXP
 Bluetooth chipsets
Thread-Topic: [PATCH v2 3/3] Bluetooth: NXP: Add protocol support for NXP
 Bluetooth chipsets
Thread-Index: AQHZNjlvc3KPU/mXzUmdiUoieetwDA==
Date:   Wed, 1 Feb 2023 12:33:50 +0000
Message-ID: <AM9PR04MB86039B970C497F603BBAB74FE7D19@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20230130180504.2029440-1-neeraj.sanjaykale@nxp.com>
 <20230130180504.2029440-4-neeraj.sanjaykale@nxp.com>
 <20230131022041.GB4082140-robh@kernel.org>
In-Reply-To: <20230131022041.GB4082140-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/vjxAvvSgNz7NQn2Fg8jo7F0JsU/+wLMJXGYsgXI/SWCIlHSHcriTsPpq4F0?=
 =?us-ascii?Q?mu8rNkenyg0Maopk6cAvHpWFoAsj2181SwqaZKvs89qKdN4KcQFMcofP1Xau?=
 =?us-ascii?Q?0iab52FPUAUPS5kagZFrvyh+4q9VxLLxzm4JvuTyFgP6uiS8aePjd4CmjRpa?=
 =?us-ascii?Q?+gEzbNyBohWjRvZaNntb6jdPSK0dd4pa6TCB1rRgyRaxnelzWGCCkxjigTA0?=
 =?us-ascii?Q?64cQuOf743XTfFNHQWyUH6H5jx91RR9kf9R8yxhHJx9mgsyC36OrCx5L3PMD?=
 =?us-ascii?Q?U1Pa0eP8H8sgyR0T58M8r3tujRIwO2SM5B7Apa8BDTmaV0UKVNwHQ3k5fMf/?=
 =?us-ascii?Q?qgaN8l1HGo2KWfATGKbGIJUub3CERmJDyTcUKzimUyv/IkhgEU22hWYLIGUn?=
 =?us-ascii?Q?rtEcjurzLpv57nU+C+EPNgrVhAvUrEnewY62KaK+WIU+1yMQz3kbQ6BFNRoL?=
 =?us-ascii?Q?H/u/5qxgy5HC5yx0RLNeBnMfTrP5kDlwD1OHkC7owOIzM4Uw4BYW/GXqtQst?=
 =?us-ascii?Q?sL8Vbli5NtRYfEwAmSApWxuEsDlNs7rX3Wu1LURy3VT6nqk8/hpNIbPL7oRR?=
 =?us-ascii?Q?lYHAClMbzBDfONza3ra73KWdQsB16pcvjODYsiwzJi8pXSrLmz9X6c1j1NPh?=
 =?us-ascii?Q?rZIanRVh7MpzEuEoYyFRYmOrEbBYJz1DuOWJGB4Tz94lXgtSIKIYKK6I65LJ?=
 =?us-ascii?Q?s3A5Rvqectw7XSiOMtGlGT26tvccp8ragh7haJ9vBf9R1z8BFH5N+v/OpKXJ?=
 =?us-ascii?Q?xJSqI0nqVxdn6aqzzUs5GZQYMSnVke0SdNYAyQP1ceDzGr0//tYTH9U6pRCZ?=
 =?us-ascii?Q?47QFcPG9YqjntTW6+Xu7l2NHnEI10DUxLTU6y1wany0fdZabcXdBMRizgGnh?=
 =?us-ascii?Q?YDMENBW9EQVggCiefH0evgaY4RgFOzg8xf3VBUqRFfx1UpwV9dHx5Fwyjyus?=
 =?us-ascii?Q?p26Rm+PNcY1TXEoDjwTZE2ZNbc1XJab5BzSC+sh2dTk17inNfL6XVWXJ986s?=
 =?us-ascii?Q?xgc0UDFlETbARPtsVPHU02IAMoUSXRjHPXTHTr/2wTYv7NBmu1803y79DN/q?=
 =?us-ascii?Q?7Zi5rlTC3FcYUFOkpx8a5hARbCKlfo+jsfU9BckBGKv2yCVPf3gTPiOMC1LO?=
 =?us-ascii?Q?LqxQXLCPA2tRt3sbbzu1Xp8ttAMnUrArJZAM5Jo5ugjqESH/g676cCPYzLZn?=
 =?us-ascii?Q?LYjZclCKNi/h/HNuLRgsM9eS97XahGhhgmmTEAP6fyDFQK337l+SaiUKaFrS?=
 =?us-ascii?Q?CKseVIB8Kar51XLj8CV973jWMEq8bT56D0fbwjEjerKaWETpuocm7hKkKYZW?=
 =?us-ascii?Q?8hh1CSbowdBYeVq6mfBMEWs+/VZjK4RNLpk3XiXXQAyERo97EN2TzKDZFu0Q?=
 =?us-ascii?Q?5PBb3MWXsXO+bYdQ+LKbJFEihiJ5/B8A6WVr3R8g5qPR0MLxQyyz7Vw+tv2x?=
 =?us-ascii?Q?eRsWT1vE6DXSn/4YdAZyx5VEB/QXtTTlwQMl024Zjv6Wz2yNP6nAY6fKahbg?=
 =?us-ascii?Q?5T30h5OOuYRgqZTAMNV1OKxtZ/a5hrfRrIK9yP+Mlz6CT0KjE7qFBAMtxh7K?=
 =?us-ascii?Q?iX7VWBRWHqPnfF24/68o4p8Y45ByLYeJzAzP58Kb+N8xaMA2ZelMFlqIkKyE?=
 =?us-ascii?Q?nQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 58051d51-ec87-4082-3f8e-08db04509258
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2023 12:33:50.1896
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FwW4VRFAHdP/gyc2pgeOoN7bOX1TfTP2p+HNh6NrHHVfOL8ej6FWQh/5tMWuaQ/vvP7xnqpoH1lydO2b8sGtRx2ELaR91/iKZL7NHPYdaXE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7925
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Rob,

Thank you for your feedback. I am working on all the review comments receiv=
ed.

>=20
> On Mon, Jan 30, 2023 at 11:35:04PM +0530, Neeraj Sanjay Kale wrote:
> > This adds a driver based on serdev driver for the NXP BT serial
> > protocol based on running H:4, which can enable the built-in
> > Bluetooth device inside a generic NXP BT chip.
>=20
> These are rebranded or descend from Marvell chips, right? Maybe this
> should be merged with the 88w8897. The firmware download seems to
> match
> the v1 protocol.
>=20
The 88w8897 was a legacy Marvell chipset, while the newer chipsets we are t=
rying to add here are branded under "NXP".
Most of the newer chipset download FW using V3 protocol and few of them use=
 V1 protocol, which is still different from the V1 protocol seen for 8897 c=
hip.

Initially we tried to add support for NXP chipsets in hci line-discipline, =
but Marcel Holtmann advised us to implement this standalone driver based on=
 serdev.

Thanks,
Neeraj