MIME-Version: 1.0
References: <20230202114614.53907-1-max.chou@realtek.com> <63dbaf9b.c80a0220.30d2e.7d9c@mx.google.com>
In-Reply-To: <63dbaf9b.c80a0220.30d2e.7d9c@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 2 Feb 2023 14:03:13 -0800
Message-ID: <CABBYNZLf6NhA9TGASAh0NH0LMU0DSPGb-UCSU0oBdN3N6=k7LA@mail.gmail.com>
Subject: Re: [v2] Bluetooth: btrtl: Firmware format v2 support
To:     linux-bluetooth@vger.kernel.org
Cc:     max.chou@realtek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Max,

On Thu, Feb 2, 2023 at 4:44 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=3D718=
117
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      1.47 seconds
> GitLint                       FAIL      0.59 seconds
> SubjectPrefix                 PASS      0.12 seconds
> BuildKernel                   PASS      32.41 seconds
> CheckAllWarning               PASS      34.42 seconds
> CheckSparse                   WARNING   39.28 seconds
> CheckSmatch                   WARNING   107.00 seconds
> BuildKernel32                 PASS      30.51 seconds
> TestRunnerSetup               PASS      438.93 seconds
> TestRunner_l2cap-tester       PASS      16.68 seconds
> TestRunner_iso-tester         PASS      17.51 seconds
> TestRunner_bnep-tester        PASS      5.83 seconds
> TestRunner_mgmt-tester        PASS      113.14 seconds
> TestRunner_rfcomm-tester      PASS      9.24 seconds
> TestRunner_sco-tester         PASS      8.45 seconds
> TestRunner_ioctl-tester       PASS      9.90 seconds
> TestRunner_mesh-tester        PASS      7.34 seconds
> TestRunner_smp-tester         PASS      8.30 seconds
> TestRunner_userchan-tester    PASS      6.11 seconds
> IncrementalBuild              PASS      28.50 seconds
>
> Details
> ##############################
> Test: GitLint - FAIL
> Desc: Run gitlint
> Output:
> [v2] Bluetooth: btrtl: Firmware format v2 support
>
> WARNING: I3 - ignore-body-lines: gitlint will be switching from using Pyt=
hon regex 'match' (match beginning) to 'search' (match anywhere) semantics.=
 Please review your ignore-body-lines.regex option accordingly. To remove t=
his warning, set general.regex-style-search=3DTrue. More details: https://j=
orisroovers.github.io/gitlint/configuration/#regex-style-search
> 24: B1 Line exceeds max length (83>80): "> I rather use an skb for parsin=
g the data instead of parsing via pointer directly,"
> ##############################
> Test: CheckSparse - WARNING
> Desc: Run sparse tool with linux kernel
> Output:
> drivers/bluetooth/btrtl.c:882:22: warning: cast to restricted __le16drive=
rs/bluetooth/btrtl.c:888:27: warning: cast to restricted __le16drivers/blue=
tooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warn=
ing: array of flexible structures
> ##############################
> Test: CheckSmatch - WARNING
> Desc: Run smatch tool with source
> Output:
> drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl=
.h:47:45: warning: array of flexible structures
>
>
> ---
> Regards,
> Linux Bluetooth

Id give a look at:

https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.gi=
t/tree/Documentation/driver-api/firmware/fw_upload.rst

There are not so many drivers since it was introduced last year but
from the looks of it it has a nice abstraction for handling firmware
uploads.


--=20
Luiz Augusto von Dentz