MIME-Version: 1.0
References: <a8aedc0f9a4c1e21d61694589c5b7a9f31cbedc1.1675103676.git.pav@iki.fi>
In-Reply-To: <a8aedc0f9a4c1e21d61694589c5b7a9f31cbedc1.1675103676.git.pav@iki.fi>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 6 Feb 2023 17:08:28 -0800
Message-ID: <CABBYNZLWt6y7beYF8-62G018LY+8yHSOhQAdvVKFbWn1YDzKQQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/8] doc: add MGMT setting for CIS features, remove
 Quality Report
To:     Pauli Virtanen <pav@iki.fi>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Pauli,

On Mon, Jan 30, 2023 at 10:43 AM Pauli Virtanen <pav@iki.fi> wrote:
>
> Add definitions for new MGMT Controller Information settings bits,
> indicating adapter Connected Isochronous Stream - Central/Peripheral
> feature support.
>
> The Set Quality Report command was removed in
> commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"),
> but the settings bit was not removed. It's also not implemented on
> kernel side, so remove it now.

Let's split this into 2 patches, one removing Quality Report, since it
was never implemented, and then another including the new flags.

> ---
>
> Notes:
>     Was the quality report setting bit reserved on purpose?
>
>     From the commit log it looks like it was forgotten to remove from the
>     docs, but this is not clear.
>
>  doc/mgmt-api.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 90d612ed8..58395dc90 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -332,7 +332,8 @@ Read Controller Information Command
>                 15      Static Address
>                 16      PHY Configuration
>                 17      Wideband Speech
> -               18      Quality Report
> +               18      Connected Isochronous Stream - Central
> +               19      Connected Isochronous Stream - Peripheral
>
>         This command generates a Command Complete event on success or
>         a Command Status event on failure.
> @@ -2925,7 +2926,8 @@ Read Extended Controller Information Command
>                 15      Static Address
>                 16      PHY Configuration
>                 17      Wideband Speech
> -               18      Quality Report
> +               18      Connected Isochronous Stream - Central
> +               19      Connected Isochronous Stream - Peripheral
>
>         The EIR_Data field contains information about class of device,
>         local name and other values. Not all of them might be present. For
> --
> 2.39.1
>


-- 
Luiz Augusto von Dentz