MIME-Version: 1.0
References: <20230208155220.1640-1-bage@debian.org> <20230208155220.1640-3-bage@debian.org>
 <CABBYNZKnt5=dar6Rmav=Tv3QH1ghSUV2osZPnp7OQLcANp_1Tw@mail.gmail.com> <0B0EFD39-825F-4635-A7F3-CA96BCFED9A2@holtmann.org>
In-Reply-To: <0B0EFD39-825F-4635-A7F3-CA96BCFED9A2@holtmann.org>
From:   Vasily Khoruzhick <anarsoul@gmail.com>
Date:   Wed, 8 Feb 2023 23:14:19 -0800
Message-ID: <CA+E=qVdLhyJYj-53+OSgpLQcTXY=H4TsVb-UFQYhMSkHZJj4hA@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] Bluetooth: btrtl: add support for the RTL8723CS
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Bastian Germann <bage@debian.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        BlueZ <linux-bluetooth@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 8, 2023 at 11:02 PM Marcel Holtmann <marcel@holtmann.org> wrote:

Hi Marcel,

> Hi Luiz,
>
> >> The Realtek RTL8723CS is a SDIO WiFi chip. It also contains a Bluetooth
> >> module which is connected via UART to the host.
> >>
> >> It shares lmp subversion with 8703B, so Realtek's userspace
> >> initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS
> >> (CG, VF, XX) with RTL8703B using vendor's command to read the chip type.
> >
> > Don't remember anything called rtk_hciattach, besides if that is based
> > on hciattach that is already deprecated in favor of btattach.
>
> and btattach is also deprecated. Write a proper serdev based driver.

It is already a proper serdev based driver. rtk_hciattach is only
mentioned to explain how differentiating the chips was implemented
prior to this driver.

Regards,
Vasily

> The hci_ldisc line discipline crap needs to be removed.
>
> Regards
>
> Marcel
>