MIME-Version: 1.0
References: <20230126074356.431306-1-francesco@dolcini.it> <Y+YC3Pka42SmtyvI@francesco-nb.int.toradex.com>
 <CABBYNZLNFFUeZ1cb9xABhaymWnSiZjazwVT9N12qHyc7e0L6QQ@mail.gmail.com> <Y+aVQ38sJvuUd4HM@francesco-nb.int.toradex.com>
In-Reply-To: <Y+aVQ38sJvuUd4HM@francesco-nb.int.toradex.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 10 Feb 2023 11:30:48 -0800
Message-ID: <CABBYNZL7aD51jW=UxvcMBvfxbgFZ17H5nhfQ174JJNWDSdWe2A@mail.gmail.com>
Subject: Re: [PATCH v2 0/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997
To:     Francesco Dolcini <francesco@dolcini.it>,
        Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Francesco,

On Fri, Feb 10, 2023 at 11:04 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> On Fri, Feb 10, 2023 at 10:52:43AM -0800, Luiz Augusto von Dentz wrote:
> > Hi Francesco,
> >
> > On Fri, Feb 10, 2023 at 12:40 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> > >
> > > Hello all,
> > >
> > > On Thu, Jan 26, 2023 at 08:43:51AM +0100, Francesco Dolcini wrote:
> > > > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > >
> > > > Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> > > > support for changing the baud rate. The command to change the baud rate is
> > > > taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> > > > interfaces) from NXP.
> > >
> > > Just a gently ping on this series, patches 1,2 with DT binding changes
> > > are reviewed/acked, patch 5 with the DTS change should just be on hold
> > > till patches 1-4 are merged.
> > >
> > > No feedback on patches 4 (and 3), with the BT serdev driver code
> > > changes, any plan on those?
> >
> > bots have detected errors on these changes
>
> From what I can understand from this point of view v2 is fine, the error
> was in v1, if I'm wrong just let me know.
>
> Said that I'll do the change you asked regarding __hci_cmd_sync_status
> and send a v3.

Great, for some reason your set is not being tested by our CI though,
@Tedd Ho-Jeong An do you know why?

> Thanks,
> Francesco
>


-- 
Luiz Augusto von Dentz