MIME-Version: 1.0
References: <20230213120926.8166-1-francesco@dolcini.it>
In-Reply-To: <20230213120926.8166-1-francesco@dolcini.it>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 15 Feb 2023 12:36:34 -0800
Message-ID: <CABBYNZ+y2jDi=0FFx31oB86skpDFTm5n+fDd5LBmvdxzOhqoSA@mail.gmail.com>
Subject: Re: [PATCH v3 0/5] Bluetooth: hci_mrvl: Add serdev support for 88W8997
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        Marcel Holtmann <marcel@holtmann.org>,
        linux-arm-kernel@lists.infradead.org,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Francesco,

On Mon, Feb 13, 2023 at 4:09 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>
> Add serdev support for the 88W8997 from NXP (previously Marvell). It includes
> support for changing the baud rate. The command to change the baud rate is
> taken from the user manual UM11483 Rev. 9 in section 7 (Bring-up of Bluetooth
> interfaces) from NXP.
>
> v3:
>  - Use __hci_cmd_sync_status instead of __hci_cmd_sync
>
> v2:
>  - Fix the subject as pointed out by Krzysztof. Thanks!
>  - Fix indentation in marvell-bluetooth.yaml
>  - Fix compiler warning for kernel builds without CONFIG_OF enabled
>
> Stefan Eichenberger (5):
>   dt-bindings: bluetooth: marvell: add 88W8997
>   dt-bindings: bluetooth: marvell: add max-speed property
>   Bluetooth: hci_mrvl: use maybe_unused macro for device tree ids
>   Bluetooth: hci_mrvl: Add serdev support for 88W8997
>   arm64: dts: imx8mp-verdin: add 88W8997 serdev to uart4
>
>  .../bindings/net/marvell-bluetooth.yaml       | 20 ++++-
>  .../dts/freescale/imx8mp-verdin-wifi.dtsi     |  5 ++
>  drivers/bluetooth/hci_mrvl.c                  | 90 ++++++++++++++++---
>  3 files changed, 104 insertions(+), 11 deletions(-)
>
> --
> 2.25.1

There seems to be missing one patch 5/5:

https://patchwork.kernel.org/project/bluetooth/list/?series=721269

Other than that the Bluetooth parts seem fine, and perhaps can be
merged if the patch above is not really required.


-- 
Luiz Augusto von Dentz