From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v5 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Thu, 23 Feb 2023 16:06:12 +0530
Message-Id: <20230223103614.4137309-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230223103614.4137309-1-neeraj.sanjaykale@nxp.com>
References: <20230223103614.4137309-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ps8ZgAOB+7QxngjJwq1dNM13SL9WqpLRuolKboXN78eumUY7ONSimqgVVyyF?=
 =?us-ascii?Q?cTF5G3sz/NkwfTpukDVVsa5Y/0af7gvPU2VOKsWVGvLiiry/mY53z/AxwMg/?=
 =?us-ascii?Q?hFKMRemspJDribW8fcsy1f+2xltbfltL+0CZuR7ioV2PJ2DjLDKFLDymaxDQ?=
 =?us-ascii?Q?8Ghk3DFKYYqwxbmB2tSDHuDNwL5Om29kH+qdg+0YD3hPUh75P5c4DQevDlyA?=
 =?us-ascii?Q?/aszowv+6Y7fkmBcnPpciqarJg952kbXTVkYWjSW2JnlUnjcEMUPN5Rpnf0E?=
 =?us-ascii?Q?b2S+FEgvHAD5laE3WEk4xOdTGzHLHLBan1UWNjYivFPQEJktDbcrbnuKh+kj?=
 =?us-ascii?Q?CEnOVKMUV9nUvP22hYESigO+LX/hHK2Qhv8QBk2N97ey+TkLfTgH5fCK4pLd?=
 =?us-ascii?Q?L48hLwSkndsrgdsmVNlawTsFR/AwrWp8dELSERRa0O3q1nsmkbiv/0TCMfux?=
 =?us-ascii?Q?cKKS4PJNATGAmMvPB/CJX00pPPQ5jQGTQlcjZ1ISsGLXMeVQk1QEaFqjqW4j?=
 =?us-ascii?Q?BNY3jBmdQWgO5uJ9DL4s/ze21z4vg80V+AZHljXQUBK6s3nzASE04o54P9rl?=
 =?us-ascii?Q?VlUy8J7VJ9V5vrMheprra8eQCbonO09xaCx31xK1d7oL4vK78ugzH1HANWSJ?=
 =?us-ascii?Q?rby0fUSaVUZ40wg4ArWUNgrglVOGLjouRUNF1/tZ5QbDcG1zXcN89KXfW9WH?=
 =?us-ascii?Q?b0yV6BcHL3sQ81GdDRQKLmS4FEDQa7YmYW38xabh7fKHngBhF2QYXCqUrBB7?=
 =?us-ascii?Q?rJTXeb7kjOQp4qPsQ5SiZe9Di9fdZcaJHW5yYVJX1jI/8iSYHCrHlGeGNs+w?=
 =?us-ascii?Q?cjoTK/S1q4j2MWyTp9I1wfRivx4+32SzhnQe6AJc3Gw8o2OqkWsxrnIKo5Jy?=
 =?us-ascii?Q?nQ9/jy9se9xdoON+r+xlG6D+QoBpDkdQm2q3LjpdI+OfpRr1gbicZ/vv84vy?=
 =?us-ascii?Q?4c3XKhKEVKJmI63hrGcCDHXsyJogAT9HKF/iTISrFHdD6HAPvvlhHVqKjt8L?=
 =?us-ascii?Q?hHDqX30CSw4lCzurIhDy5CyaTsCOWEczICY6j9g6WrsKssXbFMhQbJwmJsKH?=
 =?us-ascii?Q?pxyNYgqdrh5lENFPRFbkxpvcalSMRhjdPzJZRDPLJWGiaG+BQ1bDKR1sG++e?=
 =?us-ascii?Q?fwI33kJtfnt+mWfgt3c2EWO+ElDmkuoXsn8utrsqobo3vDLYkCpufjdF0n/0?=
 =?us-ascii?Q?440vSd1hxrTVFv7mBCGTE8KZvLUcVblEYJuHaIDSf5JwChYvoNyyjzo1ww8D?=
 =?us-ascii?Q?x5GGzK2Ypp4q2kZnfWuk1P5SeLuK2ql8UTgzRV6uFioXTStmy78zpkaf0DCJ?=
 =?us-ascii?Q?lvfq8MupF3LZjzGG4p5jXXXuu3S1iK0mK/XNarM9CBcU3F60e/1lnT1OfO3m?=
 =?us-ascii?Q?Yg6AJtGCQkSD7XRjFbYpwHDjs9xaylz6ZoqaBJB/CeDaLcE7nGJp8InIo2nT?=
 =?us-ascii?Q?8XtDC9O+gqsagYNJf7nfAePLIN070UGg9ydXe4JuGn9A4hiIDvvEqR3UMPpy?=
 =?us-ascii?Q?gxhdF3sXTcnL0avbXGUvDC+EBP8r1xzrjU35cJ/MggdH+sfjdieTXNbWiFnk?=
 =?us-ascii?Q?/d/YoPz7LZj4Luub39x40L18fqL7dG0kx0ss7FotP2dCZs04rhylQjpSKKfB?=
 =?us-ascii?Q?Yw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37316ca0-07a3-4ca0-3197-08db1589e537
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 10:37:00.9609
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T0u2knA3d3bMLyQqlCCfqyhRFOgGkFbz7UJL448UTh0MoFAmm/Av1hkleJjohi/qrbCzLIKuFMu342pZWLAjUzYItIknNYia+naFnu4QhHY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8195
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. (Greg KH)
v4: Add a check for SERPORT_ACTIVE flag before asserting break over
UART-TX.
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 17 +++++++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 34 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..f2fdd6264e5d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..be6044fc0e6d 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,22 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!test_bit(SERPORT_ACTIVE, &serport->flags))
+		return -EOPNOTSUPP;
+
+	tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +275,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1