From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
        "hdanton@sina.com" <hdanton@sina.com>,
        "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>
Subject: Re: [PATCH v5] Bluetooth: NXP: Add protocol support for NXP Bluetooth
 chipsets
Thread-Topic: [PATCH v5] Bluetooth: NXP: Add protocol support for NXP
 Bluetooth chipsets
Thread-Index: AQHZR47WI5L9LPEda0u8Xg7hQHxHDg==
Date:   Thu, 23 Feb 2023 13:57:58 +0000
Message-ID: <AM9PR04MB8603BD23BC407407316E928AE7AB9@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20230223103614.4137309-1-neeraj.sanjaykale@nxp.com>
 <20230223103614.4137309-4-neeraj.sanjaykale@nxp.com>
 <Y/dEa6UJ2pXWsyOV@kroah.com>
In-Reply-To: <Y/dEa6UJ2pXWsyOV@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Kli9HR7Me3hXk2y7rq3/BGwwPJyrrQJtg9z1ef+h0QaEV5nAvJkEg3QfevOk?=
 =?us-ascii?Q?AG0XVi52NljNepaAc9ux5FSjd+oW+YmHeWtUEnyMSNWNTXjhHCFVjxCNZWj6?=
 =?us-ascii?Q?aicLo48L1HQEJbR8HRGMkvDXzvg2Bm7a6eCJ967W8PftyRBb6PlTPAAPwhlp?=
 =?us-ascii?Q?euDN21OEPbYY0h1xLpPh6B+sc5MqwKxgzEH6PuzBilzwGPu7140PUylgr+6F?=
 =?us-ascii?Q?zAtKpmon456FBSZbQFimTfL2lTXZUzr9Ai3PgjuzKZtkyw96NdloHT0R60MC?=
 =?us-ascii?Q?MVh6yRjJtKvcpBAgxgHo4a/ctGMqNLINIgAWayRXD0W1W8dkLjoLZmKc3nhs?=
 =?us-ascii?Q?1IK4+7dibuJihDAM4cAbO/xeeK7S+1zodx+U7hL+CPQa1veEggoXU52QQAXe?=
 =?us-ascii?Q?U8+Dt6Db+bcT+bL149U/VCSliCx0xMIyiZz6baNtNxK17edAaBZfcSw1mrcR?=
 =?us-ascii?Q?u+6DugCNnvE9Z559yqMJJcn+GZvsKyhz85n+1U2h5OJjsGWpHRnf9F4m6G69?=
 =?us-ascii?Q?oBl+PQGnC7WDz42QIhOBJBL1PRpTdqSCOt0bmgmhsmQB3i9we0Fb+DlGksfP?=
 =?us-ascii?Q?aylMi56JCMdIn0IhwQn1w/F8rk32BVB5Pw0qA24mGxHNHpN3nxROkmXr6Cmq?=
 =?us-ascii?Q?BR2tlgXoXcphTI++YaS/JcWjpjVE6qlg2bguU/FC6KuvkmfxcWbdJyp5+CVW?=
 =?us-ascii?Q?XzNZs4Juo8ieXRk+egWA4s61wCZG6er0j61qEuE5U33h4b7cjglWfuw6X+oj?=
 =?us-ascii?Q?RruSadQfTPZGcTgc2cp6rEMnUbLF5O6P3wXaHyHrFcd2RB8UCh2DgC/DOOXZ?=
 =?us-ascii?Q?PRQhIAXNdKjM6XhAnBPs6g27ZD4yoTJ4MgYoxMQfG/jjokvc4L4TplSUs08s?=
 =?us-ascii?Q?wLFYQcA0EnozFA0njNrJ+CHAq19CK4+KYtgteCkqqR6uPLVqC1/8v4GNmeTI?=
 =?us-ascii?Q?q9IAa9RgI5amnMfBqZh2cuqSS0oj/wvBMd8qxmqBYd9XINdeJ5bq5QKSZzJ8?=
 =?us-ascii?Q?BToPHxZQSoDtTTJXf3cRl8yaS5P/GjiUCuHXSEjTq6ajveUFsIi4v8aNP3w0?=
 =?us-ascii?Q?wsiy2DoE0movHgTKlaIyAPXuVTtzFg/i0UdoLFwBfbdgrIflnSBTQSMo1pxZ?=
 =?us-ascii?Q?BubUsewPcxFHQLHZEvFXtjQFGfonIw5Qo5EqZ6NuuNny/dNZaEwdEfIkHJrP?=
 =?us-ascii?Q?XyHadyVWMuyff5Kb/Db6Fvg99bHTHgPmX+stDA36GCZM8fWpc2Ma6WsHpM1v?=
 =?us-ascii?Q?roePdoMRTmPKwIKEQXVCPwpssMtkVqi8yw7RjO8I+3/qYIRLCig/zyMh03bz?=
 =?us-ascii?Q?z7Js6FDZv21VMBVFrsRaTQ4iRFh5YDB6e0+4RD32qfNexg8pe3KoY2V5Abmx?=
 =?us-ascii?Q?6L53sGgcig2+Dobi9xyhZ6OT05a17swNauiTiW388FuKoVeIKOiDzbQTLtuo?=
 =?us-ascii?Q?ADD5rIF/YuE2yPa0ML9qnlcXDH4bzXIuE9NESwfAg//JC9oclNmgyIAbHOyQ?=
 =?us-ascii?Q?frBjxwSrNFP1rcBu7lqjd92hXMjdaKtndlgmpQ1Oyu5ld5BZSDuDw0kmjCEN?=
 =?us-ascii?Q?KcsOpyALINkosfwQiJtuLFyrpiH4kbJRG695UzvkdaX/1Qouz9otbsozW/jp?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5daf4104-8ae1-4e5d-d038-08db15a5f883
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 13:57:58.5763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SHs/00SSLmMgM/kDEOx/oaFWR4mc/E1XKGMiBeKLsNXLtj9AohO6oklERuY9/Wn37l8gKIf2ENwvQP2lEP9PodcMUouySl6QgwUiJMjQ6TE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8973
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Greg,

Thank you for your feedback.

>=20
> > +
> > +static int init_baudrate =3D 115200;
>=20
> and neither will this, as you need to support multiple devices in the sys=
tem,
> your driver should never be only able to work with one device.
> Please make these device-specific things, not the same for the whole driv=
er.
>=20

I am using this init_baudrate as a module parameter
static int init_baudrate =3D 115200;
module_param(init_baudrate, int, 0444);
MODULE_PARM_DESC(init_baudrate, "host baudrate after FW download: default=
=3D115200");

We need this parameter configurable since different chip module vendors usi=
ng the same NXP chipset, configure these chips differently.
For example, module vendor A distributes his modules based on NXP 88w8987 c=
hips with a different configuration compared to module vendor B (based on N=
XP 88w8987), and the init_baudrate is one of the important distinctions bet=
ween them.
If we are able to keep this init_baudrate configurable, while compiling btn=
xpuart.ko as module, we will be able to support such baudrate variations.
Please let me know your thoughts on this.

Thanks,
Neeraj