Date:   Mon, 6 Mar 2023 13:44:16 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Archie Pusaka <apusaka@google.com>
Cc:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
        Archie Pusaka <apusaka@chromium.org>,
        Abhishek Pandit-Subedi <abhishekpandit@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_sync: Don't wait peer's reply when
 powering off
Message-ID: <ZAXgIJcaUUqKwrO8@corigine.com>
References: <20230306170628.1.I8d0612b2968dd4740a4ceaf42f329fb59d5b9324@changeid>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230306170628.1.I8d0612b2968dd4740a4ceaf42f329fb59d5b9324@changeid>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kY1+JyfffPAKOKJi5HkYCViMc6/gfoJjyq49mRh7ULGWXM1L+Xwa6nN9Zxs6?=
 =?us-ascii?Q?B98oSuruaE0misMOxDzKsiPOFhpiBhwLC09qhKgrtVxk171C1d9vsNIKxI7V?=
 =?us-ascii?Q?pQNttNwIlZ0gSVOT24/blAgGzXQC0AgHy89cAfhrilWAPtUd8Xe6JApheFow?=
 =?us-ascii?Q?hrv8NRAK/ltii2yOBEKAVVSzyWq/LAkhkPl/BAvtB1pCvZCJJCc4ru5UaUPF?=
 =?us-ascii?Q?Z9WiHFh7tZLQJvQHHuEZvg4I7vZEEAWyoxAAckPIJkZjAcXnoN+TYmHrmOUj?=
 =?us-ascii?Q?1qJQrebBgPLIix6347raEK2pgDZd25ChoZTP+yZOC2H8aQhY9SwuQTu90A4z?=
 =?us-ascii?Q?lQnoxtKSzLf49C75PTsmrYhxcRdKd9AV7xfjYlXbM6CeBKcFZ1jb4mBnYjfv?=
 =?us-ascii?Q?q8fAL8mIXgKlzF+9wI/JgnjBtigoYIXuMhDsC81xktf/FyRkhZH7LiKsqN1z?=
 =?us-ascii?Q?XVqJwjR+0nxNEYP0wkFzN4iUQTEKW0YbT0Zcic+ONsNkxAlMPATfDBmxqCph?=
 =?us-ascii?Q?z9TeTWvOqYqdHFc0Fce6q8QKzWM2l1sgaKUUP3HJlLHChwfACLXpKPFdE0hB?=
 =?us-ascii?Q?msmdm67bcLEMJMHSQin3AtslhaQnLIqVlfjBeV9XYv0jVij/ETuoz0AujWh+?=
 =?us-ascii?Q?817amjiAKTIJOaIvTxszaQqbR/1xUg4GW0SVZ9InSi+WvcrWYco/1qZ6VbSD?=
 =?us-ascii?Q?t1rIkplxdr3Sxkj+JofO1FgjS2KPFenqmUSsFcWzjuBxF49VdEZfWluVe2wr?=
 =?us-ascii?Q?HpHizlkJYZ8a1H74Gvr32Tyco9Hus9f52gaFB4PxuDK0Oc3uQTBiQ1nGYn8B?=
 =?us-ascii?Q?6P0sFdS0VQnCXlGssyjkp9MMZGU76YgBAQRjSMRdX0m/0nPpyq3LUoP3r7vj?=
 =?us-ascii?Q?+pLKFIJMMIghVEq6sTe5oypumpsHeyKxVSsECr7i6huyJg0IkMnx2mG9OLGv?=
 =?us-ascii?Q?3yXscqHeIfya5uDu+tAj8BqQ1jxPGY4Djwyk06vRRDe5a9FJ+qpdANUIDr0b?=
 =?us-ascii?Q?jDBYixeYC5DH5NbUDAFvXf8c0+xR0TPf0udmNxrMV59h/J9oPe5SmWOTHpqX?=
 =?us-ascii?Q?DQ3oxNbhldHdsg+Adxrsr4kriIf3cXVLywevDxuY3OIjZPJPI+LrhoI+V4O1?=
 =?us-ascii?Q?Ib18BSf43AXIKIwHrioB/+sfEmvH6cQIf1eIi9uIcqmB7Fqm4HcHdwqhMPFF?=
 =?us-ascii?Q?tWxFFGxvYX7+u+krg7nMoQnJ3MmiLTQDRcJHwUAMiSu4rlZPRAz6IO/DHGFD?=
 =?us-ascii?Q?3Or0A4BFaTT78rbRZTP2Li3LGauZIQCcZ3lcO2v4Ol17y9lfHE9VDCXhWYnV?=
 =?us-ascii?Q?JNChnQhnSIPiyUBaUbP0SHoqvL109kllJjvRf9HfTWwSu2FMTuUEc4siJEJh?=
 =?us-ascii?Q?Ec2fjd6Q/78ps+aiRzq11TWba0d4ydi4gkkF+Eg02Wr0/UEULh3+d62lslf6?=
 =?us-ascii?Q?IN1han+WnNOhiZxZ9volEnTFSM3nf2M7KuSzYTLxOi25UW06YjqQY+4i81z3?=
 =?us-ascii?Q?huOcUM3QsG1Kd0TX/uwLUPFqdKG96ZY3g6TMEe4THDhY+ECDy40KgADQXsMK?=
 =?us-ascii?Q?+Re/tAmovUYnSzhAwM+t/Z9htGunsr9rcp9xRTlBciOp11MOhLbJhX13mg6R?=
 =?us-ascii?Q?oHYtm/SObvBDClfFXfSdttFbwFmp3kG17nKV5JD08w9kGVKeZ44L2iGcnAy4?=
 =?us-ascii?Q?SglUXA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d80e4b5-39c6-45a4-3a3a-08db1e4083ba
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 12:44:24.1826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ydxoj9ueNrmxbGBqqRjiVwUg6gjZNmXsTQFD786jKHoafXKiOCbcdOgG5uslSF2YbtfE3Bw/iuSTs05qVCM2Ybb6+vIQeFGPt75/bQg40zo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3754
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Mon, Mar 06, 2023 at 05:07:07PM +0800, Archie Pusaka wrote:
> From: Archie Pusaka <apusaka@chromium.org>
> 
> Currently, when we initiate disconnection, we will wait for the peer's
> reply unless when we are suspending, where we fire and forget the
> disconnect request.
> 
> A similar case is when adapter is powering off. However, we still wait
> for the peer's reply in this case. Therefore, if the peer is
> unresponsive, the command will time out and the power off sequence
> will fail, causing "bluetooth powered on by itself" to users.
> 
> This patch makes the host doesn't wait for the peer's reply when the
> disconnection reason is powering off.
> 
> Signed-off-by: Archie Pusaka <apusaka@chromium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>