From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v7 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Mon,  6 Mar 2023 22:35:23 +0530
Message-Id: <20230306170525.3732605-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230306170525.3732605-1-neeraj.sanjaykale@nxp.com>
References: <20230306170525.3732605-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S+snMWRqyGZwadQ3sotdnw1Pl4Gzg/O0kvQ310ZQdu82qe/eYRxRjp+ISPxo?=
 =?us-ascii?Q?eticl2y0rzWNDlOj5zkS2uyxg2+VcwR/QFnOMgkjbKIqMh5jGoCnLK0JRsqz?=
 =?us-ascii?Q?HmzN3vGfeVHoullUdDRUzIHbFSUvRSPxMd//UGNNqn1Whjn7dWNDTXNfEGfb?=
 =?us-ascii?Q?CcSfLjO/btFJMfLHw8re+5x8g8h/VtZ58OH2iOzXWHVnRfk9IHkNRucOKPA/?=
 =?us-ascii?Q?slQgAQDCP+BL/fvmHKpNpBvLtadQvm1xZ+BnU1WiLARWvXYXbm91TyD16Tt3?=
 =?us-ascii?Q?0okbHBTYXgqXFWn64pux4+84FBa2nhyTk8jk2ypcQyYIm37wenY+I2XgeNbx?=
 =?us-ascii?Q?elxdgqHZHsW7PAjFxmxO8L+9fxJ19OpWFAILyVyc9zVn5o6+R+AOOPNB59dm?=
 =?us-ascii?Q?xcuZa1oDRAckL6Fop61ikyfoGEm1Kj0F0hhhv8KOOHUa16mDoUQdk5O74w4V?=
 =?us-ascii?Q?K+uhfBLu/+avK5FGgRgRSqSb0RwbsSjuvqlHyXulxXMMhdmQOgnGof8TWiyO?=
 =?us-ascii?Q?n/wyiPJF0BzDLqN4PX/X7kIHvtrSM79PcVBVZR9kWLEqgndJFx1RDV77nt7G?=
 =?us-ascii?Q?gBy5W9cvxNIfqYWIBGi/BP7jRBHIIermWQ8PAgAHoxrMQeL+GZVzcUT6vc2Z?=
 =?us-ascii?Q?2JeGrNaBPlJlW+SPiFGwjYxPvhVUaHTsXyhfNLmh0gpAKHhSLRFyN4USk5dC?=
 =?us-ascii?Q?IY2nQIi8dMuGvxM1dnhiT7oXPWRMpUnbeO3dPeuWDuR8agdA05Bz9lo/su0S?=
 =?us-ascii?Q?IbermFQbcedKkUgfPonxWVqzxlZVCe5fyaff2obslCcN4kAYbnmjVRaiba9u?=
 =?us-ascii?Q?WDR9prZtsqMjjTO+nZ2gyGQlYYXwEL+ca4DzktvM+13vbp+galxWqHJHfdtg?=
 =?us-ascii?Q?1+h2QT8+UT1I1jjAhDNpMGbwMWQxs5QR7XnIa1dstdznA290Z2G/pmVbv1Rb?=
 =?us-ascii?Q?cSgNcCekqULsfrBuyMI1YRr7fkHVaCQv30Z8gHI7u2/ePoFKqJ7qYiExYbpM?=
 =?us-ascii?Q?adhodIPhmFb2w8ruqIgw9rAxSbB/cOj0K8O95p5lUdXWCA3gyqsxYN/kJMvx?=
 =?us-ascii?Q?0pb1D0QgK8ki5u5v7nykypSycqoDpLdWs8xubvGMKFTjT2keCsiOcFwdvHYx?=
 =?us-ascii?Q?UQDYDRHgsgkdi2gtB46W2inST2VWhOcPdtIdzAYF5+M7F7GO/Ujbp4G4SbEa?=
 =?us-ascii?Q?ASuHDFuEPyl7g3ayQRWFD6tXbtAZ+elrADDOEaHVyHq4w/1W/3z9KdWZMgal?=
 =?us-ascii?Q?+34lq3o3R12hgAy9UJbZCPeXTR09VQ5Rum7G7uP+wSEEov1sM5Nm7zyjxuHw?=
 =?us-ascii?Q?vu5Us1OP12gPP4cZbHeCdwGpYuvmMYcVnMwohp0RiaGDh5fcGme9x5ZjYnRI?=
 =?us-ascii?Q?Vs5ybtfzASDxD+m/y4cPpCAa4UFaevRQmIGMORYc4rEQMqt4t4zOA1aDSj0f?=
 =?us-ascii?Q?twdGIH+ucs83hkTxEJVwMyhYRwVVnu3P6v0YQDf5EAoS7KM+ZsCWZ0TCK5Gd?=
 =?us-ascii?Q?T/HLa0z97Jqu5m5JscmB1jzPblNn+FzItwfAe9e+dQgSqXfINdvby2DFTNrq?=
 =?us-ascii?Q?+odgNC3Taiaa7D2kXLnQkB6grjQfLbuclACPVL0azgo3ZnBiNaswxxMFY0QN?=
 =?us-ascii?Q?tw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a7894ad-8c04-4664-1476-08db1e651492
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 17:06:09.0736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mtXOqWnTDaV959+6F8SWCgWwa+f2pvDY0npJfidEjSsYWCOwoehpDIsE/MqFZIRM//jsHR1H5u8L5u5QS6SREUYTfv2Y9m2xOR40gGXxbxs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8556
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. (Greg KH)
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..f2fdd6264e5d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..9888673744af 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,17 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1