From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v8 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Fri, 10 Mar 2023 23:49:19 +0530
Message-Id: <20230310181921.1437890-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230310181921.1437890-1-neeraj.sanjaykale@nxp.com>
References: <20230310181921.1437890-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vTFeAV2uz3Qsp67YdsG8bPDHZpATSEGt93YheGDThYLCgpsyZ4PWI1Rp2iSB?=
 =?us-ascii?Q?1vArrgGo1J0BqJTtJAV/d4qO0YhZnJOeKFIWfGbUipGRQgTpgzFjO5q+EhCK?=
 =?us-ascii?Q?8915CZyBOn+JP5+w6gBvRh8EwdhBxwbZqHR0H57s8gNiwwFfGmKJPKcIClEN?=
 =?us-ascii?Q?CxpgC5Em7oFWqWT4lr+/UqkRr0sfW9cIGis0OFU1xO+RoI734MFc6mM8LYWy?=
 =?us-ascii?Q?9ar3AkV03elltHri7eBqaq/5yGs+LM3rdKZzJvV2zi0guWqdT5FnggS2r9Te?=
 =?us-ascii?Q?uStzk1zAeYCtko8uUWhDmeJqIsfphUuFVNDWy0na59zYjCrSC4DETIXLGdQJ?=
 =?us-ascii?Q?YBcSWkletrKgkeww6qwWXcbqd89U0hbfl2hKVMf+Flrvz/oYKW9TMUe9yUyn?=
 =?us-ascii?Q?P+H6wrNQYqCOZFsBnlIvGrqefO2i94oKgG9pQ1FIUqhf4MEqiJbVTTwEyXh+?=
 =?us-ascii?Q?gXKOXuUQXeKEhD8csyRyWIeg16T2U86jn/0wBzjiFzfSoQ/y3zcQTkeR9PKH?=
 =?us-ascii?Q?oPmk3GkFeGp5u14Xh6NfTXiIEnMJZ9vmV5XJqV8HJipLBSLKAYlX7I3hz9FX?=
 =?us-ascii?Q?aCb6TArbZ8A2eqASRuPpZOzgCjFFHhJAWxpjecB9tj1Tj1NvUfROue9ZUTH0?=
 =?us-ascii?Q?+dmOhP3sjWt/hZg4SwNE1LIcHgKuL1uDlo234LtoxzWAMpgGp6xOhFbVeYjl?=
 =?us-ascii?Q?+Gsz7VDTpeXlFPQAAtPU9dRLuFcbawxbu2BSdVAlI2uAeYqb0Fr+haWAkx9W?=
 =?us-ascii?Q?0VgRNXrsMp6ifP2a3SbEsrlb77MH0EJ0dSpEqmzSfjWtBTohOtXa3rqxvxGY?=
 =?us-ascii?Q?LhLnWUCuiRog8QYzTg9htIbbUWbpu8h8Ivv1ztRiTg8shyc72bXkJ9kJ2Yxh?=
 =?us-ascii?Q?WaOMLw86uEiYkyN/vac2pQTkUAjEu75JGhSiM4LMYHtbUHl55bXDtZirQN2s?=
 =?us-ascii?Q?XH1z3UpoEP1Na3OOJDmkb/w59GYJ4XbiikXDSACgV/aGAHq9+YfkyF8yE4Il?=
 =?us-ascii?Q?WJVBC0jFCFVIhY4nl+OiDimrrt82wC4Ocihv0m0SZiQwP8MAkKuHm7zfUj4B?=
 =?us-ascii?Q?9TiWMx9/KxkTMo5tu+2tikfgPxK0PYALJ7xrRVAXru4EhdUNihZLEDe+XRPT?=
 =?us-ascii?Q?zPpNuX2cgm9UZMoWN3K1/uqYJ9GTqPpoXqofLfaVCtaxibF/p7ZiQB3GpZnl?=
 =?us-ascii?Q?vAQFU1FMTz2IMWz8bkQQO6A7uhn4g+vlQC/OgObSrqaexPebCYWvcEWYuL0C?=
 =?us-ascii?Q?2RlSAmDz9DX7cf2H2wmFhPPtSR7K186WNFLEqLprAhbHMmJqPVXkXgu331Q9?=
 =?us-ascii?Q?o909bn4h1iE9oiwVOxMaaNzf+F2JZtg/bx0ACke5o3mzNIWARodHHtV+SAYz?=
 =?us-ascii?Q?7e2tmaP3RpxwGrAeZbGjvThjv/cVIL17kD/WJUZeC7Rgi9nppEu++9pI2tfz?=
 =?us-ascii?Q?2g4r3+UwC7hpPjICpZc4f9f/rm4nKkCTGlA1+amRDmMSaXltOamKzPE9VdTP?=
 =?us-ascii?Q?KXzpQDO77VRKRPIhvlNOEg55Dxe/M17/2xdjO1+MLumL1b81NZWMNXAUghrF?=
 =?us-ascii?Q?WBZ2y83HaJbWS3XYmKUHJ6qiBjfNP+HZcd3Q5no+V1ItkCxHVaggfRkUpofb?=
 =?us-ascii?Q?Kw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 302b7648-666f-4580-e05e-08db21941389
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 18:20:07.2079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Igxur1sDovRVuozIQN6cirOtOOQsLfSXNOxlZSyDFRLAOeOD2edqHnkjsJtmNWw6D9pUMWPgmFRFiTi0af6U4A0AoQ5iYgmGZcO/6K4FAw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9704
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. (Greg KH)
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..f2fdd6264e5d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..9888673744af 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,17 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1