From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
        "hdanton@sina.com" <hdanton@sina.com>,
        "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>
Subject: Re: [PATCH v8 1/3] serdev: Add method to assert break signal over tty
 UART port
Thread-Topic: [PATCH v8 1/3] serdev: Add method to assert break signal over
 tty UART port
Thread-Index: AQHZVLBx4j9x7ZOdd0mla+luXOKNmA==
Date:   Sun, 12 Mar 2023 07:01:17 +0000
Message-ID: <AM9PR04MB8603EDB41582B5B816993B12E7B89@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20230310181921.1437890-1-neeraj.sanjaykale@nxp.com>
 <20230310181921.1437890-2-neeraj.sanjaykale@nxp.com>
 <ZAx1JOvjgOOYCNY9@corigine.com>
In-Reply-To: <ZAx1JOvjgOOYCNY9@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Paz+K5YIoglQWO9Pcoz+y0wrxuXB6NQS+toRaT+FXn1zySOnR1Xp1Wc/iVto?=
 =?us-ascii?Q?yqb9/LZnGEBdz+Gpt8v2d2hphLSpiFYJkSQQI2ywNLfl8CzMTtwkFN1J4BIA?=
 =?us-ascii?Q?LUN4h/vLNb0/XHFDpNGG21EtiJ3TCJh5wZI18kMDgmIDBKn6JCsIHXgAeN3C?=
 =?us-ascii?Q?QD8UKQsmap6wAP1UHVr2EU14N5fo0DHSvdDv56eV83vvFLZFB08zwdp7Qntc?=
 =?us-ascii?Q?sSM8EI+xT+IkugVqaNzQkKKrbu7LE5ZNPUed9oUqUXSdENoXUJlXHRftuZNv?=
 =?us-ascii?Q?EStnGiJWtaDPUw/JONmQDSDTepdLOw/yvIev3yqbGCtKzlijJ4DWaGo5/6AZ?=
 =?us-ascii?Q?MkiKGSk5Avla9F+R2KwK6/uMTTvap9t58t+pp6rhN/8XeAYFuVCC+Hd3Mi+t?=
 =?us-ascii?Q?LHRpw2j4JHRCyYNOCOznj61oMFlF0+ET8stF+SDquu23Mfg72N7zw0kSW6NM?=
 =?us-ascii?Q?LxHHgNzgmTc5ta729fz6a/5JAbD4MJc0UUWyJMH4on3mfv3putAH/eaOMNel?=
 =?us-ascii?Q?hEfrYTFhsLpstDzSqd8J6CmIkNr0YeerkpeGMVMsvTqZ1r/vGs6yc1tRxI1Z?=
 =?us-ascii?Q?aD0Tix52rLKljX84M9N2qt8qj7v3zuSFdkL5lAgMC+tfNtuS2Rc5UJf3Najq?=
 =?us-ascii?Q?9XZkVP/wal9ieLPPzN32DSG6xmmhFPmBHqq240yg+qMMbuiIMxLmfAsD3KWZ?=
 =?us-ascii?Q?A7E5MEJNbiF8+3VNFyA1kFRZczAeQzaJMxKeR/S/pBaUwyBUfJcx0cseXVry?=
 =?us-ascii?Q?XzT91zzJzypElPcd+vDQR1dXkpfeQI3HpwhQHDW8SYLOCgNBzwJsePWzlbGy?=
 =?us-ascii?Q?EhGv3Oq/jGdnXpu6rbBmu52AW93NaBLYYmcGcRxR/o15Yq7SHHJKIci3Nkce?=
 =?us-ascii?Q?P8DIOrKjzNJi+U1zL5MWDyn+wWIC0aonaY2h6yoLb5C2MU/xXezIabw8MOkV?=
 =?us-ascii?Q?iDl0MWkXRGnna7cCbAa9q+HU2UOT3jH5nRr/nQDG6BlN089HT6s0LX7Asu20?=
 =?us-ascii?Q?IAE6rQ5PoTxjBie1T2eGUydvPJxgHxfZut+D/pQFQwNUaXrKYRV/phJ7N4WY?=
 =?us-ascii?Q?fAfqpLUUiP55dX9WyEkJ4teyCuzAzIcd0bQtR2uOnOtM+piQG46avFrD97dQ?=
 =?us-ascii?Q?NPM/C0WaSRj64ejA/RnvZhr9dcYOhKfCQUYsMvRockdta15ck/WcvpJV51/v?=
 =?us-ascii?Q?XyfxERCByPbCBOptm4D55UfC9xF4jGnXJsEVcMvZheBRU4XT/Qmqg9N9g86k?=
 =?us-ascii?Q?nErUi63ZH6UA10m6TV2nle8MuxZCyxsDIt79HXBRJ9OiJJKI1cAKion8o+2R?=
 =?us-ascii?Q?+b8w4M15YFAegaDbGpO5APgvbl+Qh1QsJOVKCFjiYqMBzn9lbHKPFeFesKYc?=
 =?us-ascii?Q?IL9ho6+rXGa2zF+Fz2qZw4vBucZD6kVMbCPze4rYezSbsAqZzCC0f67vvU+j?=
 =?us-ascii?Q?r1EgPlxp/aeQnWYX/UFQQwh9PIhDyRA1lWKLWKIxxhKTZ0GgMdCtrK7KPxVR?=
 =?us-ascii?Q?MtFdnfOxEcnxvl8KhwqTc4w2koBbGQWd/rOLtRr+GzKuhkQ72QDFXqXKmH5y?=
 =?us-ascii?Q?Du1FvG+9L2na7GgOZkd4vAukutdHq5rFT+arTttvO+YM9iJ/jqHBadE8jAX9?=
 =?us-ascii?Q?0g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb0b2647-03f9-4d9b-b9c2-08db22c793f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2023 07:01:17.8451
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TYgDVAeu+2gvYr8f9YwLYbHDjXEjSfnO4rCjKMdQnVfBnnaZ/sKipg8iL+tDl4CckvO3F3v946FVjYj/hHoteG84N4lfNZpi682tTgTwPPA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9901
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Simon

>=20
> On Fri, Mar 10, 2023 at 11:49:19PM +0530, Neeraj Sanjay Kale wrote:
> > Adds serdev_device_break_ctl() and an implementation for ttyport.
> > This function simply calls the break_ctl in tty layer, which can
> > assert a break signal over UART-TX line, if the tty and the underlying
> > platform and UART peripheral supports this operation.
> >
> > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> > ---
> > v3: Add details to the commit message. (Greg KH)
>=20
> ...
>=20
> > diff --git a/include/linux/serdev.h b/include/linux/serdev.h index
> > 66f624fc618c..c065ef1c82f1 100644
> > --- a/include/linux/serdev.h
> > +++ b/include/linux/serdev.h
>=20
> ...
>=20
> > @@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct
> > serdev_device *serdev, int set,  {
> >       return -ENOTSUPP;
> >  }
> > +static inline int serdev_device_break_ctl(struct serdev_device
> > +*serdev, int break_state) {
> > +     return -EOPNOTSUPP;
>=20
> Is the use of -EOPNOTSUPP intentional here?
> I see -ENOTSUPP is used elsewhere in this file.
I was suggested to use - EOPNOTSUPP instead of - ENOTSUPP by the check patc=
h scripts and by Leon Romanovsky.
https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440=
-2-neeraj.sanjaykale@nxp.com/

ENOTSUPP is not a standard error code and should be avoided in new patches.
See: https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/

>=20
> > +}
> >  static inline int serdev_device_write(struct serdev_device *sdev, cons=
t
> unsigned char *buf,
> >                                     size_t count, unsigned long
> > timeout)  {
> > --
> > 2.34.1
> >

Thanks,
Neeraj