Date:   Sun, 12 Mar 2023 20:12:27 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
        "hdanton@sina.com" <hdanton@sina.com>,
        "ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>
Subject: Re: [PATCH v8 1/3] serdev: Add method to assert break signal over
 tty UART port
Message-ID: <ZA4kG1gG2qoEGZLK@corigine.com>
References: <20230310181921.1437890-1-neeraj.sanjaykale@nxp.com>
 <20230310181921.1437890-2-neeraj.sanjaykale@nxp.com>
 <ZAx1JOvjgOOYCNY9@corigine.com>
 <AM9PR04MB8603EDB41582B5B816993B12E7B89@AM9PR04MB8603.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM9PR04MB8603EDB41582B5B816993B12E7B89@AM9PR04MB8603.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wd/nhwDOENbx9Avb/zOT/Zc9OpcQzaaZHOzgjdir6zAlrWm5x8IvsXyruZIj?=
 =?us-ascii?Q?I2e1/S5OqagPHY7EabLmP3TTSElSluAvu0tEkCPXnP2vCysEQOmE3dt+KrkC?=
 =?us-ascii?Q?3mweETVAUfi3vvF8lNq8Fcgrhh6iAzrZEWS9Xf+EHcyd/IeaC2RvGaNm/yi3?=
 =?us-ascii?Q?lVLbycfBwVt64KuvavMnfmqpx0ImIwIFc5c7IUrD0KfLavdw2mkPDp+DSLJ6?=
 =?us-ascii?Q?su5ozRZzHUtLHGE5VQXUh28Y0q+89SYgxtjnrjQqAou3w6WMjFWeJQAjw0Pc?=
 =?us-ascii?Q?Xr5PjBlq/8ukZp4LsgZOKSpb5URHZAfLm6ktEYy2hUm55JjqBjq2KuINP8jq?=
 =?us-ascii?Q?kDcjI+JNmoSmzMQqgU88tpZuDJyRZIpoEdQrKW+adUpS4agFCFYqZ9UstHkd?=
 =?us-ascii?Q?yvE51p7NsaZio5FlKZmIROAqhB8a0T4NLNDqSCwh61WJsdBw/CzpWYTorQKM?=
 =?us-ascii?Q?YDtg0YU4B/+6Yus36d0bXG5Pw4q/UK9XIBgw/A4GTB1m5TQPTPf72DV09rvh?=
 =?us-ascii?Q?bA1pN6/PPZjwynZH3JfNdMbOmP+e6HlC/KNZOhc8HaFgXF+TIr6e4ax+hF26?=
 =?us-ascii?Q?duydL86CQBWiaD8zamhV+DPscUSwANGw5B/5uiaaGttms2TymTQNP1dxc8Wt?=
 =?us-ascii?Q?WI1WiAS0Kn/Edgb+Ujjcf98JvMOXshSolb/TlRvX2P6VySfpulHYLnHekSzA?=
 =?us-ascii?Q?e+bCwm7IzeimApLD0BnsWXlJ5iu6Q7VIYQX1Ds6MP1jX6yGkpL9OzqaTF+Nq?=
 =?us-ascii?Q?Y7/lxI2N2O084ItBGPW2wi5ELHTUyslcCYKcsuj9LHYVn7KeLYLloV57f6XA?=
 =?us-ascii?Q?Ij1apuc36Y0meqfMdQyfCYLASxfCUKUvPT/zjQDDTN19SeABo3w7DoHGbykD?=
 =?us-ascii?Q?qOAr4oD1PLhmBtInw8/hdfS1GhEqiWTtnz8V0jlz9XaPh35zHh0eMD0TgRPI?=
 =?us-ascii?Q?ClQkrfMW30Z+U5LIPUJm862HmWiMqSCA40uu1vLPzuzvSPlA93tRq8fkbRvd?=
 =?us-ascii?Q?ot5ZE9ka4JmsBzMuyHt4g0JxMj8Ywl3IL7lTJ5aljUwSqpmL44E3mfkjHgtj?=
 =?us-ascii?Q?fA2Cru6V6f03oL/NLSuR9wCtwFJpIUPj8gp5rObP978qScOEQHuBzcST38QM?=
 =?us-ascii?Q?HkyGvOlxldZUgayn/XxO74VXTiitCPEtLi439bVk/yN3XVei55Yl//4E1k3e?=
 =?us-ascii?Q?XXU2LINvuoUWJONhYQsrvv+vI/07cASWaK1NobEkk8reiphtk5sWFu7cye5H?=
 =?us-ascii?Q?8iA1IXSxi4GdWbZ8+YJwyJPVfvPLZ6vwfgSQh2h9aGTz/GrHpAkpe+hUOSjL?=
 =?us-ascii?Q?k0eBxzKofK583W8XTjEBW98xL+eXnfkQWbKF7IgjZGUtebIm0ePniL9PVrqA?=
 =?us-ascii?Q?iGbzuvEdMXkS80hwzCpxNpdzz/Cwjnxl1sb72L59saJLcRpetYONEnkAS9fX?=
 =?us-ascii?Q?gyZ1BTSqZPvXNbQETXBmgIM2811PseRhfTwhf1Z22pbJN48itMbsTyL8jKcR?=
 =?us-ascii?Q?p+EuRDioFi1CpNeDlf0XMwc00GVEGhkhjXf9o5RGo42iciUJ27b8fmW/5mKX?=
 =?us-ascii?Q?2S/cTx/h97Ea0sbw3kvD66blbA/ljiTzWzwArXqThqeWv13z3p9grnYCxI/Z?=
 =?us-ascii?Q?fe/jUmgShcFqBC/Gv38fz7BmB74gEOBHI5F53Y0ZTinT7a1skJ+apFmVMxP2?=
 =?us-ascii?Q?WPqAfA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dae4faed-9f6e-454d-3504-08db232dbe28
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2023 19:12:37.6831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dxbe8AFEHRowhE8kLHC4iRoiXfOT3dQwGEVfq91oR/OzOISMkvSH+8XHJVDWdP5si3FEMx2vD4D0uT2S4NAYtm63jrvEOG7mDGxpIjRbl9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5719
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Sun, Mar 12, 2023 at 07:01:17AM +0000, Neeraj sanjay kale wrote:
> Hi Simon
> 
> > 
> > On Fri, Mar 10, 2023 at 11:49:19PM +0530, Neeraj Sanjay Kale wrote:
> > > Adds serdev_device_break_ctl() and an implementation for ttyport.
> > > This function simply calls the break_ctl in tty layer, which can
> > > assert a break signal over UART-TX line, if the tty and the underlying
> > > platform and UART peripheral supports this operation.
> > >
> > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> > > ---
> > > v3: Add details to the commit message. (Greg KH)
> > 
> > ...
> > 
> > > diff --git a/include/linux/serdev.h b/include/linux/serdev.h index
> > > 66f624fc618c..c065ef1c82f1 100644
> > > --- a/include/linux/serdev.h
> > > +++ b/include/linux/serdev.h
> > 
> > ...
> > 
> > > @@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct
> > > serdev_device *serdev, int set,  {
> > >       return -ENOTSUPP;
> > >  }
> > > +static inline int serdev_device_break_ctl(struct serdev_device
> > > +*serdev, int break_state) {
> > > +     return -EOPNOTSUPP;
> > 
> > Is the use of -EOPNOTSUPP intentional here?
> > I see -ENOTSUPP is used elsewhere in this file.
> I was suggested to use - EOPNOTSUPP instead of - ENOTSUPP by the check patch scripts and by Leon Romanovsky.
> https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-2-neeraj.sanjaykale@nxp.com/
> 
> ENOTSUPP is not a standard error code and should be avoided in new patches.
> See: https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/

Thanks.

I agree that EOPNOTSUPP is preferable.
But my question is if we chose to use it in this case,
even if it is inconsistent with similar code in the same file/API.
If so, then I have no objections.