From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        "alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
        "hdanton@sina.com" <hdanton@sina.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>,
        Netdev <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Rohit Fule <rohit.fule@nxp.com>,
        Sherry Sun <sherry.sun@nxp.com>
Subject: RE: [EXT] Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support for
 NXP Bluetooth chipsets
Thread-Topic: [EXT] Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support
 for NXP Bluetooth chipsets
Thread-Index: AQHZVbWIh2ARuCjlZEWNShWbYY+/Ja74wieAgAAAxZA=
Date:   Mon, 13 Mar 2023 14:25:23 +0000
Message-ID: <AM9PR04MB8603EB5DA53821B12E049649E7B99@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20230313140924.3104691-1-neeraj.sanjaykale@nxp.com>
 <20230313140924.3104691-4-neeraj.sanjaykale@nxp.com>
 <b28d1e39-f036-c260-4452-ac1332efca0@linux.intel.com>
In-Reply-To: <b28d1e39-f036-c260-4452-ac1332efca0@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?1cm3T04U4T/HCN5RrjjQ9gqBYPqyvpXJiiy0VkKSsFFZTOdtmJhpEhRPDk?=
 =?iso-8859-1?Q?mGe3hvEKZ9zNgF92cDXxfyTBtdmg/nL3USo/EILFrXilCFf+p/nG/hVbB7?=
 =?iso-8859-1?Q?1yd6bn4Dy9907nRGy62iRi6XmvD5kT4hK7+JmoIxjFhpxsuG0AtdNBnkEo?=
 =?iso-8859-1?Q?mqO4TJCbDRa3XI3/fjyuPNTTRI8alDtDBPbWRVE6kM3qO+Kk1dwVpYSouG?=
 =?iso-8859-1?Q?eiIih13oP6DNmHBpnNy84PlmIcWkzFqVadlhA4OV9hrCh45jFrR0/H/ESY?=
 =?iso-8859-1?Q?W/FwyteLx+QArrOf5DLGA5DZJaXO4KhP8dSVjfEWkzwb85BFCzwj+aZXVD?=
 =?iso-8859-1?Q?qF54c+Iu8K4kslv05YC1A0z75rYt1mGSyl08M+ljD1RyDCdNiNZWahFTPr?=
 =?iso-8859-1?Q?tEhHwiXTV9huWmQ5Ez7H+1ho1diyMwTcJ/ey1kuoSzum99czCqCVQnGP/E?=
 =?iso-8859-1?Q?rtKXmm1ncNzA8x/HlKO+a0xlzly89A9Vf0WBi/fGQqOv/608bcszlbg8Mv?=
 =?iso-8859-1?Q?4ppuDkChHRaRvhdrVIIC6W4iUhWWMnHxIeQWcEITHC2836BPhetVB5hdOi?=
 =?iso-8859-1?Q?nDKIOyLtyr7IADASGjZ/5NJlxk4oJuyD0ALheNjAYlo6ABjt77yfX8PNSF?=
 =?iso-8859-1?Q?zujM8xkJgukpFv6oiSQyex3o0FuN8rzTdRB2vLkf3t2WLEA0dTuxaYxZCa?=
 =?iso-8859-1?Q?aaEul7ctgRvhnc0t8f8y/Nx1jZ4r9zM9Ih8TbkPfRQU4KM3QFfzsqJKww3?=
 =?iso-8859-1?Q?kMG/pz3GkRpNmtaLD+hKtjlruy4QlUEW7117S0L1d5h3/OQ2FQj4WOXfA/?=
 =?iso-8859-1?Q?f3TpUpidArUAWNgpLJ3Ebs3z2AMX08lvNJUfL3QzWbK/3mGuD9+9R6t03h?=
 =?iso-8859-1?Q?5X3dJXrRJWW530tWF2cJstOXjomSyeBonNzvK+T9JJsPyl1ObVdMRXDPgQ?=
 =?iso-8859-1?Q?X6KtCXz+V+r1EcMrzhm8Ps8/GaFWIsq5VqBwwZFgP1DuipJx/k3rT9yaK5?=
 =?iso-8859-1?Q?wM9g/Ry54oZcqsItlIhXuR+akO8OK2a11uVgWjxrA1FYygnZ/AhhfhG8Di?=
 =?iso-8859-1?Q?UYA0AKo3HLR2CnPGe0Y7U1NjnBsnkAw/ZFsNmt0CqNR807n0Rle5JcSsZ9?=
 =?iso-8859-1?Q?i68Q85loJ8FY4oJgc3/fit47xzYN8QvezCGsyHQJMA+RwBOijfwQPPlKGL?=
 =?iso-8859-1?Q?vzikIFENKyTh/zwxpDJkCXjxHVCroYSb+3dJRbXbV0V6D7oM+ckNdBFnPV?=
 =?iso-8859-1?Q?PQ+XJXI0hbpvHoGw6t78bL/tc/VuLndhmFiBQfl1aIbql58iBDLVYZAMYj?=
 =?iso-8859-1?Q?LILApHUlhsFa78m8RzHgWIgIfdk3g7UUe91cPtxvyXg91NJb1gV4XNBsO+?=
 =?iso-8859-1?Q?xxoKz2ip+5zSzNrlL8GfrTgcntSTZ5iMJylvQAj+brk8pHEuMw8+RsaC0U?=
 =?iso-8859-1?Q?7ED/PrK1QGr29lKdVtSv2bU1P8f0u/9b6YypVTRu3H8E+0TljyxEsbIkk7?=
 =?iso-8859-1?Q?VyGAYKQV3FxJvkqM1/gHjab95XECQT+AA6tdV9hYG4dK6zgSmTvKLxwe6S?=
 =?iso-8859-1?Q?UJkvLL0msLW4SOTigISmzimweWtvtr7sHfXL0h+YcIUaN/okvcgBUMGQfG?=
 =?iso-8859-1?Q?OVp6FAuFizPfejUEFGJwoX7k+N+9OTxA4j/2HqRFb80wW1MSQY8/7GlA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed41cd53-5e7c-4a9d-116c-08db23cec85d
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2023 14:25:23.4209
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PydAZNVA01r4e9LLd5G9LykMRH1RP/+39j3NTigmL2mo2b5WBh+VXp5u3NkWDjBkBXmAXLvq4xX/h3Mir2SVbQC3rCPvLEQiolKJRkoyG8w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8530
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

>=20
> Thanks, looks okay to me except this one I just noticed while preparing t=
his
> email:
>=20
> > +MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
>=20
> I don't think version numbers belong to the module description.
>=20
I was asked to remove the MODULE_VERSION("v1.0") line in my v2 patch, hence=
 kept it in the description.
https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440=
-4-neeraj.sanjaykale@nxp.com/

Please suggest me the right way to put the version string in this driver.

>=20
> Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
>=20
>=20
> --
>  i.

Thank you again for reviewing this patch. :D

-Neeraj