From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        simon.horman@corigine.com
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v11 2/4] serdev: Add method to assert break signal over tty UART port
Date:   Tue, 14 Mar 2023 21:02:11 +0530
Message-Id: <20230314153213.170045-3-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230314153213.170045-1-neeraj.sanjaykale@nxp.com>
References: <20230314153213.170045-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bIfM+lqCTdba4i2e3/9cQwMEoyy4EEVVZZkCWl2rvfFQj6Qx1BQQj0m+X2IT?=
 =?us-ascii?Q?3H01ieDlVH6F5W//a4i5t5l40cVjbZ4ibD/EOCJLS9B+HF4U5DYvPGEdLRT2?=
 =?us-ascii?Q?J5XW/8BcFPAkl2bOhr725TFPnoAjWdVYWWSvoHq6jnENp4sAMymVL5+w/P7G?=
 =?us-ascii?Q?2sWavZ25vVWi0nPKy+diCuNrgOR1IoQ8dHriS53QdMxrkjlnHCSQwPsJHn2z?=
 =?us-ascii?Q?1iJt988Gyb8m48we2D1QaeuYwCam7ikNC2y9EyT+D1PmKHC2bZJMVgtbLI/0?=
 =?us-ascii?Q?lelYUCI9OnXM+hj6AzR+tPQc2g67ol/aCjEoVR48vjLI6sX7QLnLqkD6ioMy?=
 =?us-ascii?Q?aRWqG9muPhfo3VIEAP9xtQRgp3HOHhlfFPKhoqR002BPlneX5bM1ukHO3YzG?=
 =?us-ascii?Q?yeyP5G93BLD14x9jJu+ZasTE8suaTeJUwjLYvkbKzvuXo+BstwDT2lcK3FIg?=
 =?us-ascii?Q?c8lgHS7zO+NCQUPCOXPMvsrWjoRLKhQsl09UNFnpOOzlY1LLDIMaPoBos1Y2?=
 =?us-ascii?Q?AptphKGUeE6NCbf1zn+klaaOj7iFSg+wEk99D0YQC3/qwdvzSpfdAJ3FaDaW?=
 =?us-ascii?Q?ymiEyzWWUtlaR6C9T/tFNHUkvjsvw1WCSQHyxxWPZ//0wvImYHhPTj/z5abn?=
 =?us-ascii?Q?/66HXvAcnrHPpsDxOoZZcuO0xagzcdAfZrPn/EYAY3GjgTWP07ZFOwK5gKlY?=
 =?us-ascii?Q?bc2hrsq5M4SJWbyAQ1r59Py3PDNpuNpUIMTgYWp5XoQ93ckI8dwSYfsR0LUh?=
 =?us-ascii?Q?oPFG+uuUAoOlbZl5bhUvFPB/lVQc8pydr66PuFdV7uC54T6K/ZZFYz6bw6V5?=
 =?us-ascii?Q?Bzy5/ufi2RjPgzKZud6Ftvmxiekpcim3pzeX/6qzymL2HMgFtWZENG32I1Sz?=
 =?us-ascii?Q?BdxWDLb5PpIWx3fUXI9CKwQiz2/2wzn6499BmZMfI+Xy++yE+JJgBMZKXH0D?=
 =?us-ascii?Q?7LqHrpd9uA7Vu5/HMEZ9KIIyTmxsvzfaa1l0wdFbWZW31ZqjS7j9aaACABYF?=
 =?us-ascii?Q?wPhXBL9vgzrP7p9oi8zaz1/+1V6roa1ParzxhQt5Xk8st/gK+vzWhBUFxg6F?=
 =?us-ascii?Q?eNOCq9k9OXUPncMzdVtSy2VmWyAcPo8ExxC8jus/BX6NlgSQ9lVM5kRGY8na?=
 =?us-ascii?Q?yIZdYvNtz0N120sYVLtzaOozADiva9dIoky/XcOdHicwt0LWL4ON1XllML4f?=
 =?us-ascii?Q?5eKdIFrezBfWjVLewJBGXsRHVqnyeWbVyHnPYNBU9/qtDivf8JdDxnhv+OwD?=
 =?us-ascii?Q?gmJNpPF9KRYQR8g5ofqE7qJyL3ABnnf3Gv+vkJuHNhwkplvtGD2BEwpGbO2z?=
 =?us-ascii?Q?lUnGbFU8bj5uzlut1fFcdSJ8DNBUjsJgasVR/D3KfLhZjgkGsMqohSn8KpFh?=
 =?us-ascii?Q?s8SgZ9xlaq29MFdUBcpnJyzKZMtwW65M4xQnphLhwogoUajGhrU7UcTVIGrd?=
 =?us-ascii?Q?LFzzeCAmJi+pzHqAXoV3ualzuRpUr5FHa1j0FDe97pr36DiImoxljYjBod/I?=
 =?us-ascii?Q?Kc/NTo3yCBVVEAV015nv00Uvb5dAQC+yjX/e+pGWEnLdNdflx7VSf8TLmw1f?=
 =?us-ascii?Q?qhJ2TTKV+pPsib2CJkBUXHAeP+OnzoXL9H1w95Bs1lKhGZgDYl7C3GriaIkJ?=
 =?us-ascii?Q?5g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c57eb41b-e4fb-4bfd-7fbc-08db24a16388
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 15:32:58.3312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vq4ZvNKXO81WGSgCiGpJ2V1TFchFIjZcwLUaw7fCz0/hFwf4IaaRmAFVgHnsNa4H7zycL86ihKdybqN+Ch3qPdCfw7Z+DozycgoRmrpzoF0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9495
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. Replace ENOTSUPP with
EOPNOTSUPP. (Greg KH, Leon Romanovsky)
v9: Replace all instances of ENOTSUPP with EOPNOTSUPP.
(Simon Horman)
v11: Create a separate patch for replacing ENOTSUPP with
EOPNOTSUPP. (Simon Horman)
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index d43aabd0cb76..dc540e74c64d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index f26ff82723f1..8033ef19669c 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,17 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 89b0a5af9be2..d123d7f43e85 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -EOPNOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1