Date:   Wed, 15 Mar 2023 17:06:52 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v12 1/4] serdev: Replace all instances of ENOTSUPP with
 EOPNOTSUPP
Message-ID: <ZBHtHDZQmP8f8aio@corigine.com>
References: <20230315120327.958413-1-neeraj.sanjaykale@nxp.com>
 <20230315120327.958413-2-neeraj.sanjaykale@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315120327.958413-2-neeraj.sanjaykale@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SVrHup/86o9avuqD8tZp7NtiDwVgHKBB6LYW2Qyh2P30aXr1ywzWxUivdud+?=
 =?us-ascii?Q?6+LLBYbotvluOSKbEKKygH5IDeO8P5Mxm+6GFms7O2apkcXwq1/DWpY8hNCO?=
 =?us-ascii?Q?+b/jRSON9SMvPKTxD2yiDiGBAZCQI/P0KgPFWAathvXlgdCbrC43todqnlHX?=
 =?us-ascii?Q?xdcg8tQrJ844GK/mJpZhNy9hwpFeT6eZPx9BIuNFIOvsynmas9wvSND0yINO?=
 =?us-ascii?Q?ZPmO9mLToZxIAQSmgdp9u3QnD6nfapT2CZuNORuB7qmPi1PZLxTv/+VhVB+N?=
 =?us-ascii?Q?0+KqO9Wnsnyw8Cp0tQWiavqD+pS2No4mdDeMA65b3aCDpdm4aFLnhPrRQc25?=
 =?us-ascii?Q?HcD4Mpi7VdGOSG3mLZlcryvB5nYk1cvmmD0lQj1pCxU7QUEipjFDAU0uxywE?=
 =?us-ascii?Q?wxsAWn++qOsoJgw2p2QbNjvLoOkls3gprgoMnfwTiPD4JrSJ9qS6gxcLO83A?=
 =?us-ascii?Q?f/KicuKnSrACPNrywLW7N0BIW3KT59YfthS4kygiTs7PAAGjBVjLeCX4zyVK?=
 =?us-ascii?Q?z3nWd5LY4/Gp2up+2G6t/Zd9SzfwkIhCi4qgo/ljkzYAaOvjJLktIp3JwwS2?=
 =?us-ascii?Q?gL+QMomu3hWlxvdouShEdiKS/Cu/ZGNS3T5Ph5aRm3BEQFW2GVz9btSxzyMK?=
 =?us-ascii?Q?phB2we/xzDzT5paZizyRWOTFvMx09UGpd+/WnS8lyXXOUsYvYiLLfGSNXm1g?=
 =?us-ascii?Q?CwLiAnil6w4s69I3Z5RsDN5D/ADHBZS33lXnrbFdNVSkZnVv853zyRtANueF?=
 =?us-ascii?Q?JN40MwtbMzdXfaKE0sHb8NGHDcIPDL8WArDVy995rZHDPApUHoIWNTXCVDlW?=
 =?us-ascii?Q?/9DE3zZ+XW2zNmNtDRl3pwxEbNFHdyMY1EfvXdAsZWd4A0wZJ37fhx01AIhm?=
 =?us-ascii?Q?0V5T1T6B6JGa8qBwRqDIg8r1x9PWLJQu81MfGnAS4/laBU7q9gjDqIU3TVVT?=
 =?us-ascii?Q?OLEcN3zvpEe+t2cZK2Tc2jbIAXq4KgQvo9IsGx/nKwt5teePdwj/qLL/KeuX?=
 =?us-ascii?Q?EUaLTLTnGumKyWpRL6XT0b/6GfMZV1INbdG2xRwl3kdEn+MML4AYCrJI4Xzv?=
 =?us-ascii?Q?QGMrf6mgppnyDVjCyLJ/8OfLDc74Pg1ISP0q27z2R/izfWK/a/MP1Qe3uqm0?=
 =?us-ascii?Q?QSQhWIMyQeC3VVdWs+G+Z6oGewUcAZjn4xQere9vM+cTULN0+y4nurcbigaJ?=
 =?us-ascii?Q?VK3cbmiPStdkr2jcMfw9u0lZRBMMFk3rgyubS3jMsQOWiwrBpFd9/Cbm80DY?=
 =?us-ascii?Q?PWpGYk+SOGcYVLjHQl8rklROClK91m27XBGbzZFguQyS4FVuza6H37ipiBJb?=
 =?us-ascii?Q?4/+AY/KP+IZgL4mT2l1/5iY29nORubST7KYUQKeTehkImQTzTvJ7WPJm8qZo?=
 =?us-ascii?Q?G11QlT8WjpC6f2DgVTy+3Uw02dY5my2kXSzKPXRk8qMxC/SGWiDqPCRzHvM+?=
 =?us-ascii?Q?rYDwXIsiSKN0hnT3968Qsf+iIdqD/S/moG639bumCf66sTXUwRZABZjBxaGY?=
 =?us-ascii?Q?BH/wrpyan44yoiE+ztff/YPRTjQ1I9/oP+odFO8SfZ6LuGag5Ejvb1tGns4r?=
 =?us-ascii?Q?WqBRlbV+6ryQuyevNo6cRtjcrfiyUskZ9M004xytH0mXWI+S0n5IOcwKAMnV?=
 =?us-ascii?Q?Zf6iRDiMkqMp3MaZFlAgzz/TV/mYXQaVZgQ5nPS4Xm5EHFlIiDr70KhdAgo9?=
 =?us-ascii?Q?u2gNhA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29aa0ee5-7e2d-4be8-084d-08db256f4f5a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 16:07:00.7986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lh+rcsTdN7Y3jkOOEBgpGoObAKVPtGu0zqA553jx4O+JyaxUHgcj37/dX6uegrGQeBdoyUMh7VZYw0CnTRTn2kohzUKdcVGZ6/wCBB9aiC4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR13MB5814
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Wed, Mar 15, 2023 at 05:33:23PM +0530, Neeraj Sanjay Kale wrote:
> This replaces all instances of ENOTSUPP with EOPNOTSUPP since ENOTSUPP
> is not a standard error code. This will help maintain consistency in
> error codes when new serdev API's are added.
> 
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> v11: Replace all instances of ENOTSUPP with EOPNOTSUPP. (Simon Horman)

There may be a policy or issue here, I defer to the maintainer on that.
But from my PoV this looks good.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

BTW, please consider waiting 24h between patch postings to
allow review to take place.