From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        simon.horman@corigine.com
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v13 2/4] serdev: Add method to assert break signal over tty UART port
Date:   Thu, 16 Mar 2023 22:52:12 +0530
Message-Id: <20230316172214.3899786-3-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230316172214.3899786-1-neeraj.sanjaykale@nxp.com>
References: <20230316172214.3899786-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UpVxV6oUKpz/+1WwElTFQIYbB+8B9Rdg831/HfhgJpcFGo5AdokWAOi8ZgNg?=
 =?us-ascii?Q?5YIm5HA9qJ/9OTy7cC+w1YphY5kl6XHo75ZFxPMY0G+Hhlte+Y0yCRPYX59e?=
 =?us-ascii?Q?PdpVoHG8Fea8XbQXx//qLuUL98kVRN3RIjeaQB+B3BmGhd9Rgk43WPDFz2V8?=
 =?us-ascii?Q?/PXKbvay5UFxA86hiQCYIWWrhzZ+dMiwR97ZWu5v7BHKGWnlXwT3ARNGLRHK?=
 =?us-ascii?Q?MoeU/mFBnVrgL4EzdX4HONChaaBv4zqkaKqxYpcnscXiNOmcrRvKb9WOQZhT?=
 =?us-ascii?Q?dZy7ULch+31Cn4hisyfqdywEMo8SPV+FTJF4lAzRegjj5XDoaXGbuP/eqpwd?=
 =?us-ascii?Q?n8rpjgZDnzpBxMRNzqsd5nLkcmHwV2d9ewObryNlvWSkWc3gTtgeeq1AKsub?=
 =?us-ascii?Q?3GelQAWy8zN0pA0Jzo1YJ+SwdSaRdkWoQaKBPmObI5puV7hv5HRjH9rVWBTh?=
 =?us-ascii?Q?1cRWVpc3gDt9jafGF5dcSJMkNnz/egFdfl6GOBlKX8Gxtcg/TdeFIGrR34JK?=
 =?us-ascii?Q?soJ6iw/R/gKi+jZ+nGe/k1S6LYWPyka3GmkSXhlmpuob+1Mc2g6JDC2NsAqn?=
 =?us-ascii?Q?ET17hO0ev65mSNW5M4JeP/36NKJJG7mgu3/JOoMEqe/nPuxvcgOeRxGupAmG?=
 =?us-ascii?Q?VLPlWJWUr+7vI7+nGlpOLQBPOc1JBCfhuv8tFMcUvZBgJuospStWtGSCUEC5?=
 =?us-ascii?Q?LVWXMpMcyGLyKTo2vtY8cqZPUaFbXiwFExS4VIrhBWHAGc3Zu1zjaQWE2jaC?=
 =?us-ascii?Q?nbz/JDSOLppFKl1RrF5RMRHWGV92K7s6KLUoVNyiRB8NCDx+KxuP54NYq2gW?=
 =?us-ascii?Q?LqHD6jr+mt4XLtwIx96UmaUAihGhW9Q3/hTKqVtqNsiVhh1cUc3ZXLPyuf/O?=
 =?us-ascii?Q?gD95J9+tuJM3ogU9wEO/yG71Zxtovs6xve4UlJ/Bv6PfRi5uNNItvwBf5DQr?=
 =?us-ascii?Q?97xncVyrtg7BVdKi8LAFSwgqGD3v6jnGCa6MtN0K62QPwImiKrLm8Hvac1Fr?=
 =?us-ascii?Q?QrJ3j7b/mt4vlScIj07ngICF+U8cfjDyu+NZWO5JKj5drfqrzO0C5AbY/zJ+?=
 =?us-ascii?Q?tqWC2kZOZO6R5JKlrYNz4GeK3mOyewiyBW/Qbw8zI83yTXv8zVVBamsPGnqY?=
 =?us-ascii?Q?WmIzBLf8V1rytlbgcMBE3o8iaLAP9n5eEDGi5/ukj3SgttH4e3Ez+yVCL6d5?=
 =?us-ascii?Q?+NyTJom+vBW9iLE3T/veNMf91d+dvTbcqts0UH7RqJ+dsOFIjj0E5BkMhqbo?=
 =?us-ascii?Q?eeiPFrJjRJQ49SAIxGNYpE8BfYRRha+C8siqZqSBW1sY9DO+80If1KODjTSv?=
 =?us-ascii?Q?lEuJ1odpErJu4nKsxj64ioZDFvkFL7dowicY8k2rMvnEkmJpybW1yVQK65b2?=
 =?us-ascii?Q?9B/P0KTgSdIjDKbuY616D7NiFvXJIxGOIREjjNdaewgAug2Yw412ZDYa7KSe?=
 =?us-ascii?Q?G6e94atQJXR/aWo2Kdg69iXQcnEMUZnlrvQVsPW84xN8/JAaLiJKp7nE2jfQ?=
 =?us-ascii?Q?zwYUVEBPD5VNDgw91nDScbA6tf6/3P9jLjiI1wwb9jxFS4jac8uPJTqZKyDw?=
 =?us-ascii?Q?Idr3LkAidZ2L0E1Uq75YADi02ENX4UcnYrQLFf5P3sY0EBtgeKkL16VFk6yK?=
 =?us-ascii?Q?gA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf6dd7d6-42a7-443d-963d-08db26431536
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 17:22:56.6276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ucAe7wL98F5Bk6mh5vgzvCHegJyh1pEUH0D5cGVJ4VHdEVas6Y3NNRPRpcY2sOBdQwB0v6rY2t6tA+wyZx97clUcdf6Nrci+h8QpNVVXgWs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9293
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
---
v3: Add details to the commit message. Replace ENOTSUPP with
EOPNOTSUPP. (Greg KH, Leon Romanovsky)
v9: Replace all instances of ENOTSUPP with EOPNOTSUPP.
(Simon Horman)
v11: Create a separate patch for replacing ENOTSUPP with
EOPNOTSUPP. (Simon Horman)
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 12 ++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index d43aabd0cb76..dc540e74c64d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index f26ff82723f1..8033ef19669c 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,17 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +270,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 89b0a5af9be2..d123d7f43e85 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -EOPNOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1