Date:   Thu, 16 Mar 2023 14:36:19 -0500
From:   Chris Morgan <macromorgan@hotmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Chris Morgan <macroalpha82@gmail.com>,
        linux-bluetooth@vger.kernel.org,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        alistair@alistair23.me, anarsoul@gmail.com, luiz.dentz@gmail.com,
        johan.hedberg@gmail.com, marcel@holtmann.org, heiko@sntech.de,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org
Subject: Re: [PATCH 1/3 V5] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
Message-ID: <SN6PR06MB53428BC8A46EE990EED72DACA5BC9@SN6PR06MB5342.namprd06.prod.outlook.com>
References: <20230315173657.28692-1-macroalpha82@gmail.com>
 <20230315173657.28692-2-macroalpha82@gmail.com>
 <66c41be5-eeeb-9b3c-9bf1-414e03118578@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66c41be5-eeeb-9b3c-9bf1-414e03118578@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SN6PR06MB5342:EE_|MWHPR06MB2813:EE_
X-MS-Office365-Filtering-Correlation-Id: 7c5f9173-5f62-4162-1f42-08db2655b99f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6qQGtTLaQFt5ledYKE+4nRbPZ2rz3rPpmOF18yxKLIkNMoEmd+rXv1rd8ieXzadzpWssEb/11+k6N+4kpYZqLndYMRAI0qz7wrcFvaX85kzTcnPW9/vWUzCK4CaTn2XSwwiPzLBBsW4Wdn6IF1NmokVd4o+D0MfQD5Ton156DBA10siplieYIjS98yKi+iLwrXldnk0KSjbCA2fhRRO08Dfy1YP/uDtg+n53ysqIYuxsB2gcwrf/JBFD+H3g1iNdJDZNlbzTGCx4DUxkmZ8SknsTHc5ZBeOi5+7mvgzOY+vK5MRnLs+3YSTegPWJjTWe8/TUg6hLhZ1lKcMhoprFE6t5HWg21ibzc6gR0xvWtCQDGY1ECSxw+rSICphzhqf+JHm/YBNkU1BL7oLHmZ93qZFlEa/IX5jhVqWd0fAIewZyydQvf9PQGo1yhf6egb8ZSlZlIVY4PS8tO6T0Zou4XlKyOChLOlRGFsw/kuwYE9pI6gWi221Gj8fcRy3tCTuTEbACWRNqW7o5FzzCQR3Co1JL6gb7SNJw/etS6wKOFT2KUpCDb2GnkvgaaRZXClvY1XUfZBqFEKEiD4oEbFi6rrRsd8KCIGIyfFqYxLxUlk1OLqNOy2DLszkGon8uTxsS
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uxi9hUI9n5Y9ZhhuawBKPfMSUgNN6cHz9Bi0avKvr5kzzKraX45IMi54z7ZN?=
 =?us-ascii?Q?X+uZoVl6U08Zrwdkg2kGEEHp7wDEL5fiu72w2kn/NdJkrnfROn98hKWvoCBk?=
 =?us-ascii?Q?rdcCx+WqlEk7fkqpSsl5v7Q6oBaneHjL/xw05ZpIiNvh4zBK+dPz+ina2rX0?=
 =?us-ascii?Q?lwFSYNH9kqLk1IEV5rCYqSnXIi77cfrDQrPj/XmaNnyA89dmOjvY9oS9gHda?=
 =?us-ascii?Q?sGB5W4Tht70EcZesUKfzSWK7VOa34hZcy6nEpQSdGeO4TsClCmXjqHJKcueg?=
 =?us-ascii?Q?vE/sXJCzaMyGA1WkcUZthyBkycG8P4cJbdZyAOKTWkfI9r6p+hZ/z+0NplAT?=
 =?us-ascii?Q?6V5QyXMOKRdiGn8pTI4v1P0Ev18+u7J13mdUWPbovga88nOz60/2ODeYuLCB?=
 =?us-ascii?Q?J5/JZKEq67P+eFt3/4EEyxsf9sp/7n+ImWo9QP9vkwMPDWxfUpLI9jUem+Uk?=
 =?us-ascii?Q?tc+tfRKEKMLjGhAxCERyU7Dyc4L9ZhIpNg8e53HSYmjirMHe2ZY6TnSdyfla?=
 =?us-ascii?Q?nBd4b66QQ8tuSTKVZFbRbjLjzOlqbe0HiVmf3mO1cuHwqgMFULQwXTVVAjCA?=
 =?us-ascii?Q?QJq3kzPnmv0BUS+3xepMjkRkX7DPo1zOAM/CAPorYxV4NOph+gNeZQzpMJxU?=
 =?us-ascii?Q?+6cjINxWOeP9IGKrKohEuBPqeDAscSBcthBL9TKsg9zboXOWia/iLeFGbUBT?=
 =?us-ascii?Q?yG0/ciS6TfyPVZf2uUEXpURQq7b4YmJmNSmqrf9dIB4RArvB7BnK+g9vhy8m?=
 =?us-ascii?Q?4EJlYLXP6lfMbx3v3+QjRPvvtdvMeNylYcqBo17VqmkdYkHyb9is7d1ZPfvX?=
 =?us-ascii?Q?/iuattuoBKHMm4pMbbTnGg0DletT5hRen7TlksHS0LwLPVCR7N2zOrnUIVEf?=
 =?us-ascii?Q?BZhYBtCIliXhq9MndqPTmkHSdw+S1zb4GP8p6aDyrmtBTpbOyUmk4HWPVwp6?=
 =?us-ascii?Q?ZCV5vlbm2A+IjFIss9GMeasVr+vX9tzmFVVQY63zFy1IT9N1vNgr7HPchSfY?=
 =?us-ascii?Q?luLvAOqSdYuMdaQvs6XrlVG+bO99Ynlt/NuevU6FR9pjxALxFl5m0HJAZd3Q?=
 =?us-ascii?Q?auhtqhdl7UQ9Aql2mLXw/4bSTrgjVBrR71QD4VGQ/Z5AgPH4oMlRtQW+DEtK?=
 =?us-ascii?Q?hxnvaSZskT9Sn7KDzrMAyf65V/rUoQst8lYSSnsrIBxIcVZw7MV1aq/v2DIy?=
 =?us-ascii?Q?RWHwSg8uZeL/101SR1L0DzP4j1oupc704mW4wO5nq8Im2AjKRsGGg739rZKF?=
 =?us-ascii?Q?12nCo+c08KzgPWFopk7H2p/DNTSJXeOvva4bWZf+rQ=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c5f9173-5f62-4162-1f42-08db2655b99f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB5342.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 19:36:23.7126
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR06MB2813
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Thu, Mar 16, 2023 at 08:55:13AM +0100, Krzysztof Kozlowski wrote:
> On 15/03/2023 18:36, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add compatible string for RTL8821CS for existing Realtek Bluetooth
> > driver.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  .../bindings/net/realtek-bluetooth.yaml       | 24 ++++++++++++-------
> >  1 file changed, 15 insertions(+), 9 deletions(-)
> > 
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

I removed it on purpose and noted it in the cover letter because I
changed the bindings. I apologize if that's not correct.

I changed the fallback from "realtek,rtl8822cs-bt" to
"realtek,rtl8723bs-bt". From the driver perspective that causes it to
disable runtime power management, but otherwise it's identical to V4.

Thank you.

> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions. However, there's no need to repost patches *only* to add the
> tags. The upstream maintainer will do that for acks received on the
> version they apply.
> 
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 
> Best regards,
> Krzysztof
>