Date:   Fri, 17 Mar 2023 21:42:35 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v13 0/4] Add support for NXP bluetooth chipsets
Message-ID: <ZBTQu4RXHHbVRJTA@corigine.com>
References: <20230316172214.3899786-1-neeraj.sanjaykale@nxp.com>
 <CABBYNZ+DM+DKYVb-EqRX+WwW2hCrcVeMh29PVjqTM0WW2+HBuw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABBYNZ+DM+DKYVb-EqRX+WwW2hCrcVeMh29PVjqTM0WW2+HBuw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVlxcEZQMWtBYlczcm1hQ04xV1IxR0U5cTJnUE1tVkVvd3B4VGxlYlZmT0lh?=
 =?utf-8?B?eEdXbTNDc0RIZWg0U1Jkenp3aldRRVF1OVV0dGhhcG9xbnI3ZFdZdjdJNjIz?=
 =?utf-8?B?ck42VXBQdUhrZjNCU3llVmQ3UE1ML1lwbkdwWXhVNGJMSEtzUE5mYmozMkdP?=
 =?utf-8?B?cTJHUnlmSUMxVWxpcDFNSXZBdWh4U0tXbUtUd0NYYk5vamNPc3krUWhxRFZC?=
 =?utf-8?B?STJhSXJCZVRTQ2FXRHR3RnA3L0xNQ1dTMDJ5NzRhQ2gzQjVRU0NpUGNIZUZT?=
 =?utf-8?B?WG5oTUdaOTRQRGw0a0p5cFBmOE1zMkd0S1Rvc05UUGM0OEpjTmJFUStkbk1D?=
 =?utf-8?B?Qk1zRXVKRkppUGt2S05jMUZpaXFSL3lWR1FpbXp5d244bENleW8yTlU5bkdJ?=
 =?utf-8?B?ZXo4U2VkbkVWUnZUbDJwQ0ZxQ012UjJmamFQNDB4NG5LV1ppUDBkS3lWQTVt?=
 =?utf-8?B?TG9KUzBreGlOY2E5ZXZYTno1TU5tUUdWY1RyQmJvZU42Mm1jSHdNeDNvRHRp?=
 =?utf-8?B?SWNRS1JCam5Ba2V6VWtUc3lMNWlHT1kxQXhRUkVkOS9rSXJnRndjT2tSYmkr?=
 =?utf-8?B?OGQrdmVoSkM5Q1FNL1g5dEZlRkFaV0txZjU0ZjJLSzBpbjhOUEFUSXN2d3FO?=
 =?utf-8?B?VHdYUEhhSk1ySVRBbFNxaENZT3VYWExuZWdOT2pNMGJSeHFtMjNURjdOWU1k?=
 =?utf-8?B?anUzeDZmbGQxcEZua3ViSDRsenAwaEdVajNHSVczWmdEQWp0a1dESThSSVNK?=
 =?utf-8?B?T0VjQ1huK1Y4VDFKcFF0SXNOL3dQYVJsTDA3Z3hYK2xJcCtJK1prdUJWenly?=
 =?utf-8?B?Q2EzZFVWRTVmRFFQeEN2ZVB6WWVOWVlnOVliK0dHRFBzNXRQd1Z6M3JUVW9a?=
 =?utf-8?B?c1JTNEl5Z2xTb0lYZUJVWTFFWkVKbE1lUmtwTk41dWx0am5OR3lzQ082Z2I4?=
 =?utf-8?B?dlg4Ris4L1hLVFNoYnJWajZCRmpVK0gwVlpyRVlDcWZnU2FHNmdtYmhZRVE5?=
 =?utf-8?B?aHN6VUg0VUNMY0x0bWc1d1V3SWJhMHZDQVZmbzR6VDkzOVBWNFozSXAvbE5p?=
 =?utf-8?B?ZGttck1CcHhHdEZ5WlE3QVJkUE9zcjZjdVFmaitKd1BpdGdJUUp6UnA0eUJS?=
 =?utf-8?B?SGFrejNhN3NzNmpIbjdvbTZIVnIzeEVQc1V3dUtoRG1Ick1CY2VXcFJuclFn?=
 =?utf-8?B?SStTZmE5TDJvK1ZPSEtoVXVWYXRFM3c2L0NzWVVFa2QxZ2NDK25LT01JYW94?=
 =?utf-8?B?SlpVNjE5T2RVUm1VUE5uVmg1T0NLNmtKN245TDdwMTJCdzVndjVUOUNZTXJz?=
 =?utf-8?B?TytOQnZwTjVRWGpPQVZmM1dSRDV4ZGtQbDc2Rk5SZGU3YUs1VGhmRk5vUnIr?=
 =?utf-8?B?VGxOcUxYMEtVR3JSa2JPc3A1R25yWW5PR3o5dlRmUG53ZXNOclpLcTVPZG9m?=
 =?utf-8?B?MmlCUVlOSklrOFZPVnkrZjU1TGF6WUpwemxTdjc1ZW1xY3cyY0YwSjdrY3VW?=
 =?utf-8?B?YmRjbVVkRkIzaEJQRFE4cUhSZmt0bXVYK3F2UWdUNFNtMEdKYWU2cVlMY1d6?=
 =?utf-8?B?L2l0aUttRUtva2ZUOER3Rml3Ti90MkRFdUliSnMvYkZFczFwWVFUTVVicFpR?=
 =?utf-8?B?ZFdEVU9pTWNGY0tVaS9ROWYxOTVvQU12WERod1g1UnFsSkJ4VWxBVXl3SzR3?=
 =?utf-8?B?NjZNTVEzQitjVWZvSGE0KzV1OTZQRHdnTnJzMDFqOGZTdzVHNElSdEZuYzQx?=
 =?utf-8?B?K1ZkR2tNL09JVHAzbE5oR2o0Z2E3NG9RQVVMbWswV25ucEgzdGZZZ2VYbGJ3?=
 =?utf-8?B?alhJek11Nk5pak55a2dPWk9sOTQ2ZnlmcXBsS1BLN25oRmNIdFNnUlk0cFJP?=
 =?utf-8?B?eXd5QUdPaW9SYTZJN0gwNkRnblNqVGdOOFZqT2t5TmlBaVF4RG45TzlFOWlh?=
 =?utf-8?B?SFhnb2xqRDFqd2cyL0N4dWxNN1Q2SHk4S0hvbmtkMVlvTkJJaGJHQkRONWtL?=
 =?utf-8?B?RUY3UUZRczR3cEkwZmh0TWZBVDEwb0xPUUdvMExvcjJEcjd5WDRnN1MwZ0Jz?=
 =?utf-8?B?T3BhUHBVZFNFMEJqdC9sRVorREVabkZ3bE9DeURTeTNHK29ZNDZTeEVERjh0?=
 =?utf-8?B?ellBNTRMVjdsK0Y2bGNmdVZ3Q0piWWJrZ1JydTd0Nk9FQk1Id25TejY3MDYv?=
 =?utf-8?B?NFowSG9Tb0w1NTlEc3dDaU5VYkRBYmlLbVA1RDFxeStaQW1aZXhQT2NJUXRP?=
 =?utf-8?B?b3pTU0NqZEJydHJ0ZGU1UEp2dldBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b9e5157-edeb-409f-fa9e-08db272828cd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 20:42:44.2343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TcDbRPWOfxdS3zrKCEvsfcenuv0lI8Td1q23hfxLibT2UbDUJZqsIGsvvtNxNurYwpZ60LKoKPEshSINs9PuuvqSjcFmrEnR6f7yKQX82Bk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR13MB6249
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote:
> Hi Neeraj,
> 
> On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale
> <neeraj.sanjaykale@nxp.com> wrote:
> >
> > This patch adds a driver for NXP bluetooth chipsets.
> >
> > The driver is based on H4 protocol, and uses serdev APIs. It supports host
> > to chip power save feature, which is signalled by the host by asserting
> > break over UART TX lines, to put the chip into sleep state.
> >
> > To support this feature, break_ctl has also been added to serdev-tty along
> > with a new serdev API serdev_device_break_ctl().
> >
> > This driver is capable of downloading firmware into the chip over UART.
> >
> > The document specifying device tree bindings for this driver is also
> > included in this patch series.
> >
> > Neeraj Sanjay Kale (4):
> >   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
> >   serdev: Add method to assert break signal over tty UART port
> >   dt-bindings: net: bluetooth: Add NXP bluetooth support
> >   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
> >
> >  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
> >  MAINTAINERS                                   |    7 +
> >  drivers/bluetooth/Kconfig                     |   12 +
> >  drivers/bluetooth/Makefile                    |    1 +
> >  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
> >  drivers/tty/serdev/core.c                     |   17 +-
> >  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
> >  include/linux/serdev.h                        |   10 +-
> >  8 files changed, 1398 insertions(+), 7 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> >  create mode 100644 drivers/bluetooth/btnxpuart.c
> >
> > --
> > 2.34.1
> 
> If there are no new comments to be addressed by the end of the day I'm
> planning to merge this into bluetooth-next.

FWIIW, as someone involved in the review of this series, I am fine with that.
Even though I have only supplied tags for some of the patches;
those for which I feel that it is appropriate.