MIME-Version: 1.0
References: <20230316172214.3899786-1-neeraj.sanjaykale@nxp.com>
 <CABBYNZ+DM+DKYVb-EqRX+WwW2hCrcVeMh29PVjqTM0WW2+HBuw@mail.gmail.com> <ZBTQu4RXHHbVRJTA@corigine.com>
In-Reply-To: <ZBTQu4RXHHbVRJTA@corigine.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 17 Mar 2023 13:48:03 -0700
Message-ID: <CABBYNZJG3T+v=RdQBuW-zvDDCQpqdkn3K=fP3NkPECJQdLbo9A@mail.gmail.com>
Subject: Re: [PATCH v13 0/4] Add support for NXP bluetooth chipsets
To:     Simon Horman <simon.horman@corigine.com>
Cc:     Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Simon,

On Fri, Mar 17, 2023 at 1:42=E2=80=AFPM Simon Horman <simon.horman@corigine=
.com> wrote:
>
> On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote:
> > Hi Neeraj,
> >
> > On Thu, Mar 16, 2023 at 10:22=E2=80=AFAM Neeraj Sanjay Kale
> > <neeraj.sanjaykale@nxp.com> wrote:
> > >
> > > This patch adds a driver for NXP bluetooth chipsets.
> > >
> > > The driver is based on H4 protocol, and uses serdev APIs. It supports=
 host
> > > to chip power save feature, which is signalled by the host by asserti=
ng
> > > break over UART TX lines, to put the chip into sleep state.
> > >
> > > To support this feature, break_ctl has also been added to serdev-tty =
along
> > > with a new serdev API serdev_device_break_ctl().
> > >
> > > This driver is capable of downloading firmware into the chip over UAR=
T.
> > >
> > > The document specifying device tree bindings for this driver is also
> > > included in this patch series.
> > >
> > > Neeraj Sanjay Kale (4):
> > >   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
> > >   serdev: Add method to assert break signal over tty UART port
> > >   dt-bindings: net: bluetooth: Add NXP bluetooth support
> > >   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
> > >
> > >  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
> > >  MAINTAINERS                                   |    7 +
> > >  drivers/bluetooth/Kconfig                     |   12 +
> > >  drivers/bluetooth/Makefile                    |    1 +
> > >  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++=
++
> > >  drivers/tty/serdev/core.c                     |   17 +-
> > >  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
> > >  include/linux/serdev.h                        |   10 +-
> > >  8 files changed, 1398 insertions(+), 7 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/n=
xp,88w8987-bt.yaml
> > >  create mode 100644 drivers/bluetooth/btnxpuart.c
> > >
> > > --
> > > 2.34.1
> >
> > If there are no new comments to be addressed by the end of the day I'm
> > planning to merge this into bluetooth-next.
>
> FWIIW, as someone involved in the review of this series, I am fine with t=
hat.
> Even though I have only supplied tags for some of the patches;
> those for which I feel that it is appropriate.

Thanks for the feedback and the review as well.


--=20
Luiz Augusto von Dentz