Date:   Fri, 17 Mar 2023 22:03:21 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux-bluetooth@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: 6LoWPAN: Add missing check for skb_clone
Message-ID: <ZBTVmYW1IWQA2c7h@corigine.com>
References: <20230315070621.447-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230315070621.447-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CFnCHB9jJLqiVkO2NmlRvXYNJ0+T5jZrOKJdBtFxvNzgXOQS78d4C1CG+7Wj?=
 =?us-ascii?Q?k67USaxy+9xg85FRQ2FrzAmQD05X3eK2DOtyAxzFXvUZX4WNClETihOiazG1?=
 =?us-ascii?Q?U1vaFCc5adb8vyZlIrzBs5IXFS/7YlgQZGSJvVGQrFuouUsZs6+KcicIBcW/?=
 =?us-ascii?Q?U5mYxB/ohiYt+BJLrPWRFgTv76aQ542NcSpSLxYM6yJ+L5Rlzz5ygWVXlmir?=
 =?us-ascii?Q?r5s7GmzK0wGewmfZmaHhsjDdbOD3O9YRTcLus6IhTr2S4G7djeaI+yuTS7+0?=
 =?us-ascii?Q?6OEyuy6hYgIcYpG6NOG5Y97gzT9Uqa9AWI3UXlV3sDrlaHQbHf78QzquTXWj?=
 =?us-ascii?Q?xpVnMaZg3leQMxAQsFcdwlVl8Q0TK9W2aOQv7I23vOP24x/Vv1SFzPxXRqGL?=
 =?us-ascii?Q?a18T6y3+X/02dc4rskPVb/1H5rT9cX2oKI4UScHh3NoH6kqmN6QKyFPqNwsW?=
 =?us-ascii?Q?+WpHwk1qL5cjxkeHlodvQbo7HP+CNNDjeZcF0Xc/jujgt3sRVAi8B2gEtsrz?=
 =?us-ascii?Q?j7ofAQIBhTaa2YhsUDAgz5Bww0YeFFonLWk+oHBvdntF+MZhBLOR+9mahCWT?=
 =?us-ascii?Q?nhrxCCuOSRt3FnE1Mk/0HKRNMQ1sUzKxNKSd89h0Xzp0bEIjQQWvrmvR75He?=
 =?us-ascii?Q?DKDa9aiyYDM56M/ET2Jhjkaa8E7rrCMbonGNY3UBpN1HSEaTGEEtWegjM86m?=
 =?us-ascii?Q?c46ymve1O4mSU1THOGTSXdJLnNLd4b060ImWc6mL0PVzJ47390MzAZoX3zQT?=
 =?us-ascii?Q?nNtWoTkEt66mBx2tCjGSCH/B2P6Pn5hDuhZ+DMsmY67gsvLahELzXT7E+3Uh?=
 =?us-ascii?Q?M5HG87OS51J/hm+/od56mKZMeTaxRUuHY02pHFvbhx3N6yT5Kq0raq89n3HD?=
 =?us-ascii?Q?6Adq3VeO15S7PUvreqTfFpswODcAIfdtt85ao16MbfxvsHqu/pBJXAVLOcKN?=
 =?us-ascii?Q?z8Plgdt2LqsyCa11ZWEm66K+WU94Oa0Nk9f2nQKapk7fZBVFY9MWPhh3q/Ea?=
 =?us-ascii?Q?YWEamVuvkOYIynoCvYal/axdEht+OqyAqrbbJyJUIfLWeD1KlQrTkbBX8l9u?=
 =?us-ascii?Q?krSjzeULMqL/hwrEHYNCBDLgiOK+i62r8sKpRgsbJzFd1jmNA9fwmEY8kGx+?=
 =?us-ascii?Q?B3c+GLfq2ftFVLKwDO312LxZYCQVpTjaN2Gdm6nUTzz+FC95HBSmAFXuBCgP?=
 =?us-ascii?Q?MJmlcvAwC0sj3X7K4kkd0CPVECmTOFiIt3HtVKrYv6CIdNEy/dRp6OEBOkNf?=
 =?us-ascii?Q?GdxZB33zdl2PS/S/uTuW/Ij82Y8edFluYdtVKxj47XbiZCSDF+YZizp5Dr8i?=
 =?us-ascii?Q?1rifoKCTyGUcMJtpEHRG5agTTjVTLz/zxiXjbfStfn0W0vQDw++xok5dkVWT?=
 =?us-ascii?Q?9G39xmbdJaGcGHVxZiHWOfiPFAtzQHUFCSEvoi1CpdgTnlhnGSBP2MEfOlUs?=
 =?us-ascii?Q?vWpDjmBzsTFKvsNHItIL+cIaJHuNsB1qPgf1iUETPlMr7+hhv+EDdq1uSe2I?=
 =?us-ascii?Q?sRhi6WF1i+Anj1LHvxlV/ppE912pIgme1Y/V2G/znTao81c4pH1qMBFFVPwc?=
 =?us-ascii?Q?8phUQ5alN0vwKT7ZJTgib5CdI7zPzE9KJoFhlcTJ51i04HG4PTQ+vs3Dfhnn?=
 =?us-ascii?Q?hUuq1lRzwGTOjLR8i9RAuoXpXCMyXIisVVdTAarCliSErckTzpNmXBRJC/Fh?=
 =?us-ascii?Q?oQ2JAA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbb3d8cc-8a30-40a4-49a1-08db272b0e97
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2023 21:03:28.6804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PusHlCmqekRLtqIO3I8EaSISKFRmd34UOkG8D2rrUzLHyf75mv1CZ5f7D94+2WDa7bH0GPcUprgK9d4n2ppjpG+A/hpnoDPSzYiOfOBEhxs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5121
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Wed, Mar 15, 2023 at 03:06:21PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of skb_clone since it may return NULL
> pointer and cause NULL pointer dereference in send_pkt.
> 
> Fixes: 18722c247023 ("Bluetooth: Enable 6LoWPAN support for BT LE devices")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Modify the error handling in the loop.

I think that at a minimum this needs to be included in the patch description.
Or better, in it's own patch with it's own fixes tag.
It seems like a fundamental change to the error handling to me.

> ---
>  net/bluetooth/6lowpan.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index 4eb1b3ced0d2..55ae2ff40efb 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -477,19 +477,25 @@ static int send_mcast_pkt(struct sk_buff *skb, struct net_device *netdev)
>  			int ret;
>  
>  			local_skb = skb_clone(skb, GFP_ATOMIC);
> +			if (!local_skb) {
> +				err = -ENOMEM;
> +				goto out;
> +			}
>  
>  			BT_DBG("xmit %s to %pMR type %u IP %pI6c chan %p",
>  			       netdev->name,
>  			       &pentry->chan->dst, pentry->chan->dst_type,
>  			       &pentry->peer_addr, pentry->chan);
>  			ret = send_pkt(pentry->chan, local_skb, netdev);
> -			if (ret < 0)
> -				err = ret;
> -
>  			kfree_skb(local_skb);
> +			if (ret < 0) {
> +				err = ret;
> +				goto out;
> +			}
>  		}
>  	}
>  
> +out:
>  	rcu_read_unlock();
>  
>  	return err;
> -- 
> 2.25.1
>