From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     luiz.dentz@gmail.com
Cc:     iulia.tanasescu@nxp.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 2/2] shared: Add initial BASS code
Date:   Mon, 20 Mar 2023 10:45:02 +0200
Message-Id: <20230320084502.66630-1-iulia.tanasescu@nxp.com>
In-Reply-To: <CABBYNZLOe+MECyHsZOrH23E_1Q6cCZNXKHm3de4u6ErdGg5OyA@mail.gmail.com>
References: <CABBYNZLOe+MECyHsZOrH23E_1Q6cCZNXKHm3de4u6ErdGg5OyA@mail.gmail.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xuVXDhBWu1NUVxhKQgctyG4xd2VPj46n8M+tssBR2vyPIhzzVZqmWZSp6HMw?=
 =?us-ascii?Q?Snq2+FKvJ2MDkJKGgdZpr4o4S8/+MLDMRJ3ez9k7Mb3nlfgQwsmWjpZZ7NPa?=
 =?us-ascii?Q?8ICucKifNY+5e/KREi5XhKOh+pSNv86jtfqItsyuY7yZ9WZGuD2mfAO4TnuF?=
 =?us-ascii?Q?rc3DCTbq6xq2ANtkmvSO3WvufTEYGYWiF7gRH3yALVO1d1qLr/Wvy3LlxdW6?=
 =?us-ascii?Q?ouofNj2BEyLGTIozikWeSdWX0PY4wZEwfb7Pp/wBtY1A0CbLp8Wh9Jd5R4mj?=
 =?us-ascii?Q?E1LBLapXAl63YW0ctuCz7f0oNL2fomWx7bPtVU3oIkYC0Dr8ILGXpwgNBXwR?=
 =?us-ascii?Q?4/CZd47qPWpWG5RCJOtjtYXmNkNcGwzbbd3aBsHVmuf7Pb+6ng40hJyvta/5?=
 =?us-ascii?Q?dX8t6yxcGFdOTawYLE1KUZ1szjpJFuKyKufE737CbUG6YeA6snk0udDJYI4I?=
 =?us-ascii?Q?Wu7V7Vzu7QUxz4UoKx1urkBhnDASQy17H/gb9qM3ZVPi8ZrcMphPszXc9OFl?=
 =?us-ascii?Q?8smK41SW4V87FMzUVOWSqYuxTkyk/jx9sl+o2LDOTHzAY+uJFP7Yt/WwpYss?=
 =?us-ascii?Q?ub3OsMEWVWyjjAtP3EqSPLsJwPce2feKDLWrjj+51sO5EejSCdSeWr0CP2ZP?=
 =?us-ascii?Q?/Jv794U4zpJtc7m2ara3Gru4FkNtw2HUYiy40OB1W3J2c6G4U0mc8XL9pjki?=
 =?us-ascii?Q?TcWend9oI9gyAyX2c0+Xlhan3/SvOnR1siW/pUGnUyzLzA1ED2XYpLQeoUOS?=
 =?us-ascii?Q?n9owGoao5AcoGr3HT/HqvX/rJna0IDwIRWeItUJypP9jW3RAC2INQ9fNMg0j?=
 =?us-ascii?Q?Hc/9PSOh1r4M4Za91YgFXwrPe1hItVakdFaEkUX9TNntG23u2u9oKzOIM1fD?=
 =?us-ascii?Q?92nlPsjLlZQYWbKpaRKursrMTWKA4TTZLkL/wqAXAkInD/cblnLcQDIRGSHF?=
 =?us-ascii?Q?RSIHXOd7Jhp4fwj/98FcdXWerjeM8/xlRm2/gPmoquXw0T2QXQcz/q+2ZH6H?=
 =?us-ascii?Q?Y9VP/qJXKkk+5TWFwqwrzZ8gqrZ50yYW8141lSp/fiUREjzCSDC4Q8lf983m?=
 =?us-ascii?Q?3gm353ToV7ItM50Z3jHt5wQRx9RNOlfhdbpG9BcdpBjc6lxbzXJNfYsOmOHw?=
 =?us-ascii?Q?b42jiGvHOyIPxMZslrVbVWnKaJkm/mwASSAMF6aH6VxsRziebH5brjsWuzco?=
 =?us-ascii?Q?bdewwH4kkrqTxVYmph0WqnhpF+tQoxlitqI8K24QEoOWmNk7/LfB24YGDWir?=
 =?us-ascii?Q?viJVE3BEj/dSVnrQq93cmi5g6Z2ioF5tls1VvgP9fZf0VJCCcOCeqWIxHVJG?=
 =?us-ascii?Q?hyFTCVzhULGVn7cjJBnhUAMwWDrDrq2C1kBi4pLayVW3qk97uanmLrbH7VzA?=
 =?us-ascii?Q?HqE8t7expgt/cNOqefDC7QPKSCJucWqa7Urtq1iDwALcfyKNqrphaUsD+ino?=
 =?us-ascii?Q?0WDghikVibIJKBVMQVq5xJ+589VVVU2UEXo8P+71ieMZMdRnUIPCU8ZeVGqL?=
 =?us-ascii?Q?IHtGjfFUolVGf5rqzAGK/24TNWyxiR62UPRp2KGS7AmJwGubRA0of+ch4dks?=
 =?us-ascii?Q?7pwcYiSg/r5uWNaPhCpwWY1lrK1bXzAhf2OWgwMk3kTXQZK6qVNlZ/uP54Bt?=
 =?us-ascii?Q?wQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa67e61-f8d6-47d5-80ff-08db291f6ed3
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 08:45:18.4855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mOB4eXV0s5RHLeIFymd2n8MIeDJcnZUggtWYDx6+3I/bk2gaUkJ/cbWbLxHPdQtWlGZnqGg9sOboUFfgoJWOIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9244
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Luiz,

Thank you for your review. I found a way to update the BASS implementation to use ISO sockets instead of raw HCI sockets. However, in order for this solution to work, I had to make a few updates in the Bluetooth kernel, so that I can have the ISO Broadcast support that I need for BASS.

I split the "bt_iso_qos" structure into dedicated structures for unicast and broadcast, and I also added some more broadcast parameters in the broadcast structures so that I can provide the HCI parameters that I need from BlueZ to the Bluetooth kernel. These changes are currently in review internally, but I will submit two patches soon, one for bluetooth-next and one for bluez, containing the bt_iso_qos updates. After these patches will be integrated, I will resubmit the updated BASS patch.

Regards,
Iulia