Date:   Mon, 20 Mar 2023 11:25:26 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux-bluetooth@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v2] Bluetooth: 6LoWPAN: Add missing check for
 skb_clone
Message-ID: <ZBg0ljeZVSpyf6E9@corigine.com>
References: <20230320030846.18481-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230320030846.18481-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dkFWlKLZcwuDrUeXU0/HY/C++UaL1TONnqnhkT+2wVqs1VOSm9GEBTTi2eM0?=
 =?us-ascii?Q?YxDuaX+75BRFO3lOQ8ocilxtSuBe9znb9h+KFaQZgITbqw992bgFTN+aUZXU?=
 =?us-ascii?Q?8J6XqqBUue3qmQNTBnxEghcWoOC/SJ1VuiyUP47s95VlkbXrVHmNLj0icXgb?=
 =?us-ascii?Q?qI1v1AlfQZsjMAeyx3dQyZvphSXMXfvH7wrxyMmHT9o2zPESEE+YOREmJZkN?=
 =?us-ascii?Q?etzFuUKk7iDnDbJZDp2mGG1grkvldnswJsRalyWHBB0M8xh/Ko2PmJ3FNmro?=
 =?us-ascii?Q?O99+bO0SNlRCD9ZyLSZQyUMyuf+6onkpbm2+R9RJPIM/mxebi7SOYHVi4ju9?=
 =?us-ascii?Q?ZYlGqKuG4ThLQZ/mk/5nLZYUtSh60mZ30QbcFJADwMjOYj5302qO/A94I9Rr?=
 =?us-ascii?Q?9hz8/ox9Bf2pWjKHBKwxgcP29v0MeFt8aO/iF/5NfQMroezc4eIzgs5vaR4T?=
 =?us-ascii?Q?gqa/6SITR2jzoRzr+tBQXYLkEzjpNYyLn7hSWvoCj/0NuqiiyG2LIdZ2jF6X?=
 =?us-ascii?Q?TH8CIYkXheWigHiTs6UWCKAp7HEqkJ3XRCDKf/zBn7mcbWGTjSbAqJ2uHe/z?=
 =?us-ascii?Q?zrdufCS+zLRa3jqnyR2RKdvJzc3o88rLLplfStxbgW3jtdg6Yy/3AludlMU3?=
 =?us-ascii?Q?804vS1xzOce1BZZICiiQkj8mZIdUBg0DtH8G4++uwT0f3Xs6Unl1dnr6MJAZ?=
 =?us-ascii?Q?x4aJvV4imQrAQSeLTg6dMolC0dcmKm5td7OaIYp8OEz4/vBnkPoXWm9amPkK?=
 =?us-ascii?Q?o7Jy+HtycHW6XM/UX/8FT9KHqOI2H6LKCZDeSxNKASRT+n5Zw0Fs/uF2gw+S?=
 =?us-ascii?Q?WgUKf8jF7h12Tr1qiAjOiF84jDe6mviGt3p1cbGSOAlWU5B4yi3qeQqdsFNl?=
 =?us-ascii?Q?nc6VnuW43eWL1lLAwpfiDEDxV/dMw5mC/Va34txTn0gaHD5lOSI8ctP6eXOV?=
 =?us-ascii?Q?FME8xgSdY52qog2aT1vVWxqnMabRGOBZhUUqaLkAKqltn8/EHaa2ap0FFsab?=
 =?us-ascii?Q?GpFhIpZY8WcPJ/YdEvTSweTOPDkecSzcjfRPtvaNJ+NAsPYfHOGF4hZ+ktDg?=
 =?us-ascii?Q?yKZvTR4hCEH7mU/PENIWMXib6sAW9B0D04P5PUgUup/4muTA8lsbIvOhPxGp?=
 =?us-ascii?Q?Vqxbrp0OzD6uxVpgst0KIEtzRYEjtCARM8KxkZK0/DoBs2Irk5NRSJMdn1dq?=
 =?us-ascii?Q?YMkArJKFDJQy4OGIPfDdQQG7gt69gYYh1iMk2tSyRrAIm6GOy3Bd5+30rJEm?=
 =?us-ascii?Q?ij+myDOUvl9wor952nZxqNbw9WHqAl8HxPnXIe8AduQu3Nzsc1zrSGuT13CK?=
 =?us-ascii?Q?qQL03bv0EtFujSVKTeyCWIuX/vVV337mCysOeA+2Ws49qwtXBKmoCnVv7EDN?=
 =?us-ascii?Q?+/5xEgYtE0M/H1ySO90xjkz4v1AnvjjhPDoxV/7cECZZOQlsCBB/xvpIRZgA?=
 =?us-ascii?Q?qZfot7j4fxYX98/OJ/yIWn8QEkyEb5dFgU0qgNmKwRiQmKIkfxTqoi2hnLQk?=
 =?us-ascii?Q?24ZyE6InDkfqwrQ6frJnoBJjwJhFijwVPvK4hQ9OXGwoGiq/ie3zLEDvSFlR?=
 =?us-ascii?Q?QOiyrnRccp48D6NhaN3kwqz/MWVXgZSV/ZsU/RLhtvu/EB+G96KMBeFaoMBC?=
 =?us-ascii?Q?wpAoq4FSjTf59HvWytVLXvXz4mikarOt+1hZg0pmJaX9QCxGVy8HA07fQyyW?=
 =?us-ascii?Q?s1NPbg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5afdc1f8-613c-473d-466e-08db292d6fcb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 10:25:33.0802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uQ/ex1bqxsQUCxWtlqY69ZcnPgchjLrN0Z4zHjlT9m4erjC+xYmQ6xW11W0d45Iu0zTE8Q+cqliklSjCcMKFv3aLiKUhMXR8doYmQOO8QX4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR13MB5096
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Mon, Mar 20, 2023 at 11:08:46AM +0800, Jiasheng Jiang wrote:
> On Mon, Mar 20, 2023 at 10:54:40AM +0800, Jiasheng Jiang wrote:
> > On Sat, Mar 18, 2023 at 05:03:21AM +0800, Simon Horman wrote:
> >> On Wed, Mar 15, 2023 at 03:06:21PM +0800, Jiasheng Jiang wrote:
> >>> Add the check for the return value of skb_clone since it may return NULL
> >>> pointer and cause NULL pointer dereference in send_pkt.
> >>> 
> >>> Fixes: 18722c247023 ("Bluetooth: Enable 6LoWPAN support for BT LE devices")
> >>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> >>> ---
> >>> Changelog:
> >>> 
> >>> v1 -> v2:
> >>> 
> >>> 1. Modify the error handling in the loop.
> >> 
> >> I think that at a minimum this needs to be included in the patch description.
> >> Or better, in it's own patch with it's own fixes tag.
> >> It seems like a fundamental change to the error handling to me.
> > 
> > I will submit a separate patch to modify the error handling in the loop.
> > You can directly review the v1.
> > Link:https://lore.kernel.org/all/20230313090346.48778-1-jiasheng@iscas.ac.cn/
> 
> I think it would be better to send a patch series.

Yes, agreed.