Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5933685rwl; Wed, 22 Mar 2023 04:29:22 -0700 (PDT) X-Google-Smtp-Source: AK7set/hARrHKKkfu865agTEGH6O7jCNXDhpp0hm8xmajm0A8AVPhyV99qurx2NPHDyZuAm4mkLB X-Received: by 2002:aa7:cb8f:0:b0:4fa:cbd8:3f6f with SMTP id r15-20020aa7cb8f000000b004facbd83f6fmr6279563edt.6.1679484562198; Wed, 22 Mar 2023 04:29:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679484562; cv=none; d=google.com; s=arc-20160816; b=WVWS3px+pwF9wMqJkp1bTLeHh9pOS3jsZhcwh044U+CK4MjL/P26B12bWDoKhT/aMy 5eYNvKghczO6wzelEzItP17HbZQR3VerkcYgM139mK1dUskFhybwjio6FPYfFVFKSK4s /VQmxcXtz2mIDpBYlHPGvMj98plCVdR41RrHdIpcGH3GhyKKSaRO6Jl0ASND1LX6t19g JDyLTCye9OjpOEznN8sfEkXGdp15gWAXtLp3rLS6Bf9wpKoT0vjQkHg0LJXAtkLITo55 31F7v4wrh+q9jx5TiY6n1DgCQCPWh2xRctq+FJkLmnjO84F+kwr03Y4GlcsRj172LuyU j/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=t0p6AgRn3pHYkSwjNJK7iQMLTURcE/R8cFtfH6NQCU4=; b=zxdRamhsHvhw1EFDyaqZsWbfa3qZMylQMdHyUT2OUORMyBfGELJx69Pxrhg6PkyCpp qfe5UvTecysxr3LB6SqTloRbOoDvxMvmxJH2IBpe64A4FEchGzVGMlk4xBprqKyV349O nLP7Xs0KDkJJl5Yq9W91c5g5sSg3+ME4vTcLiDk8ThdSc3tG1mHXEOrpBNF3cL3Yd6P9 UHM60mADHMN0F9MwSNvl6H51QZrQo1xrQ4U7k65RlVw+i58dOnul6l9QlXTkBuV5747R MNvgF/8u46dItuxZrA7ZF2r25pafC3R8nvV/H/iBLFEuOMr6gyPHo6DGesbhypzYGOah iG1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uXPsblQ4; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020aa7c98c000000b004ad6d76c2e2si15570716edt.190.2023.03.22.04.28.29; Wed, 22 Mar 2023 04:29:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uXPsblQ4; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjCVLQq (ORCPT + 99 others); Wed, 22 Mar 2023 07:16:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbjCVLQq (ORCPT ); Wed, 22 Mar 2023 07:16:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D934DE3A; Wed, 22 Mar 2023 04:16:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BA53FB81C25; Wed, 22 Mar 2023 11:16:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1F67C433EF; Wed, 22 Mar 2023 11:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679483802; bh=yqsVMZSFa5CHTkdXUK3mvMZizZ/0pAtToVHTZzG7V08=; h=From:To:Cc:Subject:Date:From; b=uXPsblQ4hdJoTyh88MHVK7pYObNP7FBOJMP85AqLZOstUZf0ZWR0iEcDMmh+ZI6s7 63UZTr5VUAqE8w7PYUVM0h9YSCuFqg3V39BUvUfvHt2bFi3b1ZcjgAckvHaRgYWFVp RQlI86egWs9j3QNWSRr2TQB0MTkLFThXz2TsdAOfHiRksgRIh2gEzdq2saMQ6zSieo klpbpF3WrlotXM6fACaL6MF+sAh96zMo/+I4EOlOg2FZQE6WjrECjNxzhjFChpT5bF LX6l/XmQqk+q+mFzb/nutpb7RJIErp2HGcGLrOh0ynw3P4K1IgcES8fsOjS5rh2F4j z8mtJpdzXUxKA== From: Arnd Bergmann To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Neeraj Sanjay Kale , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: Arnd Bergmann , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Bluetooth: NXP: select CONFIG_CRC8 Date: Wed, 22 Mar 2023 12:16:27 +0100 Message-Id: <20230322111636.1028838-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Arnd Bergmann The driver needs both CRC32 and CRC8 to link correctly: ld.lld: error: undefined symbol: crc8_populate_msb >>> referenced by btnxpuart.c >>> drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a ld.lld: error: undefined symbol: crc8 >>> referenced by btnxpuart.c >>> drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets") Signed-off-by: Arnd Bergmann --- drivers/bluetooth/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 0703bdd44140..f84322d375de 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -469,6 +469,7 @@ config BT_NXPUART tristate "NXP protocol support" depends on SERIAL_DEV_BUS select CRC32 + select CRC8 help NXP is serial driver required for NXP Bluetooth devices with UART interface. -- 2.39.2