Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 15:31:04 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     hildawu@realtek.com
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux-bluetooth@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        apusaka@chromium.org, mmandlik@google.com, yinghsu@chromium.org,
        max.chou@realtek.com, alex_lu@realsil.com.cn, kidman@realtek.com
Subject: Re: [PATCH v2] Bluetooth: msft: Extended monitor tracking by address
 filter
Message-ID: <ZBxiqB7uboVw23Jl@corigine.com>
References: <20230322072712.20829-1-hildawu@realtek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322072712.20829-1-hildawu@realtek.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iqWwDitl5Re9SVN9CCvldSfDtxsyyqSUxWI0J39hegOFDffDSwEC16ZQgO8A?=
 =?us-ascii?Q?paT3MA0VkxZpYjH/qVo/nbhrXLVm2Tc10kztTZ/F9Rja74BkRF1ICehTTNuR?=
 =?us-ascii?Q?2DfSPFFJ2pCo7a3LOJeOO53pADQW+v6212owHtwjQCpAL3/m4+g2FEu9W7wf?=
 =?us-ascii?Q?tP4z73ni64PbLDVRg3suYI0pwr776KArPNAXBKpGZp/54hFsv1TpHt9BSLv5?=
 =?us-ascii?Q?a4h7b6Qqd2YC/WihsTZfL00M8lqhL4z5Maj4GoohT7hqkUYIlVjgHHq3+RQN?=
 =?us-ascii?Q?qT2E9QO+uGeknO8WIBffTlb0DOG0Cyt+4b/ivpjoNngpkNLgO2QM9/wnlsE4?=
 =?us-ascii?Q?NmEGjEgeTea/i7Pa6XWLrw+bQRN+HFztJGVYn4nQ1YyPWpzw5Q+aYyY52m4p?=
 =?us-ascii?Q?hw/5KEedJEYKDjY1U1ckSuq2mXyCD5ruDCCF2y0gDJPDG/knVgn8mqgtDfYb?=
 =?us-ascii?Q?TH+NVl4ADBHSeQzGm7zAkNCAJG+lljWJ+IPWourUBge9hXefE9aXIgadTPvA?=
 =?us-ascii?Q?9Dr5Vt2q07xCp5XZed0dd7NVUpVETHaFfL7flKUnVWtiwsEUDz2uzVQtJqVv?=
 =?us-ascii?Q?+gwJRpv5D4ESHstt/maBxET8Aa0cYJAAyAg1vy4AYJoDskTdIb0GvYBygOJk?=
 =?us-ascii?Q?dF4+bCCgOm9WHpwlzv74obbUECkFKMkDfz2e2lLiVeiCYT/vcdvt0k5Y1qaE?=
 =?us-ascii?Q?yih0cBGVBxuJ/T7RteoLd1ljV80PjeN/CKJCEora2FebYlFYOeYVWq7nnaCn?=
 =?us-ascii?Q?Fb5u4nPcHxQ9XicqBUj0dbTKXWTGHtcNa8PkrCJCBTwqJtAz+SuBCftLmccj?=
 =?us-ascii?Q?L5OWFNf9jugMG0Ql13PAHkpuD17XKK7mh/NKWba8scByovep0bi/odQHRhAX?=
 =?us-ascii?Q?tjrLxdNo6CjxqlGZX4a2Zr6Y9svQpeCePcWP6Otk/MU5rrevM1yBP80QWLeU?=
 =?us-ascii?Q?63GO+tFHOrJPeNhJF9YBeqelrobn/KcaxwBqA4YsCxEq7LmTQ0hiVDT0Mrm+?=
 =?us-ascii?Q?1jENjw/ldpU6iJZ/RwVhD2lxl2UnSHtMj/QPMDbGDCQhEddSOQtqFizBsYa+?=
 =?us-ascii?Q?Dy3GINo9mJbxCp48dOIg9wwbNHLIiN7Hzcgor7D6VbEMK96XDrUrSjkKpSVi?=
 =?us-ascii?Q?pwxYjsNULqelRieCaNfz3AtZ0h4DNqJsmy0LAuhYOzNDtXgGFvhfTUxvi9aF?=
 =?us-ascii?Q?LxRfCGT1z5x1TiuuCzuUD3ZBLmEDz68puSMg/nV7gDnTIOE1B8+SHFIRsiyq?=
 =?us-ascii?Q?eGMix1UpKchx/RCviK+4QCjdt7/qw2OZUjNgva1ZKnpYIWSbI7Lqz6MrsZe2?=
 =?us-ascii?Q?ZrsK8u9Zw0XM12G6UdfBC3XctXuuTjLW8n88MlAE0EfpFWTBCqa8jbtsoyIg?=
 =?us-ascii?Q?IEkOdzGfmiiFGpOoTotnncwtIhxRM3/JT04s1T6fcNJrM+FTF68A19RoL/Fg?=
 =?us-ascii?Q?2EjbzkRjZVW5M4rFn/i4y78NloWRbznkbXXYQ9HDmxAMxsclSNyKQCO/Kcio?=
 =?us-ascii?Q?VIAU06DclIvTIEyqT19xX6+DCqS0zDhCWb12725ykOjbIjn25EmfRgyX21VX?=
 =?us-ascii?Q?DER9uYj4NlBAnPwQCLnabjmrfye6E/w6RyJxC7gWSADniVxoeIDP+Xplks8J?=
 =?us-ascii?Q?twww1mPad/6wa5cn1+LFMLlb5PC4eceZftZJJHUeGcXG+oBhKXTDb5gF8hSu?=
 =?us-ascii?Q?tyyzmg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e368fa8-6415-4baa-9e76-08db2bab4064
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 14:31:12.5138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e2ZWdwFS+r3lZrO6ISPA6jg3GONrv1fQHZxqcZquOZkMjp1fteBMRRlT6RP4ip5iR8PyqWMFE/CHdqr4j2BSiLFC49hhd2wMJ2PDLFUU7i0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB6133
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Wed, Mar 22, 2023 at 03:27:12PM +0800, hildawu@realtek.com wrote:
> From: Hilda Wu <hildawu@realtek.com>
> 
> Since limited tracking device per condition, this feature is to support
> tracking multiple devices concurrently.
> When a pattern monitor detects the device, this feature issues an address
> monitor for tracking that device. Let pattern monitor can keep monitor
> new devices.
> This feature adds an address filter when receiving a LE monitor device
> event which monitor handle is for a pattern, and the controller started
> monitoring the device. And this feature also has cancelled the monitor
> advertisement from address filters when receiving a LE monitor device
> event when the controller stopped monitoring the device specified by an
> address and monitor handle.
> 
> Signed-off-by: Alex Lu <alex_lu@realsil.com.cn>
> Signed-off-by: Hilda Wu <hildawu@realtek.com>
> ---
> Changes in v2:
> - Fixed build bot warning, removed un-used parameter.
> - Follow suggested, adjust for readability and idiomatic, modified
>   error case, etc.

Thanks for addressing my review.

If you do need to spin a v3, then you might want to consider using
reverse xmas tree universally for local variable declarations
in your new code.

But that notwithstanding, from a code-style sanity check pov:

Reviewed-by: Simon Horman <simon.horman@corigine.com>